[INFO] updating cached repository 07th-mod/ui-editing-scripts [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/07th-mod/ui-editing-scripts [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/07th-mod/ui-editing-scripts" "work/ex/clippy-test-run/sources/stable/gh/07th-mod/ui-editing-scripts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/07th-mod/ui-editing-scripts'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/07th-mod/ui-editing-scripts" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/07th-mod/ui-editing-scripts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/07th-mod/ui-editing-scripts'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4e8032cbf6c6afc2092bc802397d643f7b0e8ba2 [INFO] sha for GitHub repo 07th-mod/ui-editing-scripts: 4e8032cbf6c6afc2092bc802397d643f7b0e8ba2 [INFO] validating manifest of 07th-mod/ui-editing-scripts on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 07th-mod/ui-editing-scripts on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 07th-mod/ui-editing-scripts [INFO] finished frobbing 07th-mod/ui-editing-scripts [INFO] frobbed toml for 07th-mod/ui-editing-scripts written to work/ex/clippy-test-run/sources/stable/gh/07th-mod/ui-editing-scripts/Cargo.toml [INFO] started frobbing 07th-mod/ui-editing-scripts [INFO] finished frobbing 07th-mod/ui-editing-scripts [INFO] frobbed toml for 07th-mod/ui-editing-scripts written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/07th-mod/ui-editing-scripts/Cargo.toml [INFO] crate 07th-mod/ui-editing-scripts has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 07th-mod/ui-editing-scripts against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/07th-mod/ui-editing-scripts:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d9cfbb4e6b21d37bc20dbfc5e148841021fcee9a41c0ff8fdce11608a52c7fc [INFO] running `"docker" "start" "-a" "0d9cfbb4e6b21d37bc20dbfc5e148841021fcee9a41c0ff8fdce11608a52c7fc"` [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking Inflector v0.11.3 [INFO] [stderr] Checking ui-compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let arc_number = chapters.get(chapter).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&chapters[chapter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | let arc_type = if arc_number <= &4 { "question_arcs" } else { "answer_arcs" }; [INFO] [stderr] | ^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:50:65 [INFO] [stderr] | [INFO] [stderr] 50 | let archive = format!("{}-{}.7z", &chapter.to_title_case(), suffixes.get(platform).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&suffixes[platform]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let arc_number = chapters.get(chapter).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&chapters[chapter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | let arc_type = if arc_number <= &4 { "question_arcs" } else { "answer_arcs" }; [INFO] [stderr] | ^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:50:65 [INFO] [stderr] | [INFO] [stderr] 50 | let archive = format!("{}-{}.7z", &chapter.to_title_case(), suffixes.get(platform).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&suffixes[platform]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.24s [INFO] running `"docker" "inspect" "0d9cfbb4e6b21d37bc20dbfc5e148841021fcee9a41c0ff8fdce11608a52c7fc"` [INFO] running `"docker" "rm" "-f" "0d9cfbb4e6b21d37bc20dbfc5e148841021fcee9a41c0ff8fdce11608a52c7fc"` [INFO] [stdout] 0d9cfbb4e6b21d37bc20dbfc5e148841021fcee9a41c0ff8fdce11608a52c7fc