[INFO] updating cached repository 02alexander/maze-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/02alexander/maze-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/02alexander/maze-generator" "work/ex/clippy-test-run/sources/stable/gh/02alexander/maze-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/02alexander/maze-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/02alexander/maze-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/02alexander/maze-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/02alexander/maze-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] defd57655ec68cc273815234496f81e2a6613f59 [INFO] sha for GitHub repo 02alexander/maze-generator: defd57655ec68cc273815234496f81e2a6613f59 [INFO] validating manifest of 02alexander/maze-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 02alexander/maze-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 02alexander/maze-generator [INFO] finished frobbing 02alexander/maze-generator [INFO] frobbed toml for 02alexander/maze-generator written to work/ex/clippy-test-run/sources/stable/gh/02alexander/maze-generator/Cargo.toml [INFO] started frobbing 02alexander/maze-generator [INFO] finished frobbing 02alexander/maze-generator [INFO] frobbed toml for 02alexander/maze-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/02alexander/maze-generator/Cargo.toml [INFO] crate 02alexander/maze-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 02alexander/maze-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/02alexander/maze-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d05e3c7e9d89c9b07248e2ce2b10fade480515ca7dd5cdefc8e29f873a91f5c4 [INFO] running `"docker" "start" "-a" "d05e3c7e9d89c9b07248e2ce2b10fade480515ca7dd5cdefc8e29f873a91f5c4"` [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking imagefmt v4.0.0 [INFO] [stderr] Checking maze-generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | width:width, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | height:height, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | grid:grid, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | Coordinate { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | Coordinate { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | width:width, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | height:height, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | grid:grid, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | Coordinate { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/maze.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | Coordinate { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/maze/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod maze; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/maze/maze.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | let mut is_visited = false; // set to true when we find an adjacent tile [INFO] [stderr] | _________^ [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | // if left cell is connected [INFO] [stderr] 83 | | if self.is_inside(cell.x as i32 - 1, cell.y as i32) && self.grid[cell.x-1][cell.y] == 1 { [INFO] [stderr] 84 | | is_visited = true; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let is_visited = if self.is_inside(cell.x as i32 - 1, cell.y as i32) && self.grid[cell.x-1][cell.y] == 1 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/maze/maze.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/maze/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod maze; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/maze/maze.rs:80:3 [INFO] [stderr] | [INFO] [stderr] 80 | let mut is_visited = false; // set to true when we find an adjacent tile [INFO] [stderr] | _________^ [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | // if left cell is connected [INFO] [stderr] 83 | | if self.is_inside(cell.x as i32 - 1, cell.y as i32) && self.grid[cell.x-1][cell.y] == 1 { [INFO] [stderr] 84 | | is_visited = true; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let is_visited = if self.is_inside(cell.x as i32 - 1, cell.y as i32) && self.grid[cell.x-1][cell.y] == 1 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/maze/maze.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.78s [INFO] running `"docker" "inspect" "d05e3c7e9d89c9b07248e2ce2b10fade480515ca7dd5cdefc8e29f873a91f5c4"` [INFO] running `"docker" "rm" "-f" "d05e3c7e9d89c9b07248e2ce2b10fade480515ca7dd5cdefc8e29f873a91f5c4"` [INFO] [stdout] d05e3c7e9d89c9b07248e2ce2b10fade480515ca7dd5cdefc8e29f873a91f5c4