[INFO] crate yultsur 0.1.0 is already in cache [INFO] extracting crate yultsur 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/yultsur/0.1.0 [INFO] extracting crate yultsur 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yultsur/0.1.0 [INFO] validating manifest of yultsur-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yultsur-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yultsur-0.1.0 [INFO] finished frobbing yultsur-0.1.0 [INFO] frobbed toml for yultsur-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/yultsur/0.1.0/Cargo.toml [INFO] started frobbing yultsur-0.1.0 [INFO] finished frobbing yultsur-0.1.0 [INFO] frobbed toml for yultsur-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yultsur/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yultsur-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yultsur/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad603ee8c96c747d8e6eaa3b0e0daaff1a37156820241e23b3d863a1e114f751 [INFO] running `"docker" "start" "-a" "ad603ee8c96c747d8e6eaa3b0e0daaff1a37156820241e23b3d863a1e114f751"` [INFO] [stderr] Checking yultsur v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `custom` [INFO] [stderr] --> src/validator.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | Type::Custom(ref custom) => Ok(()), [INFO] [stderr] | ^^^^^^ help: consider using `_custom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `typed` [INFO] [stderr] --> src/validator.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | fn validate(&self, typed: bool) -> Result<(), String> { [INFO] [stderr] | ^^^^^ help: consider using `_typed` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:197:12 [INFO] [stderr] | [INFO] [stderr] 197 | if self.returns.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.returns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:216:12 [INFO] [stderr] | [INFO] [stderr] 216 | if self.identifiers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:240:12 [INFO] [stderr] | [INFO] [stderr] 240 | if self.identifiers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | if literal.literal.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validator.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if literal.literal.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `custom` [INFO] [stderr] --> src/validator.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | Type::Custom(ref custom) => Ok(()), [INFO] [stderr] | ^^^^^^ help: consider using `_custom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `typed` [INFO] [stderr] --> src/validator.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | fn validate(&self, typed: bool) -> Result<(), String> { [INFO] [stderr] | ^^^^^ help: consider using `_typed` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:197:12 [INFO] [stderr] | [INFO] [stderr] 197 | if self.returns.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.returns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:216:12 [INFO] [stderr] | [INFO] [stderr] 216 | if self.identifiers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:240:12 [INFO] [stderr] | [INFO] [stderr] 240 | if self.identifiers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.identifiers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/yul.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | if literal.literal.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validator.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if literal.literal.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.literal.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.70s [INFO] running `"docker" "inspect" "ad603ee8c96c747d8e6eaa3b0e0daaff1a37156820241e23b3d863a1e114f751"` [INFO] running `"docker" "rm" "-f" "ad603ee8c96c747d8e6eaa3b0e0daaff1a37156820241e23b3d863a1e114f751"` [INFO] [stdout] ad603ee8c96c747d8e6eaa3b0e0daaff1a37156820241e23b3d863a1e114f751