[INFO] crate yaecs 0.11.0 is already in cache [INFO] extracting crate yaecs 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/yaecs/0.11.0 [INFO] extracting crate yaecs 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yaecs/0.11.0 [INFO] validating manifest of yaecs-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yaecs-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yaecs-0.11.0 [INFO] finished frobbing yaecs-0.11.0 [INFO] frobbed toml for yaecs-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/yaecs/0.11.0/Cargo.toml [INFO] started frobbing yaecs-0.11.0 [INFO] finished frobbing yaecs-0.11.0 [INFO] frobbed toml for yaecs-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yaecs/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yaecs-0.11.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/yaecs/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83a7269ce8fecef02593a7781b41c0b63a209cd9976ec5c52f30c04b01a63bdc [INFO] running `"docker" "start" "-a" "83a7269ce8fecef02593a7781b41c0b63a209cd9976ec5c52f30c04b01a63bdc"` [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking tabwriter v0.1.25 [INFO] [stderr] Checking colored v1.7.0 [INFO] [stderr] Checking yaecs v0.11.0 (/opt/crater/workdir) [INFO] [stderr] Checking avow v0.1.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `entities::Entities` [INFO] [stderr] --> src/entities.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Entities { [INFO] [stderr] 8 | | Entities(vec![]) [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entity_builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn add(mut self, component: T) -> EntityBuilder { [INFO] [stderr] 16 | | self.0.components.insert(component); [INFO] [stderr] 17 | | self [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/entity.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.tags.get("label").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.tags["label"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> World { [INFO] [stderr] 12 | | World { [INFO] [stderr] 13 | | entities: Entities::new(), [INFO] [stderr] 14 | | globals: Globals::new(), [INFO] [stderr] 15 | | systems: vec![], [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for world::World { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entity.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/basic.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/entities.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | let mut unwrapped = results.pop().unwrap(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/entities.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let mut unwrapped_component = unwrapped.components.get_mut::().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/entities.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | let mut unwrapped = test_component.components.get_mut::().unwrap(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/entities.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | let mut unwrapped = test_component.unwrap(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `entities::Entities` [INFO] [stderr] --> src/entities.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn new() -> Entities { [INFO] [stderr] 8 | | Entities(vec![]) [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entity_builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn add(mut self, component: T) -> EntityBuilder { [INFO] [stderr] 16 | | self.0.components.insert(component); [INFO] [stderr] 17 | | self [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/entity.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.tags.get("label").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.tags["label"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> World { [INFO] [stderr] 12 | | World { [INFO] [stderr] 13 | | entities: Entities::new(), [INFO] [stderr] 14 | | globals: Globals::new(), [INFO] [stderr] 15 | | systems: vec![], [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for world::World { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/world.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let ref entity = world.entities[0]; [INFO] [stderr] | ----^^^^^^^^^^--------------------- help: try: `let entity = &world.entities[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.30s [INFO] running `"docker" "inspect" "83a7269ce8fecef02593a7781b41c0b63a209cd9976ec5c52f30c04b01a63bdc"` [INFO] running `"docker" "rm" "-f" "83a7269ce8fecef02593a7781b41c0b63a209cd9976ec5c52f30c04b01a63bdc"` [INFO] [stdout] 83a7269ce8fecef02593a7781b41c0b63a209cd9976ec5c52f30c04b01a63bdc