[INFO] crate xorshift128plus-rs 0.1.6 is already in cache [INFO] extracting crate xorshift128plus-rs 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/xorshift128plus-rs/0.1.6 [INFO] extracting crate xorshift128plus-rs 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xorshift128plus-rs/0.1.6 [INFO] validating manifest of xorshift128plus-rs-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xorshift128plus-rs-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xorshift128plus-rs-0.1.6 [INFO] finished frobbing xorshift128plus-rs-0.1.6 [INFO] frobbed toml for xorshift128plus-rs-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/xorshift128plus-rs/0.1.6/Cargo.toml [INFO] started frobbing xorshift128plus-rs-0.1.6 [INFO] finished frobbing xorshift128plus-rs-0.1.6 [INFO] frobbed toml for xorshift128plus-rs-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xorshift128plus-rs/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xorshift128plus-rs-0.1.6 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/xorshift128plus-rs/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dc8cc682ac2a76ff896777f72d95fead07308db828e251e0d50987c5d105a7f [INFO] running `"docker" "start" "-a" "4dc8cc682ac2a76ff896777f72d95fead07308db828e251e0d50987c5d105a7f"` [INFO] [stderr] Checking xorshift128plus-rs v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | self.state[0] = Wrapping(1812433253) * (self.seed ^ (self.seed >> 30)) + Wrapping(1); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_812_433_253` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | self.state[1] = Wrapping(1812433253) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_812_433_253` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | self.state[0] = Wrapping(1812433253) * (self.seed ^ (self.seed >> 30)) + Wrapping(1); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_812_433_253` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | self.state[1] = Wrapping(1812433253) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_812_433_253` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn next(&mut self) -> u64 { [INFO] [stderr] 29 | | let x = self.state[0] ^ self.state[0] << 23; [INFO] [stderr] 30 | | let y = self.state[1]; [INFO] [stderr] 31 | | self.state[0] = y; [INFO] [stderr] 32 | | self.state[1] = x ^ y ^ (x >> 18) ^ (y >> 5); [INFO] [stderr] 33 | | (self.state[1] + y).0 [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:130:19 [INFO] [stderr] | [INFO] [stderr] 130 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | std::f64::MAX * (prng.random_factor() - prng.random_factor()) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(prng.random_factor() - prng.random_factor())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | (min + (prng.random_factor() * diff)) as Self [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(min + (prng.random_factor() * diff))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn next(&mut self) -> u64 { [INFO] [stderr] 29 | | let x = self.state[0] ^ self.state[0] << 23; [INFO] [stderr] 30 | | let y = self.state[1]; [INFO] [stderr] 31 | | self.state[0] = y; [INFO] [stderr] 32 | | self.state[1] = x ^ y ^ (x >> 18) ^ (y >> 5); [INFO] [stderr] 33 | | (self.state[1] + y).0 [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:130:19 [INFO] [stderr] | [INFO] [stderr] 130 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | let diff = maximum.wrapping_sub(minimum) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(maximum.wrapping_sub(minimum))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:143:19 [INFO] [stderr] | [INFO] [stderr] 143 | let min = minimum as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(minimum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:203:25 [INFO] [stderr] | [INFO] [stderr] 203 | std::f64::MAX * (prng.random_factor() - prng.random_factor()) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(prng.random_factor() - prng.random_factor())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | (min + (prng.random_factor() * diff)) as Self [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(min + (prng.random_factor() * diff))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "4dc8cc682ac2a76ff896777f72d95fead07308db828e251e0d50987c5d105a7f"` [INFO] running `"docker" "rm" "-f" "4dc8cc682ac2a76ff896777f72d95fead07308db828e251e0d50987c5d105a7f"` [INFO] [stdout] 4dc8cc682ac2a76ff896777f72d95fead07308db828e251e0d50987c5d105a7f