[INFO] crate wrap 0.1.0 is already in cache [INFO] extracting crate wrap 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wrap/0.1.0 [INFO] extracting crate wrap 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wrap/0.1.0 [INFO] validating manifest of wrap-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wrap-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wrap-0.1.0 [INFO] finished frobbing wrap-0.1.0 [INFO] frobbed toml for wrap-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wrap/0.1.0/Cargo.toml [INFO] started frobbing wrap-0.1.0 [INFO] finished frobbing wrap-0.1.0 [INFO] frobbed toml for wrap-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wrap/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wrap-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wrap/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4964e5401fdbac792d5258225436dd71bbd2d57f4566c0d52db32f6efdc77d54 [INFO] running `"docker" "start" "-a" "4964e5401fdbac792d5258225436dd71bbd2d57f4566c0d52db32f6efdc77d54"` [INFO] [stderr] Checking wrap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> examples/readme.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / wrap_with!{log1 >> [INFO] [stderr] 25 | | fn greet_logged_inner(name: &str) -> String = { [INFO] [stderr] 26 | | format!("How are you, {}?", name) [INFO] [stderr] 27 | | }} [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 9 | wrapped_res : $ wrapped_body_ret = { [INFO] [stderr] 10 | format!("How are you, {}?", name) [INFO] [stderr] 11 | } ; let _ = $ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> examples/readme.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / wrap_with!{log2 >> [INFO] [stderr] 31 | | fn greet_logged(name: &str) -> String = { [INFO] [stderr] 32 | | format!("Hello! {}", greet_logged_inner(name)) [INFO] [stderr] 33 | | }} [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 9 | wrapped_res : $ wrapped_body_ret = { [INFO] [stderr] 10 | format!("Hello! {}", greet_logged_inner(name)) [INFO] [stderr] 11 | } ; let _ = $ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> examples/basic.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / wrap_with!{with_conn -> conn: Conn; >> [INFO] [stderr] 70 | | fn get_key(key: &str) -> Option = { [INFO] [stderr] 71 | | let v: Option = conn.query(key); [INFO] [stderr] 72 | | v [INFO] [stderr] 73 | | }} [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> examples/basic.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | / wrap_with!{spooky_action -> _nil: (); >> [INFO] [stderr] 79 | | fn get_key_spooky(key: &str) -> Option = { [INFO] [stderr] 80 | | get_key(key) [INFO] [stderr] 81 | | }} [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> examples/basic.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / wrap_with!{log >> [INFO] [stderr] 89 | | fn get_key_spooky_logged(key: &str) -> Option = { [INFO] [stderr] 90 | | get_key_spooky(key) [INFO] [stderr] 91 | | }} [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 9 | wrapped_res : $ wrapped_body_ret = { [INFO] [stderr] 10 | get_key_spooky(key) [INFO] [stderr] 11 | } ; let _ = $ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> examples/basic.rs:94:1 [INFO] [stderr] | [INFO] [stderr] 94 | / wrap_with!{with_conn -> mut conn: Conn; >> [INFO] [stderr] 95 | | fn set_key(key: String, value: String) -> () = { [INFO] [stderr] 96 | | conn.insert(key, value); [INFO] [stderr] 97 | | }} [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/basic.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.0.get(key).map(|s| s.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.0.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "4964e5401fdbac792d5258225436dd71bbd2d57f4566c0d52db32f6efdc77d54"` [INFO] running `"docker" "rm" "-f" "4964e5401fdbac792d5258225436dd71bbd2d57f4566c0d52db32f6efdc77d54"` [INFO] [stdout] 4964e5401fdbac792d5258225436dd71bbd2d57f4566c0d52db32f6efdc77d54