[INFO] crate wordcut-engine 0.2.0 is already in cache [INFO] extracting crate wordcut-engine 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/wordcut-engine/0.2.0 [INFO] extracting crate wordcut-engine 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wordcut-engine/0.2.0 [INFO] validating manifest of wordcut-engine-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wordcut-engine-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wordcut-engine-0.2.0 [INFO] finished frobbing wordcut-engine-0.2.0 [INFO] frobbed toml for wordcut-engine-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/wordcut-engine/0.2.0/Cargo.toml [INFO] started frobbing wordcut-engine-0.2.0 [INFO] finished frobbing wordcut-engine-0.2.0 [INFO] frobbed toml for wordcut-engine-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wordcut-engine/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wordcut-engine-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wordcut-engine/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c3a715891cf44c6f13a1e49f11cc9ddec4e8e4ef76c4f0359d1b0eb171bbfde [INFO] running `"docker" "start" "-a" "4c3a715891cf44c6f13a1e49f11cc9ddec4e8e4ef76c4f0359d1b0eb171bbfde"` [INFO] [stderr] Checking prefixtree v0.1.3 [INFO] [stderr] Checking wordcut-engine v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | is_pat_char: is_pat_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_pat_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | etype: etype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `etype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:33 [INFO] [stderr] | [INFO] [stderr] 514 | ranges.push(TextRange { s: s, e: e }); [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:39 [INFO] [stderr] | [INFO] [stderr] 514 | ranges.push(TextRange { s: s, e: e }); [INFO] [stderr] | ^^^^ help: replace it with: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:541:17 [INFO] [stderr] | [INFO] [stderr] 541 | Wordcut{dict: dict} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | is_pat_char: is_pat_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_pat_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | etype: etype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `etype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:33 [INFO] [stderr] | [INFO] [stderr] 514 | ranges.push(TextRange { s: s, e: e }); [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:39 [INFO] [stderr] | [INFO] [stderr] 514 | ranges.push(TextRange { s: s, e: e }); [INFO] [stderr] | ^^^^ help: replace it with: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:541:17 [INFO] [stderr] | [INFO] [stderr] 541 | Wordcut{dict: dict} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return a.unwrap().better_than(&b.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.unwrap().better_than(&b.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | return best_edge [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | return path [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:493:5 [INFO] [stderr] | [INFO] [stderr] 493 | return dag [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `dag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:518:5 [INFO] [stderr] | [INFO] [stderr] 518 | return ranges [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:531:5 [INFO] [stderr] | [INFO] [stderr] 531 | return str_vec [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `str_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:548:9 [INFO] [stderr] | [INFO] [stderr] 548 | return path_to_ranges(&path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path_to_ranges(&path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:554:9 [INFO] [stderr] | [INFO] [stderr] 554 | return path_to_str_vec(&path, &text) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path_to_str_vec(&path, &text)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:571:5 [INFO] [stderr] | [INFO] [stderr] 571 | return Ok(create_prefix_tree(&wordlist)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(create_prefix_tree(&wordlist))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return a.unwrap().better_than(&b.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.unwrap().better_than(&b.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | return best_edge [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | return path [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:493:5 [INFO] [stderr] | [INFO] [stderr] 493 | return dag [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `dag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:518:5 [INFO] [stderr] | [INFO] [stderr] 518 | return ranges [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:531:5 [INFO] [stderr] | [INFO] [stderr] 531 | return str_vec [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `str_vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:548:9 [INFO] [stderr] | [INFO] [stderr] 548 | return path_to_ranges(&path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path_to_ranges(&path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:554:9 [INFO] [stderr] | [INFO] [stderr] 554 | return path_to_str_vec(&path, &text) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path_to_str_vec(&path, &text)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:571:5 [INFO] [stderr] | [INFO] [stderr] 571 | return Ok(create_prefix_tree(&wordlist)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(create_prefix_tree(&wordlist))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | fn to_text_state(&mut self, nch: Option) -> State { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | fn to_space_state(&mut self, nch: Option) -> State { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | fn to_another_state(&mut self, ch: char, nch: Option) -> State { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | fn to_text_state(&mut self, nch: Option) -> State { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | fn to_space_state(&mut self, nch: Option) -> State { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | fn to_another_state(&mut self, ch: char, nch: Option) -> State { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `UnkEdgeBuilder` [INFO] [stderr] --> src/lib.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn new() -> UnkEdgeBuilder { [INFO] [stderr] 247 | | UnkEdgeBuilder{} [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:339:65 [INFO] [stderr] | [INFO] [stderr] 339 | } else if edge.better_than(&best_edge.unwrap()) { [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 340 | | best_edge = Some(edge) [INFO] [stderr] 341 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:337:40 [INFO] [stderr] | [INFO] [stderr] 337 | if best_edge.is_none() { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 338 | | best_edge = Some(edge) [INFO] [stderr] 339 | | } else if edge.better_than(&best_edge.unwrap()) { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:356:38 [INFO] [stderr] | [INFO] [stderr] 356 | pub fn build_path(dict: &Dict, text: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `text` [INFO] [stderr] --> src/lib.rs:379:14 [INFO] [stderr] | [INFO] [stderr] 379 | for i in 0..text.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 379 | for (i, ) in text.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:451:37 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn build_dag(dict: &Dict, text: &Vec) -> Dag { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:460:14 [INFO] [stderr] | [INFO] [stderr] 460 | for _ in 0..text.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=text.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `text` [INFO] [stderr] --> src/lib.rs:472:14 [INFO] [stderr] | [INFO] [stderr] 472 | for i in 0..text.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 472 | for (i, ) in text.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dag` [INFO] [stderr] --> src/lib.rs:485:14 [INFO] [stderr] | [INFO] [stderr] 485 | for i in 1..text.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 485 | for (i, ) in dag.iter_mut().enumerate().skip(1).take(text.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `UnkEdgeBuilder` [INFO] [stderr] [INFO] [stderr] --> src/lib.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn new() -> UnkEdgeBuilder { [INFO] [stderr] 247 | | UnkEdgeBuilder{} [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:485:14 [INFO] [stderr] | [INFO] [stderr] 485 | for i in 1..text.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=text.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:486:12 [INFO] [stderr] | [INFO] [stderr] 486 | if dag[i].len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dag[i].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `text`. [INFO] [stderr] --> src/lib.rs:526:18 [INFO] [stderr] | [INFO] [stderr] 526 | for i in r.s..r.e { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 526 | for in text.iter().take(r.e).skip(r.s) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:339:65 [INFO] [stderr] | [INFO] [stderr] 339 | } else if edge.better_than(&best_edge.unwrap()) { [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 340 | | best_edge = Some(edge) [INFO] [stderr] 341 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:337:40 [INFO] [stderr] | [INFO] [stderr] 337 | if best_edge.is_none() { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 338 | | best_edge = Some(edge) [INFO] [stderr] 339 | | } else if edge.better_than(&best_edge.unwrap()) { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:356:38 [INFO] [stderr] | [INFO] [stderr] 356 | pub fn build_path(dict: &Dict, text: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `text` [INFO] [stderr] --> src/lib.rs:379:14 [INFO] [stderr] | [INFO] [stderr] 379 | for i in 0..text.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 379 | for (i, ) in text.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:451:37 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn build_dag(dict: &Dict, text: &Vec) -> Dag { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:460:14 [INFO] [stderr] | [INFO] [stderr] 460 | for _ in 0..text.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=text.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `text` [INFO] [stderr] --> src/lib.rs:472:14 [INFO] [stderr] | [INFO] [stderr] 472 | for i in 0..text.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 472 | for (i, ) in text.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dag` [INFO] [stderr] --> src/lib.rs:485:14 [INFO] [stderr] | [INFO] [stderr] 485 | for i in 1..text.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 485 | for (i, ) in dag.iter_mut().enumerate().skip(1).take(text.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:485:14 [INFO] [stderr] | [INFO] [stderr] 485 | for i in 1..text.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=text.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:486:12 [INFO] [stderr] | [INFO] [stderr] 486 | if dag[i].len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `dag[i].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `text`. [INFO] [stderr] --> src/lib.rs:526:18 [INFO] [stderr] | [INFO] [stderr] 526 | for i in r.s..r.e { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 526 | for in text.iter().take(r.e).skip(r.s) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wordcut-engine`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wordcut-engine`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4c3a715891cf44c6f13a1e49f11cc9ddec4e8e4ef76c4f0359d1b0eb171bbfde"` [INFO] running `"docker" "rm" "-f" "4c3a715891cf44c6f13a1e49f11cc9ddec4e8e4ef76c4f0359d1b0eb171bbfde"` [INFO] [stdout] 4c3a715891cf44c6f13a1e49f11cc9ddec4e8e4ef76c4f0359d1b0eb171bbfde