[INFO] crate wm-daemons 0.1.1 is already in cache
[INFO] extracting crate wm-daemons 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/wm-daemons/0.1.1
[INFO] extracting crate wm-daemons 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wm-daemons/0.1.1
[INFO] validating manifest of wm-daemons-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wm-daemons-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wm-daemons-0.1.1
[INFO] finished frobbing wm-daemons-0.1.1
[INFO] frobbed toml for wm-daemons-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/wm-daemons/0.1.1/Cargo.toml
[INFO] started frobbing wm-daemons-0.1.1
[INFO] finished frobbing wm-daemons-0.1.1
[INFO] frobbed toml for wm-daemons-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wm-daemons/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wm-daemons-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wm-daemons/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 278173b3a1635f43aa79aa99c613a3ef52d3b758fcc399aa57564cd1cb76a861
[INFO] running `"docker" "start" "-a" "278173b3a1635f43aa79aa99c613a3ef52d3b758fcc399aa57564cd1cb76a861"`
[INFO] [stderr]     Checking nom v1.0.1
[INFO] [stderr]     Checking ansi_term v0.6.3
[INFO] [stderr]     Checking xdg-basedir v0.2.2
[INFO] [stderr]     Checking clap v1.2.5
[INFO] [stderr]     Checking config v0.1.3
[INFO] [stderr]     Checking wm-daemons v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/exec.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::env::home_dir;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/exec.rs:15:29
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if let Some(home) = home_dir() {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]  --> src/exec.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::env::home_dir;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/exec.rs:15:29
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if let Some(home) = home_dir() {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/exec.rs:13:22
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn expand_home(path: &String) -> String {
[INFO] [stderr]    |                      ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn expand_home(path: &str) -> String {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 20 |     path.to_string()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/exec.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn make_command_vec(vec: &Vec<Value>) -> Result<CommandLine, String> {
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: change this to: `&[Value]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:25:20
[INFO] [stderr]    |
[INFO] [stderr] 25 |         return Err(format!("empty execution vector"));
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"empty execution vector".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:34:37
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     _ => return Err(format!("non-string program value")),
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non-string program value".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |             _ => return Err(format!("non-string program value")),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non-string program value".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/exec.rs:48:29
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn make_command_str(string: &String) -> Result<CommandLine, String> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |         Err(format!("empty execution string"))
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"empty execution string".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/exec.rs:100:18
[INFO] [stderr]     |
[INFO] [stderr] 100 |         _ => Err(format!("failed to execute process")),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to execute process".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/exec.rs:13:22
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn expand_home(path: &String) -> String {
[INFO] [stderr]    |                      ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn expand_home(path: &str) -> String {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 20 |     path.to_string()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/exec.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn make_command_vec(vec: &Vec<Value>) -> Result<CommandLine, String> {
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: change this to: `&[Value]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:25:20
[INFO] [stderr]    |
[INFO] [stderr] 25 |         return Err(format!("empty execution vector"));
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"empty execution vector".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:34:37
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     _ => return Err(format!("non-string program value")),
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non-string program value".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |             _ => return Err(format!("non-string program value")),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non-string program value".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/exec.rs:48:29
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn make_command_str(string: &String) -> Result<CommandLine, String> {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/exec.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |         Err(format!("empty execution string"))
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"empty execution string".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/exec.rs:100:18
[INFO] [stderr]     |
[INFO] [stderr] 100 |         _ => Err(format!("failed to execute process")),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to execute process".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.60s
[INFO] running `"docker" "inspect" "278173b3a1635f43aa79aa99c613a3ef52d3b758fcc399aa57564cd1cb76a861"`
[INFO] running `"docker" "rm" "-f" "278173b3a1635f43aa79aa99c613a3ef52d3b758fcc399aa57564cd1cb76a861"`
[INFO] [stdout] 278173b3a1635f43aa79aa99c613a3ef52d3b758fcc399aa57564cd1cb76a861