[INFO] crate which-rs 0.1.1 is already in cache [INFO] extracting crate which-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/which-rs/0.1.1 [INFO] extracting crate which-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/which-rs/0.1.1 [INFO] validating manifest of which-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of which-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing which-rs-0.1.1 [INFO] finished frobbing which-rs-0.1.1 [INFO] frobbed toml for which-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/which-rs/0.1.1/Cargo.toml [INFO] started frobbing which-rs-0.1.1 [INFO] finished frobbing which-rs-0.1.1 [INFO] frobbed toml for which-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/which-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting which-rs-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/which-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8352f28ea40e6a6b10d77f18a60b017f16f0a395c716cc7950cfb13262d1d731 [INFO] running `"docker" "start" "-a" "8352f28ea40e6a6b10d77f18a60b017f16f0a395c716cc7950cfb13262d1d731"` [INFO] [stderr] Checking which-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:8:49 [INFO] [stderr] | [INFO] [stderr] 8 | mut result: Option<&'b mut HashMap<&'a str, Vec>>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 5 | pub fn which<'a, 'b, S: ::std::hash::BuildHasher>(files: &'a [&'a str], [INFO] [stderr] 6 | paths: &'a [&'a Path], [INFO] [stderr] 7 | match_all: bool, [INFO] [stderr] 8 | mut result: Option<&'b mut HashMap<&'a str, Vec, S>>) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match result { [INFO] [stderr] 32 | | Some(ref mut r) => { [INFO] [stderr] 33 | | r.entry(f).or_insert(Vec::new()); [INFO] [stderr] 34 | | if let Some(targets) = r.get_mut(f) { [INFO] [stderr] ... | [INFO] [stderr] 38 | | None => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(ref mut r) = result { [INFO] [stderr] 32 | r.entry(f).or_insert(Vec::new()); [INFO] [stderr] 33 | if let Some(targets) = r.get_mut(f) { [INFO] [stderr] 34 | targets.push(target); [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | r.entry(f).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:8:49 [INFO] [stderr] | [INFO] [stderr] 8 | mut result: Option<&'b mut HashMap<&'a str, Vec>>) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 5 | pub fn which<'a, 'b, S: ::std::hash::BuildHasher>(files: &'a [&'a str], [INFO] [stderr] 6 | paths: &'a [&'a Path], [INFO] [stderr] 7 | match_all: bool, [INFO] [stderr] 8 | mut result: Option<&'b mut HashMap<&'a str, Vec, S>>) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match result { [INFO] [stderr] 32 | | Some(ref mut r) => { [INFO] [stderr] 33 | | r.entry(f).or_insert(Vec::new()); [INFO] [stderr] 34 | | if let Some(targets) = r.get_mut(f) { [INFO] [stderr] ... | [INFO] [stderr] 38 | | None => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(ref mut r) = result { [INFO] [stderr] 32 | r.entry(f).or_insert(Vec::new()); [INFO] [stderr] 33 | if let Some(targets) = r.get_mut(f) { [INFO] [stderr] 34 | targets.push(target); [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | r.entry(f).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "8352f28ea40e6a6b10d77f18a60b017f16f0a395c716cc7950cfb13262d1d731"` [INFO] running `"docker" "rm" "-f" "8352f28ea40e6a6b10d77f18a60b017f16f0a395c716cc7950cfb13262d1d731"` [INFO] [stdout] 8352f28ea40e6a6b10d77f18a60b017f16f0a395c716cc7950cfb13262d1d731