[INFO] crate wayland-scanner 0.21.7 is already in cache [INFO] extracting crate wayland-scanner 0.21.7 into work/ex/clippy-test-run/sources/stable/reg/wayland-scanner/0.21.7 [INFO] extracting crate wayland-scanner 0.21.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-scanner/0.21.7 [INFO] validating manifest of wayland-scanner-0.21.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wayland-scanner-0.21.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wayland-scanner-0.21.7 [INFO] finished frobbing wayland-scanner-0.21.7 [INFO] frobbed toml for wayland-scanner-0.21.7 written to work/ex/clippy-test-run/sources/stable/reg/wayland-scanner/0.21.7/Cargo.toml [INFO] started frobbing wayland-scanner-0.21.7 [INFO] finished frobbing wayland-scanner-0.21.7 [INFO] frobbed toml for wayland-scanner-0.21.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-scanner/0.21.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wayland-scanner-0.21.7 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wayland-scanner/0.21.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2ac831eb2d136654062f2832f4964a64c52d5d19f0045b936db63d5f0805052 [INFO] running `"docker" "start" "-a" "d2ac831eb2d136654062f2832f4964a64c52d5d19f0045b936db63d5f0805052"` [INFO] [stderr] Checking xml-rs v0.8.0 [INFO] [stderr] Checking wayland-scanner v0.21.7 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(out, "")` [INFO] [stderr] --> src/common_gen.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | writeln!(out, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(out)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(out, "")` [INFO] [stderr] --> src/common_gen.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | writeln!(out, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(out)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/c_code_gen.rs:121:1 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn messagegroup_c_addon( [INFO] [stderr] 122 | | name: &str, [INFO] [stderr] 123 | | side: Side, [INFO] [stderr] 124 | | receiver: bool, [INFO] [stderr] ... | [INFO] [stderr] 391 | | Ok(()) [INFO] [stderr] 392 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_code_gen.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_code_gen.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `j` is used as a loop counter. Consider using `for (j, item) in &msg.args.enumerate()` or similar iterators [INFO] [stderr] --> src/c_code_gen.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | for a in &msg.args { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_code_gen.rs:290:16 [INFO] [stderr] | [INFO] [stderr] 290 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/c_interface_gen.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub(crate) fn generate_interfaces(protocol: Protocol, out: &mut O) -> IOResult<()> { [INFO] [stderr] 7 | | writeln!( [INFO] [stderr] 8 | | out, [INFO] [stderr] 9 | | "//\n// This file was auto-generated, do not edit directly\n//\n" [INFO] [stderr] ... | [INFO] [stderr] 154 | | Ok(()) [INFO] [stderr] 155 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/c_code_gen.rs:121:1 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn messagegroup_c_addon( [INFO] [stderr] 122 | | name: &str, [INFO] [stderr] 123 | | side: Side, [INFO] [stderr] 124 | | receiver: bool, [INFO] [stderr] ... | [INFO] [stderr] 391 | | Ok(()) [INFO] [stderr] 392 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_interface_gen.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | if interface.requests.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.requests.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_interface_gen.rs:143:12 [INFO] [stderr] | [INFO] [stderr] 143 | if interface.events.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/common_gen.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / pub(crate) fn write_messagegroup IOResult<()>>( [INFO] [stderr] 53 | | name: &str, [INFO] [stderr] 54 | | side: Side, [INFO] [stderr] 55 | | receiver: bool, [INFO] [stderr] ... | [INFO] [stderr] 482 | | Ok(()) [INFO] [stderr] 483 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_code_gen.rs:140:16 [INFO] [stderr] | [INFO] [stderr] 140 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_code_gen.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `j` is used as a loop counter. Consider using `for (j, item) in &msg.args.enumerate()` or similar iterators [INFO] [stderr] --> src/c_code_gen.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | for a in &msg.args { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_code_gen.rs:290:16 [INFO] [stderr] | [INFO] [stderr] 290 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/c_interface_gen.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub(crate) fn generate_interfaces(protocol: Protocol, out: &mut O) -> IOResult<()> { [INFO] [stderr] 7 | | writeln!( [INFO] [stderr] 8 | | out, [INFO] [stderr] 9 | | "//\n// This file was auto-generated, do not edit directly\n//\n" [INFO] [stderr] ... | [INFO] [stderr] 154 | | Ok(()) [INFO] [stderr] 155 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_interface_gen.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | if interface.requests.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.requests.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/c_interface_gen.rs:143:12 [INFO] [stderr] | [INFO] [stderr] 143 | if interface.events.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!interface.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/common_gen.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / pub(crate) fn write_messagegroup IOResult<()>>( [INFO] [stderr] 53 | | name: &str, [INFO] [stderr] 54 | | side: Side, [INFO] [stderr] 55 | | receiver: bool, [INFO] [stderr] ... | [INFO] [stderr] 482 | | Ok(()) [INFO] [stderr] 483 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | if m.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!m.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:188:16 [INFO] [stderr] | [INFO] [stderr] 188 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:265:16 [INFO] [stderr] | [INFO] [stderr] 265 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:274:16 [INFO] [stderr] | [INFO] [stderr] 274 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:393:16 [INFO] [stderr] | [INFO] [stderr] 393 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | if m.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!m.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:188:16 [INFO] [stderr] | [INFO] [stderr] 188 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:265:16 [INFO] [stderr] | [INFO] [stderr] 265 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:274:16 [INFO] [stderr] | [INFO] [stderr] 274 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_gen.rs:641:9 [INFO] [stderr] | [INFO] [stderr] 641 | / match arg.typ { [INFO] [stderr] 642 | | Type::NewId => if newid.is_some() { [INFO] [stderr] 643 | | panic!("Request {}.{} returns more than one new_id", iname, msg.name); [INFO] [stderr] 644 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 647 | | _ => (), [INFO] [stderr] 648 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 641 | if let Type::NewId = arg.typ { if newid.is_some() { [INFO] [stderr] 642 | panic!("Request {}.{} returns more than one new_id", iname, msg.name); [INFO] [stderr] 643 | } else { [INFO] [stderr] 644 | newid = Some(arg); [INFO] [stderr] 645 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common_gen.rs:694:26 [INFO] [stderr] | [INFO] [stderr] 694 | .unwrap_or(format!("&Proxy")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("&Proxy"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common_gen.rs:694:36 [INFO] [stderr] | [INFO] [stderr] 694 | .unwrap_or(format!("&Proxy")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"&Proxy".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:393:16 [INFO] [stderr] | [INFO] [stderr] 393 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:772:12 [INFO] [stderr] | [INFO] [stderr] 772 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match &attr.name.local_name[..] { [INFO] [stderr] 128 | | "summary" => summary = attr.value.split_whitespace().collect::>().join(" "), [INFO] [stderr] 129 | | _ => {} [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ help: try this: `if let "summary" = &attr.name.local_name[..] { summary = attr.value.split_whitespace().collect::>().join(" ") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common_gen.rs:641:9 [INFO] [stderr] | [INFO] [stderr] 641 | / match arg.typ { [INFO] [stderr] 642 | | Type::NewId => if newid.is_some() { [INFO] [stderr] 643 | | panic!("Request {}.{} returns more than one new_id", iname, msg.name); [INFO] [stderr] 644 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 647 | | _ => (), [INFO] [stderr] 648 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 641 | if let Type::NewId = arg.typ { if newid.is_some() { [INFO] [stderr] 642 | panic!("Request {}.{} returns more than one new_id", iname, msg.name); [INFO] [stderr] 643 | } else { [INFO] [stderr] 644 | newid = Some(arg); [INFO] [stderr] 645 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common_gen.rs:694:26 [INFO] [stderr] | [INFO] [stderr] 694 | .unwrap_or(format!("&Proxy")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("&Proxy"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common_gen.rs:694:36 [INFO] [stderr] | [INFO] [stderr] 694 | .unwrap_or(format!("&Proxy")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"&Proxy".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/protocol.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn nullable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common_gen.rs:772:12 [INFO] [stderr] | [INFO] [stderr] 772 | if msg.args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.args.is_empty()` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/protocol.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn rust_type(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/protocol.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn common_type(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/side.rs:16:31 [INFO] [stderr] | [INFO] [stderr] 16 | pub(crate) fn object_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | let pfile = File::open(prot.as_ref()).expect(&format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 115 | | "Unable to open protocol file `{}`.", [INFO] [stderr] 116 | | prot.as_ref().display() [INFO] [stderr] 117 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Unable to open protocol file `{}`.", prot.as_ref().display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match &attr.name.local_name[..] { [INFO] [stderr] 128 | | "summary" => summary = attr.value.split_whitespace().collect::>().join(" "), [INFO] [stderr] 129 | | _ => {} [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ help: try this: `if let "summary" = &attr.name.local_name[..] { summary = attr.value.split_whitespace().collect::>().join(" ") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/protocol.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn nullable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/protocol.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn rust_type(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/protocol.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn common_type(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/side.rs:16:31 [INFO] [stderr] | [INFO] [stderr] 16 | pub(crate) fn object_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | let pfile = File::open(prot.as_ref()).expect(&format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 115 | | "Unable to open protocol file `{}`.", [INFO] [stderr] 116 | | prot.as_ref().display() [INFO] [stderr] 117 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Unable to open protocol file `{}`.", prot.as_ref().display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.46s [INFO] running `"docker" "inspect" "d2ac831eb2d136654062f2832f4964a64c52d5d19f0045b936db63d5f0805052"` [INFO] running `"docker" "rm" "-f" "d2ac831eb2d136654062f2832f4964a64c52d5d19f0045b936db63d5f0805052"` [INFO] [stdout] d2ac831eb2d136654062f2832f4964a64c52d5d19f0045b936db63d5f0805052