[INFO] crate waveform 0.3.2 is already in cache [INFO] extracting crate waveform 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/waveform/0.3.2 [INFO] extracting crate waveform 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/waveform/0.3.2 [INFO] validating manifest of waveform-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of waveform-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing waveform-0.3.2 [INFO] finished frobbing waveform-0.3.2 [INFO] frobbed toml for waveform-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/waveform/0.3.2/Cargo.toml [INFO] started frobbing waveform-0.3.2 [INFO] finished frobbing waveform-0.3.2 [INFO] frobbed toml for waveform-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/waveform/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting waveform-0.3.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/waveform/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aec51facb16e98d01e33f9fc96c9357303c399c158b337ab178c6f4d038f574a [INFO] running `"docker" "start" "-a" "aec51facb16e98d01e33f9fc96c9357303c399c158b337ab178c6f4d038f574a"` [INFO] [stderr] Checking rlibc v1.0.0 [INFO] [stderr] Checking waveform v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | let minmax = MinMaxPairSequence { data: data }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | bin_size: bin_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bin_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | minmax: minmax, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minmax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/direct.rs:49:43 [INFO] [stderr] | [INFO] [stderr] 49 | minmax.data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/direct.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | minmax.data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | let minmax = MinMaxPairSequence { data: data }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | bin_size: bin_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bin_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binned.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | minmax: minmax, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minmax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/direct.rs:49:43 [INFO] [stderr] | [INFO] [stderr] 49 | minmax.data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/direct.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | minmax.data.push(MinMaxPair { min: min, max: max }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c1_is_scalar` [INFO] [stderr] --> src/misc.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut c1_is_scalar = false; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_c1_is_scalar` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c2_is_scalar` [INFO] [stderr] --> src/misc.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let mut c2_is_scalar = false; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_c2_is_scalar` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/misc.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut c1_is_scalar = false; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/misc.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let mut c2_is_scalar = false; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c1_is_scalar` [INFO] [stderr] --> src/misc.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut c1_is_scalar = false; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_c1_is_scalar` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c2_is_scalar` [INFO] [stderr] --> src/misc.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let mut c2_is_scalar = false; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_c2_is_scalar` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match Self::check_color_consistency(background, foreground) { [INFO] [stderr] 68 | | Err(e) => return Err(e), [INFO] [stderr] 69 | | _ => (), [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = Self::check_color_consistency(background, foreground) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/misc.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let mut c1_is_scalar = false; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/misc.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let mut c2_is_scalar = false; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match Self::check_color_consistency(background, foreground) { [INFO] [stderr] 94 | | Err(e) => return Err(e), [INFO] [stderr] 95 | | _ => (), [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = Self::check_color_consistency(background, foreground) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/misc.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / match self { [INFO] [stderr] 126 | | &TimeRange::Seconds(b, e) => ( [INFO] [stderr] 127 | | (b * sample_rate) as usize, [INFO] [stderr] 128 | | (e * sample_rate) as usize, [INFO] [stderr] 129 | | ), [INFO] [stderr] 130 | | &TimeRange::Samples(b, e) => (b, e), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | match *self { [INFO] [stderr] 126 | TimeRange::Seconds(b, e) => ( [INFO] [stderr] 127 | (b * sample_rate) as usize, [INFO] [stderr] 128 | (e * sample_rate) as usize, [INFO] [stderr] 129 | ), [INFO] [stderr] 130 | TimeRange::Samples(b, e) => (b, e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * bin_size` [INFO] [stderr] --> src/binned.rs:49:40 [INFO] [stderr] | [INFO] [stderr] 49 | let mut min = samples.data[x * bin_size + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * bin_size` [INFO] [stderr] --> src/binned.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | let mut max = samples.data[x * bin_size + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/binned.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | let ref d = self.minmax.data[start_bin_idx]; [INFO] [stderr] | ----^^^^^----------------------------------- help: try: `let d = &self.minmax.data[start_bin_idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * samples_per_pixel` [INFO] [stderr] --> src/direct.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let mut min = samples[x * samples_per_pixel + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * samples_per_pixel` [INFO] [stderr] --> src/direct.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | let mut max = samples[x * samples_per_pixel + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | img[1 * (y * w + x) + 0] = ba; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(y * w + x)` [INFO] [stderr] --> src/direct.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | img[1 * (y * w + x) + 0] = ba; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | img[1 * (y * w + x) + 0] = fa; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(y * w + x)` [INFO] [stderr] --> src/direct.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | img[1 * (y * w + x) + 0] = fa; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | img[4 * (y * w + x) + 0] = br; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | img[4 * (y * w + x) + 0] = fr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/multi.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | let mut bin_sizes: Vec = self.binned.keys().map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.binned.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/multi.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if bin_sizes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bin_sizes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match Self::check_color_consistency(background, foreground) { [INFO] [stderr] 68 | | Err(e) => return Err(e), [INFO] [stderr] 69 | | _ => (), [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = Self::check_color_consistency(background, foreground) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/misc.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match Self::check_color_consistency(background, foreground) { [INFO] [stderr] 94 | | Err(e) => return Err(e), [INFO] [stderr] 95 | | _ => (), [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = Self::check_color_consistency(background, foreground) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/misc.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / match self { [INFO] [stderr] 126 | | &TimeRange::Seconds(b, e) => ( [INFO] [stderr] 127 | | (b * sample_rate) as usize, [INFO] [stderr] 128 | | (e * sample_rate) as usize, [INFO] [stderr] 129 | | ), [INFO] [stderr] 130 | | &TimeRange::Samples(b, e) => (b, e), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | match *self { [INFO] [stderr] 126 | TimeRange::Seconds(b, e) => ( [INFO] [stderr] 127 | (b * sample_rate) as usize, [INFO] [stderr] 128 | (e * sample_rate) as usize, [INFO] [stderr] 129 | ), [INFO] [stderr] 130 | TimeRange::Samples(b, e) => (b, e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * bin_size` [INFO] [stderr] --> src/binned.rs:49:40 [INFO] [stderr] | [INFO] [stderr] 49 | let mut min = samples.data[x * bin_size + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * bin_size` [INFO] [stderr] --> src/binned.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | let mut max = samples.data[x * bin_size + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/binned.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | let ref d = self.minmax.data[start_bin_idx]; [INFO] [stderr] | ----^^^^^----------------------------------- help: try: `let d = &self.minmax.data[start_bin_idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/binned.rs:375:27 [INFO] [stderr] | [INFO] [stderr] 375 | samples.push(((t as f64) * 0.01f64 * 2f64 * 3.1415f64).sin()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/binned.rs:375:57 [INFO] [stderr] | [INFO] [stderr] 375 | samples.push(((t as f64) * 0.01f64 * 2f64 * 3.1415f64).sin()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/binned.rs:407:23 [INFO] [stderr] | [INFO] [stderr] 407 | data: &vec![0f64; 10], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0f64; 10]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * samples_per_pixel` [INFO] [stderr] --> src/direct.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let mut min = samples[x * samples_per_pixel + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x * samples_per_pixel` [INFO] [stderr] --> src/direct.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | let mut max = samples[x * samples_per_pixel + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | img[1 * (y * w + x) + 0] = ba; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(y * w + x)` [INFO] [stderr] --> src/direct.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | img[1 * (y * w + x) + 0] = ba; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | img[1 * (y * w + x) + 0] = fa; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(y * w + x)` [INFO] [stderr] --> src/direct.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | img[1 * (y * w + x) + 0] = fa; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | img[4 * (y * w + x) + 0] = br; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4 * (y * w + x)` [INFO] [stderr] --> src/direct.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | img[4 * (y * w + x) + 0] = fr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/multi.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | let mut bin_sizes: Vec = self.binned.keys().map(|x| *x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.binned.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/multi.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if bin_sizes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bin_sizes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/multi.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | assert_eq!(mwr.binned.get(bs).unwrap().get_bin_size(), *bs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mwr.binned[bs]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/multi.rs:160:24 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(mwr.binned.get(bs).unwrap().get_sample_rate(), sample_rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mwr.binned[bs]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/multi.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(mwr.binned.get(bs).unwrap().get_sample_rate(), sample_rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/multi.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(mwr.binned.get(bs).unwrap().get_sample_rate(), sample_rate); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/multi.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | data: &vec![0f64; 100], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0f64; 100]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/multi.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | &vec![10usize], config [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `waveform`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/render.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `waveform`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `vec` [INFO] [stderr] --> examples/binned.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | let vec: Vec = [INFO] [stderr] | ^^^ help: consider using `_vec` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/binned.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> examples/binned.rs:51:43 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/binned.rs:51:63 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> examples/binned.rs:51:94 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `waveform`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `vec` [INFO] [stderr] --> examples/multi.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut vec: Vec = [INFO] [stderr] | ^^^ help: consider using `_vec` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/multi.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut vec: Vec = [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/multi.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> examples/multi.rs:51:43 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/multi.rs:51:63 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> examples/multi.rs:51:94 [INFO] [stderr] | [INFO] [stderr] 51 | ((t as f64) / 100f64 * 2f64 * 3.1415f64).sin() * ((t as f64) / 10000f64 * 2f64 * 3.1415f64).sin(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `waveform`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "aec51facb16e98d01e33f9fc96c9357303c399c158b337ab178c6f4d038f574a"` [INFO] running `"docker" "rm" "-f" "aec51facb16e98d01e33f9fc96c9357303c399c158b337ab178c6f4d038f574a"` [INFO] [stdout] aec51facb16e98d01e33f9fc96c9357303c399c158b337ab178c6f4d038f574a