[INFO] crate wam 0.1.0 is already in cache [INFO] extracting crate wam 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/wam/0.1.0 [INFO] extracting crate wam 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wam/0.1.0 [INFO] validating manifest of wam-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wam-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wam-0.1.0 [INFO] finished frobbing wam-0.1.0 [INFO] frobbed toml for wam-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/wam/0.1.0/Cargo.toml [INFO] started frobbing wam-0.1.0 [INFO] finished frobbing wam-0.1.0 [INFO] frobbed toml for wam-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wam/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wam-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/wam/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5889d607a53650c0541374ed8837bb40558f32963d2106364975f14bb5e1c8f1 [INFO] running `"docker" "start" "-a" "5889d607a53650c0541374ed8837bb40558f32963d2106364975f14bb5e1c8f1"` [INFO] [stderr] Checking wam v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | &Cell::Variable(bind) => write!(f, "REF {:?}", bind), [INFO] [stderr] 14 | | &Cell::Structure(ptr) => write!(f, "STR {:?}", ptr), [INFO] [stderr] 15 | | &Cell::Functor(ref name, arity) => write!(f, "{}/{}", name, arity), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *self { [INFO] [stderr] 13 | Cell::Variable(bind) => write!(f, "REF {:?}", bind), [INFO] [stderr] 14 | Cell::Structure(ptr) => write!(f, "STR {:?}", ptr), [INFO] [stderr] 15 | Cell::Functor(ref name, arity) => write!(f, "{}/{}", name, arity), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Instance` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Instance { [INFO] [stderr] 80 | | Instance { [INFO] [stderr] 81 | | heap: Vec::new(), [INFO] [stderr] 82 | | registers: vec![None; REGISTER_COUNT], [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | impl Default for Instance { [INFO] [stderr] 78 | fn default() -> Self { [INFO] [stderr] 79 | Self::new() [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:144:52 [INFO] [stderr] | [INFO] [stderr] 144 | self.heap.push(Cell::Functor(name.clone(), arity.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `arity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:237:24 [INFO] [stderr] | [INFO] [stderr] 237 | self.pc = *self.labels.get(&label).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.labels[&label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:295:42 [INFO] [stderr] | [INFO] [stderr] 295 | for i in 1..(n1+1) { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=n1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | &Cell::Variable(bind) => write!(f, "REF {:?}", bind), [INFO] [stderr] 14 | | &Cell::Structure(ptr) => write!(f, "STR {:?}", ptr), [INFO] [stderr] 15 | | &Cell::Functor(ref name, arity) => write!(f, "{}/{}", name, arity), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *self { [INFO] [stderr] 13 | Cell::Variable(bind) => write!(f, "REF {:?}", bind), [INFO] [stderr] 14 | Cell::Structure(ptr) => write!(f, "STR {:?}", ptr), [INFO] [stderr] 15 | Cell::Functor(ref name, arity) => write!(f, "{}/{}", name, arity), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Instance` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Instance { [INFO] [stderr] 80 | | Instance { [INFO] [stderr] 81 | | heap: Vec::new(), [INFO] [stderr] 82 | | registers: vec![None; REGISTER_COUNT], [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | impl Default for Instance { [INFO] [stderr] 78 | fn default() -> Self { [INFO] [stderr] 79 | Self::new() [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:144:52 [INFO] [stderr] | [INFO] [stderr] 144 | self.heap.push(Cell::Functor(name.clone(), arity.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `arity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:237:24 [INFO] [stderr] | [INFO] [stderr] 237 | self.pc = *self.labels.get(&label).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.labels[&label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:295:42 [INFO] [stderr] | [INFO] [stderr] 295 | for i in 1..(n1+1) { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=n1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "5889d607a53650c0541374ed8837bb40558f32963d2106364975f14bb5e1c8f1"` [INFO] running `"docker" "rm" "-f" "5889d607a53650c0541374ed8837bb40558f32963d2106364975f14bb5e1c8f1"` [INFO] [stdout] 5889d607a53650c0541374ed8837bb40558f32963d2106364975f14bb5e1c8f1