[INFO] crate vigenere 0.0.3 is already in cache
[INFO] extracting crate vigenere 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/vigenere/0.0.3
[INFO] extracting crate vigenere 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vigenere/0.0.3
[INFO] validating manifest of vigenere-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vigenere-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vigenere-0.0.3
[INFO] finished frobbing vigenere-0.0.3
[INFO] frobbed toml for vigenere-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/vigenere/0.0.3/Cargo.toml
[INFO] started frobbing vigenere-0.0.3
[INFO] finished frobbing vigenere-0.0.3
[INFO] frobbed toml for vigenere-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vigenere/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vigenere-0.0.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vigenere/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0b0656fb21f64523d0e8abe55520f3826fc9abb78e1e5ffaf7fcbb4ae964448d
[INFO] running `"docker" "start" "-a" "0b0656fb21f64523d0e8abe55520f3826fc9abb78e1e5ffaf7fcbb4ae964448d"`
[INFO] [stderr]     Checking vigenere v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `libvigenere::Vigenere`
[INFO] [stderr]   --> src/libvigenere.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 | /     pub fn new() -> Vigenere {
[INFO] [stderr] 25 | |         Vigenere {
[INFO] [stderr] 26 | |             mode: Some(Mode::Encrypt),
[INFO] [stderr] 27 | |             key: None,
[INFO] [stderr] 28 | |             read: 0
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use as_ref() instead
[INFO] [stderr]   --> src/libvigenere.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         match self.key {
[INFO] [stderr] 38 | |             Some(ref key) => Some(key),
[INFO] [stderr] 39 | |             None => None
[INFO] [stderr] 40 | |         }
[INFO] [stderr]    | |_________^ help: try this: `self.key.as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_as_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/libvigenere.rs:51:24
[INFO] [stderr]    |
[INFO] [stderr] 51 |           let sign:i32 = match self.mode.as_ref().unwrap() {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 52 | |             &Mode::Decrypt => -1,
[INFO] [stderr] 53 | |             &Mode::Encrypt => 1
[INFO] [stderr] 54 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let sign:i32 = match *self.mode.as_ref().unwrap() {
[INFO] [stderr] 52 |             Mode::Decrypt => -1,
[INFO] [stderr] 53 |             Mode::Encrypt => 1
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`.
[INFO] [stderr]   --> src/libvigenere.rs:60:34
[INFO] [stderr]    |
[INFO] [stderr] 60 |                         for i in 0..(size) {
[INFO] [stderr]    |                                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 60 |                         for <item> in buffer.iter().take((size)) {
[INFO] [stderr]    |                             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/libvigenere.rs:61:50
[INFO] [stderr]    |
[INFO] [stderr] 61 |                             let out_char: u8 = ((buffer[i] as i32 + sign
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/libvigenere.rs:62:35
[INFO] [stderr]    |
[INFO] [stderr] 62 |                                 * key[pos] as i32) % (255)) as u8;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^ help: try: `i32::from(key[pos])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/libvigenere.rs:63:29
[INFO] [stderr]    |
[INFO] [stderr] 63 |                             handle_out.write(&[out_char]);
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `libvigenere::Vigenere`
[INFO] [stderr]   --> src/libvigenere.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 | /     pub fn new() -> Vigenere {
[INFO] [stderr] 25 | |         Vigenere {
[INFO] [stderr] 26 | |             mode: Some(Mode::Encrypt),
[INFO] [stderr] 27 | |             key: None,
[INFO] [stderr] 28 | |             read: 0
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/libvigenere.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |     for ref argument in args {
[INFO] [stderr]    |         ^^^^^^^^^^^^    ---- help: try: `let argument = &args;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use as_ref() instead
[INFO] [stderr]   --> src/libvigenere.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         match self.key {
[INFO] [stderr] 38 | |             Some(ref key) => Some(key),
[INFO] [stderr] 39 | |             None => None
[INFO] [stderr] 40 | |         }
[INFO] [stderr]    | |_________^ help: try this: `self.key.as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_as_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/libvigenere.rs:102:63
[INFO] [stderr]     |
[INFO] [stderr] 102 |       } else if vigenere.get_key().as_ref().unwrap().len() == 0 {
[INFO] [stderr]     |  _______________________________________________________________^
[INFO] [stderr] 103 | |         Err("No key specified.")
[INFO] [stderr] 104 | |     } else {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/libvigenere.rs:100:35
[INFO] [stderr]     |
[INFO] [stderr] 100 |       if vigenere.get_key() == None {
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 101 | |         Err("No key specified.")
[INFO] [stderr] 102 | |     } else if vigenere.get_key().as_ref().unwrap().len() == 0 {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/libvigenere.rs:102:15
[INFO] [stderr]     |
[INFO] [stderr] 102 |     } else if vigenere.get_key().as_ref().unwrap().len() == 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vigenere.get_key().as_ref().unwrap().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/libvigenere.rs:51:24
[INFO] [stderr]    |
[INFO] [stderr] 51 |           let sign:i32 = match self.mode.as_ref().unwrap() {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 52 | |             &Mode::Decrypt => -1,
[INFO] [stderr] 53 | |             &Mode::Encrypt => 1
[INFO] [stderr] 54 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let sign:i32 = match *self.mode.as_ref().unwrap() {
[INFO] [stderr] 52 |             Mode::Decrypt => -1,
[INFO] [stderr] 53 |             Mode::Encrypt => 1
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`.
[INFO] [stderr]   --> src/libvigenere.rs:60:34
[INFO] [stderr]    |
[INFO] [stderr] 60 |                         for i in 0..(size) {
[INFO] [stderr]    |                                  ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 60 |                         for <item> in buffer.iter().take((size)) {
[INFO] [stderr]    |                             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/libvigenere.rs:61:50
[INFO] [stderr]    |
[INFO] [stderr] 61 |                             let out_char: u8 = ((buffer[i] as i32 + sign
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/libvigenere.rs:62:35
[INFO] [stderr]    |
[INFO] [stderr] 62 |                                 * key[pos] as i32) % (255)) as u8;
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^ help: try: `i32::from(key[pos])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/libvigenere.rs:63:29
[INFO] [stderr]    |
[INFO] [stderr] 63 |                             handle_out.write(&[out_char]);
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `vigenere`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/libvigenere.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |     for ref argument in args {
[INFO] [stderr]    |         ^^^^^^^^^^^^    ---- help: try: `let argument = &args;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/libvigenere.rs:102:63
[INFO] [stderr]     |
[INFO] [stderr] 102 |       } else if vigenere.get_key().as_ref().unwrap().len() == 0 {
[INFO] [stderr]     |  _______________________________________________________________^
[INFO] [stderr] 103 | |         Err("No key specified.")
[INFO] [stderr] 104 | |     } else {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/libvigenere.rs:100:35
[INFO] [stderr]     |
[INFO] [stderr] 100 |       if vigenere.get_key() == None {
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 101 | |         Err("No key specified.")
[INFO] [stderr] 102 | |     } else if vigenere.get_key().as_ref().unwrap().len() == 0 {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/libvigenere.rs:102:15
[INFO] [stderr]     |
[INFO] [stderr] 102 |     } else if vigenere.get_key().as_ref().unwrap().len() == 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vigenere.get_key().as_ref().unwrap().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `vigenere`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "0b0656fb21f64523d0e8abe55520f3826fc9abb78e1e5ffaf7fcbb4ae964448d"`
[INFO] running `"docker" "rm" "-f" "0b0656fb21f64523d0e8abe55520f3826fc9abb78e1e5ffaf7fcbb4ae964448d"`
[INFO] [stdout] 0b0656fb21f64523d0e8abe55520f3826fc9abb78e1e5ffaf7fcbb4ae964448d