[INFO] crate vex 1.0.0 is already in cache [INFO] extracting crate vex 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/vex/1.0.0 [INFO] extracting crate vex 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vex/1.0.0 [INFO] validating manifest of vex-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vex-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vex-1.0.0 [INFO] finished frobbing vex-1.0.0 [INFO] frobbed toml for vex-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/vex/1.0.0/Cargo.toml [INFO] started frobbing vex-1.0.0 [INFO] finished frobbing vex-1.0.0 [INFO] frobbed toml for vex-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vex/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vex-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vex/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6562b7d7e4f5f7958a69fa0a0bed417ff2c4c77cb384cca7e1e8c95f2bbea46 [INFO] running `"docker" "start" "-a" "c6562b7d7e4f5f7958a69fa0a0bed417ff2c4c77cb384cca7e1e8c95f2bbea46"` [INFO] [stderr] Checking vex v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matrix2::Matrix2` [INFO] [stderr] --> src/matrix2.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Matrix2 { [INFO] [stderr] 28 | | IDENTITY [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.m` manually [INFO] [stderr] --> src/matrix2.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / let temp = self.m[1]; [INFO] [stderr] 204 | | self.m[1] = self.m[2]; [INFO] [stderr] 205 | | self.m[2] = temp; [INFO] [stderr] | |________________________^ help: try: `self.m.swap(1, 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matrix2::Matrix2` [INFO] [stderr] --> src/matrix2.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Matrix2 { [INFO] [stderr] 28 | | IDENTITY [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.m` manually [INFO] [stderr] --> src/matrix2.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / let temp = self.m[1]; [INFO] [stderr] 204 | | self.m[1] = self.m[2]; [INFO] [stderr] 205 | | self.m[2] = temp; [INFO] [stderr] | |________________________^ help: try: `self.m.swap(1, 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matrix3::Matrix3` [INFO] [stderr] --> src/matrix3.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Matrix3 { [INFO] [stderr] 30 | | IDENTITY [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/matrix3.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn make( [INFO] [stderr] 44 | | m11: f32, [INFO] [stderr] 45 | | m21: f32, [INFO] [stderr] 46 | | m31: f32, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/matrix3.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | / pub fn set( [INFO] [stderr] 337 | | &mut self, [INFO] [stderr] 338 | | m11: f32, [INFO] [stderr] 339 | | m21: f32, [INFO] [stderr] ... | [INFO] [stderr] 356 | | self.set_m33(m33); [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matrix3::Matrix3` [INFO] [stderr] --> src/matrix3.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Matrix3 { [INFO] [stderr] 30 | | IDENTITY [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix3.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | / let temp = m[1]; [INFO] [stderr] 374 | | m[1] = m[3]; [INFO] [stderr] 375 | | m[3] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix3.rs:376:9 [INFO] [stderr] | [INFO] [stderr] 376 | / let temp = m[5]; [INFO] [stderr] 377 | | m[5] = m[7]; [INFO] [stderr] 378 | | m[7] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(5, 7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix3.rs:379:9 [INFO] [stderr] | [INFO] [stderr] 379 | / let temp = m[2]; [INFO] [stderr] 380 | | m[2] = m[6]; [INFO] [stderr] 381 | | m[6] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(2, 6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/matrix3.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn make( [INFO] [stderr] 44 | | m11: f32, [INFO] [stderr] 45 | | m21: f32, [INFO] [stderr] 46 | | m31: f32, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/matrix3.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | / pub fn set( [INFO] [stderr] 337 | | &mut self, [INFO] [stderr] 338 | | m11: f32, [INFO] [stderr] 339 | | m21: f32, [INFO] [stderr] ... | [INFO] [stderr] 356 | | self.set_m33(m33); [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix3.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | / let temp = m[1]; [INFO] [stderr] 374 | | m[1] = m[3]; [INFO] [stderr] 375 | | m[3] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix3.rs:376:9 [INFO] [stderr] | [INFO] [stderr] 376 | / let temp = m[5]; [INFO] [stderr] 377 | | m[5] = m[7]; [INFO] [stderr] 378 | | m[7] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(5, 7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix3.rs:379:9 [INFO] [stderr] | [INFO] [stderr] 379 | / let temp = m[2]; [INFO] [stderr] 380 | | m[2] = m[6]; [INFO] [stderr] 381 | | m[6] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(2, 6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matrix4::Matrix4` [INFO] [stderr] --> src/matrix4.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Matrix4 { [INFO] [stderr] 32 | | IDENTITY [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/matrix4.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn make( [INFO] [stderr] 46 | | m11: f32, [INFO] [stderr] 47 | | m21: f32, [INFO] [stderr] 48 | | m31: f32, [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matrix4::Matrix4` [INFO] [stderr] --> src/matrix4.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Matrix4 { [INFO] [stderr] 32 | | IDENTITY [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/matrix4.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn make( [INFO] [stderr] 46 | | m11: f32, [INFO] [stderr] 47 | | m21: f32, [INFO] [stderr] 48 | | m31: f32, [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (17/7) [INFO] [stderr] --> src/matrix4.rs:782:5 [INFO] [stderr] | [INFO] [stderr] 782 | / pub fn set( [INFO] [stderr] 783 | | &mut self, [INFO] [stderr] 784 | | m11: f32, [INFO] [stderr] 785 | | m21: f32, [INFO] [stderr] ... | [INFO] [stderr] 816 | | self.set_m44(m44); [INFO] [stderr] 817 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:833:9 [INFO] [stderr] | [INFO] [stderr] 833 | / let temp = m[1]; [INFO] [stderr] 834 | | m[1] = m[4]; [INFO] [stderr] 835 | | m[4] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(1, 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:836:9 [INFO] [stderr] | [INFO] [stderr] 836 | / let temp = m[2]; [INFO] [stderr] 837 | | m[2] = m[8]; [INFO] [stderr] 838 | | m[8] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(2, 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:839:9 [INFO] [stderr] | [INFO] [stderr] 839 | / let temp = m[6]; [INFO] [stderr] 840 | | m[6] = m[9]; [INFO] [stderr] 841 | | m[9] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(6, 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:842:9 [INFO] [stderr] | [INFO] [stderr] 842 | / let temp = m[7]; [INFO] [stderr] 843 | | m[7] = m[13]; [INFO] [stderr] 844 | | m[13] = temp; [INFO] [stderr] | |____________________^ help: try: `m.swap(7, 13)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:845:9 [INFO] [stderr] | [INFO] [stderr] 845 | / let temp = m[11]; [INFO] [stderr] 846 | | m[11] = m[14]; [INFO] [stderr] 847 | | m[14] = temp; [INFO] [stderr] | |____________________^ help: try: `m.swap(11, 14)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:848:9 [INFO] [stderr] | [INFO] [stderr] 848 | / let temp = m[3]; [INFO] [stderr] 849 | | m[3] = m[12]; [INFO] [stderr] 850 | | m[12] = temp; [INFO] [stderr] | |____________________^ help: try: `m.swap(3, 12)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (17/7) [INFO] [stderr] --> src/matrix4.rs:782:5 [INFO] [stderr] | [INFO] [stderr] 782 | / pub fn set( [INFO] [stderr] 783 | | &mut self, [INFO] [stderr] 784 | | m11: f32, [INFO] [stderr] 785 | | m21: f32, [INFO] [stderr] ... | [INFO] [stderr] 816 | | self.set_m44(m44); [INFO] [stderr] 817 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:833:9 [INFO] [stderr] | [INFO] [stderr] 833 | / let temp = m[1]; [INFO] [stderr] 834 | | m[1] = m[4]; [INFO] [stderr] 835 | | m[4] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(1, 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:836:9 [INFO] [stderr] | [INFO] [stderr] 836 | / let temp = m[2]; [INFO] [stderr] 837 | | m[2] = m[8]; [INFO] [stderr] 838 | | m[8] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(2, 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:839:9 [INFO] [stderr] | [INFO] [stderr] 839 | / let temp = m[6]; [INFO] [stderr] 840 | | m[6] = m[9]; [INFO] [stderr] 841 | | m[9] = temp; [INFO] [stderr] | |___________________^ help: try: `m.swap(6, 9)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:842:9 [INFO] [stderr] | [INFO] [stderr] 842 | / let temp = m[7]; [INFO] [stderr] 843 | | m[7] = m[13]; [INFO] [stderr] 844 | | m[13] = temp; [INFO] [stderr] | |____________________^ help: try: `m.swap(7, 13)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:845:9 [INFO] [stderr] | [INFO] [stderr] 845 | / let temp = m[11]; [INFO] [stderr] 846 | | m[11] = m[14]; [INFO] [stderr] 847 | | m[14] = temp; [INFO] [stderr] | |____________________^ help: try: `m.swap(11, 14)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `m` manually [INFO] [stderr] --> src/matrix4.rs:848:9 [INFO] [stderr] | [INFO] [stderr] 848 | / let temp = m[3]; [INFO] [stderr] 849 | | m[3] = m[12]; [INFO] [stderr] 850 | | m[12] = temp; [INFO] [stderr] | |____________________^ help: try: `m.swap(3, 12)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vector2::Vector2` [INFO] [stderr] --> src/vector2.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Vector2 { [INFO] [stderr] 30 | | ZERO [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn dot(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn dot(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn cross(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn cross(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn cross_scalar_vec(s: f32, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:107:32 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn cross_vec_scalar(v: &Vector2, s: f32) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn min(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn min(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn max(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn max(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn clamp(&mut self, a: &Vector2, b: &Vector2) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:156:45 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn clamp(&mut self, a: &Vector2, b: &Vector2) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:189:22 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn magnitude(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:203:30 [INFO] [stderr] | [INFO] [stderr] 203 | pub fn magnitude_squared(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn is_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/vector2.rs:272:18 [INFO] [stderr] | [INFO] [stderr] 272 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 272 | for in self.iter().take(2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | fn print(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vector2.rs:343:5 [INFO] [stderr] | [INFO] [stderr] 343 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut f32 { [INFO] [stderr] 344 | | match index { [INFO] [stderr] 345 | | 0 => &mut self.x, [INFO] [stderr] 346 | | 1 => &mut self.y, [INFO] [stderr] 347 | | _ => panic!("Invalid index for Vector2: {}", index), [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vector3::Vector3` [INFO] [stderr] --> src/vector3.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> Vector3 { [INFO] [stderr] 59 | | ZERO [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vector2::Vector2` [INFO] [stderr] --> src/vector2.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Vector2 { [INFO] [stderr] 30 | | ZERO [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/vector3.rs:259:18 [INFO] [stderr] | [INFO] [stderr] 259 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn dot(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] 259 | for in self.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn dot(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn cross(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn cross(a: &Vector2, b: &Vector2) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn cross_scalar_vec(s: f32, v: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:107:32 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn cross_vec_scalar(v: &Vector2, s: f32) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn min(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn min(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn max(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn max(a: &Vector2, b: &Vector2) -> Vector2 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn clamp(&mut self, a: &Vector2, b: &Vector2) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:156:45 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn clamp(&mut self, a: &Vector2, b: &Vector2) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vector3.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut f32 { [INFO] [stderr] 358 | | match index { [INFO] [stderr] 359 | | 0 => &mut self.x, [INFO] [stderr] 360 | | 1 => &mut self.y, [INFO] [stderr] ... | [INFO] [stderr] 363 | | } [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:189:22 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn magnitude(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:203:30 [INFO] [stderr] | [INFO] [stderr] 203 | pub fn magnitude_squared(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:271:21 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn is_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/vector2.rs:272:18 [INFO] [stderr] | [INFO] [stderr] 272 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 272 | for in self.iter().take(2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector2.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | fn print(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vector2.rs:343:5 [INFO] [stderr] | [INFO] [stderr] 343 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut f32 { [INFO] [stderr] 344 | | match index { [INFO] [stderr] 345 | | 0 => &mut self.x, [INFO] [stderr] 346 | | 1 => &mut self.y, [INFO] [stderr] 347 | | _ => panic!("Invalid index for Vector2: {}", index), [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vector4::Vector4` [INFO] [stderr] --> src/vector4.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Vector4 { [INFO] [stderr] 43 | | ZERO [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/vector4.rs:226:18 [INFO] [stderr] | [INFO] [stderr] 226 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 226 | for in self.iter().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vector3::Vector3` [INFO] [stderr] --> src/vector3.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new() -> Vector3 { [INFO] [stderr] 59 | | ZERO [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vector4.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut f32 { [INFO] [stderr] 308 | | match index { [INFO] [stderr] 309 | | 0 => &mut self.x, [INFO] [stderr] 310 | | 1 => &mut self.y, [INFO] [stderr] ... | [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/vector3.rs:259:18 [INFO] [stderr] | [INFO] [stderr] 259 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 259 | for in self.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vector3.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut f32 { [INFO] [stderr] 358 | | match index { [INFO] [stderr] 359 | | 0 => &mut self.x, [INFO] [stderr] 360 | | 1 => &mut self.y, [INFO] [stderr] ... | [INFO] [stderr] 363 | | } [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vector4::Vector4` [INFO] [stderr] --> src/vector4.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Vector4 { [INFO] [stderr] 43 | | ZERO [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/vector4.rs:226:18 [INFO] [stderr] | [INFO] [stderr] 226 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 226 | for in self.iter().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vector4.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut f32 { [INFO] [stderr] 308 | | match index { [INFO] [stderr] 309 | | 0 => &mut self.x, [INFO] [stderr] 310 | | 1 => &mut self.y, [INFO] [stderr] ... | [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "c6562b7d7e4f5f7958a69fa0a0bed417ff2c4c77cb384cca7e1e8c95f2bbea46"` [INFO] running `"docker" "rm" "-f" "c6562b7d7e4f5f7958a69fa0a0bed417ff2c4c77cb384cca7e1e8c95f2bbea46"` [INFO] [stdout] c6562b7d7e4f5f7958a69fa0a0bed417ff2c4c77cb384cca7e1e8c95f2bbea46