[INFO] crate vesema 0.0.2 is already in cache [INFO] extracting crate vesema 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/vesema/0.0.2 [INFO] extracting crate vesema 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vesema/0.0.2 [INFO] validating manifest of vesema-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vesema-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vesema-0.0.2 [INFO] finished frobbing vesema-0.0.2 [INFO] frobbed toml for vesema-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/vesema/0.0.2/Cargo.toml [INFO] started frobbing vesema-0.0.2 [INFO] finished frobbing vesema-0.0.2 [INFO] frobbed toml for vesema-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vesema/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vesema-0.0.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vesema/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67f63e92f57c1e82191d71db770957de3343c3080d271c74bde1d65a3515137d [INFO] running `"docker" "start" "-a" "67f63e92f57c1e82191d71db770957de3343c3080d271c74bde1d65a3515137d"` [INFO] [stderr] Checking vesema v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec_set.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | VecSet { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec_map.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | VecMap { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sorted_vec.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | SortedVec { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sorted_vec.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | SortedVec { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec_set.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | VecSet { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec_map.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | VecMap { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sorted_vec.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | SortedVec { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sorted_vec.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | SortedVec { v: v } [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/vec_set.rs:46:2 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn into_iter(self) -> IntoIter { [INFO] [stderr] | _____^ [INFO] [stderr] 47 | | self.v.into_iter() [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/vec_map.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn to_vec(self) -> Vec<(K, V)> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/vec_map.rs:46:2 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn into_iter(self) -> IntoIter<(K, V)> { [INFO] [stderr] | _____^ [INFO] [stderr] 47 | | self.v.into_iter() [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sorted_vec.rs:53:2 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn into_iter(self) -> IntoIter { [INFO] [stderr] | _____^ [INFO] [stderr] 54 | | self.v.into_iter() [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sorted_set.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn into_iter(self) -> IntoIter { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | self.v.into_iter() [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/sorted_map.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | fn ne(&self, y: &Self) -> bool { [INFO] [stderr] | _____^ [INFO] [stderr] 14 | | self.0 != y.0 [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sorted_map::SortedMap` [INFO] [stderr] --> src/sorted_map.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | SortedMap { v: SortedVec::new() } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | impl Default for sorted_map::SortedMap { [INFO] [stderr] 38 | fn default() -> Self { [INFO] [stderr] 39 | Self::new() [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sorted_map.rs:79:2 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn into_iter(self) -> IntoIter> { [INFO] [stderr] | _____^ [INFO] [stderr] 80 | | self.v.into_iter() [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/vec_set.rs:46:2 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn into_iter(self) -> IntoIter { [INFO] [stderr] | _____^ [INFO] [stderr] 47 | | self.v.into_iter() [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/vec_map.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn to_vec(self) -> Vec<(K, V)> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/vec_map.rs:46:2 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn into_iter(self) -> IntoIter<(K, V)> { [INFO] [stderr] | _____^ [INFO] [stderr] 47 | | self.v.into_iter() [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sorted_vec.rs:53:2 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn into_iter(self) -> IntoIter { [INFO] [stderr] | _____^ [INFO] [stderr] 54 | | self.v.into_iter() [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sorted_set.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn into_iter(self) -> IntoIter { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | self.v.into_iter() [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/sorted_map.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | fn ne(&self, y: &Self) -> bool { [INFO] [stderr] | _____^ [INFO] [stderr] 14 | | self.0 != y.0 [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sorted_map::SortedMap` [INFO] [stderr] --> src/sorted_map.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | SortedMap { v: SortedVec::new() } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | impl Default for sorted_map::SortedMap { [INFO] [stderr] 38 | fn default() -> Self { [INFO] [stderr] 39 | Self::new() [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sorted_map.rs:79:2 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn into_iter(self) -> IntoIter> { [INFO] [stderr] | _____^ [INFO] [stderr] 80 | | self.v.into_iter() [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "67f63e92f57c1e82191d71db770957de3343c3080d271c74bde1d65a3515137d"` [INFO] running `"docker" "rm" "-f" "67f63e92f57c1e82191d71db770957de3343c3080d271c74bde1d65a3515137d"` [INFO] [stdout] 67f63e92f57c1e82191d71db770957de3343c3080d271c74bde1d65a3515137d