[INFO] crate version_check 0.1.5 is already in cache [INFO] extracting crate version_check 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/version_check/0.1.5 [INFO] extracting crate version_check 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version_check/0.1.5 [INFO] validating manifest of version_check-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of version_check-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing version_check-0.1.5 [INFO] finished frobbing version_check-0.1.5 [INFO] frobbed toml for version_check-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/version_check/0.1.5/Cargo.toml [INFO] started frobbing version_check-0.1.5 [INFO] finished frobbing version_check-0.1.5 [INFO] frobbed toml for version_check-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version_check/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting version_check-0.1.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version_check/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 147a543145ed92c1f09fd0b5214ba1d2ba1b0cd8077237d20fa98367e35a99c6 [INFO] running `"docker" "start" "-a" "147a543145ed92c1f09fd0b5214ba1d2ba1b0cd8077237d20fa98367e35a99c6"` [INFO] [stderr] Checking version_check v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | let ymd: Vec = ymd.split("-").filter_map(|s| s.parse::().ok()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:30 [INFO] [stderr] | [INFO] [stderr] 83 | let (maj, min, patch) = (mmp[0] as u64, mmp[1] as u64, mmp[2] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(mmp[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:45 [INFO] [stderr] | [INFO] [stderr] 83 | let (maj, min, patch) = (mmp[0] as u64, mmp[1] as u64, mmp[2] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(mmp[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:60 [INFO] [stderr] | [INFO] [stderr] 83 | let (maj, min, patch) = (mmp[0] as u64, mmp[1] as u64, mmp[2] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(mmp[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | let mut components = last_line.trim().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:92:76 [INFO] [stderr] | [INFO] [stderr] 92 | let date = components.nth(1).map(|s| s.trim_right().trim_right_matches(")")); [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | let ymd: Vec = ymd.split("-").filter_map(|s| s.parse::().ok()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:30 [INFO] [stderr] | [INFO] [stderr] 83 | let (maj, min, patch) = (mmp[0] as u64, mmp[1] as u64, mmp[2] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(mmp[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:45 [INFO] [stderr] | [INFO] [stderr] 83 | let (maj, min, patch) = (mmp[0] as u64, mmp[1] as u64, mmp[2] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(mmp[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:83:60 [INFO] [stderr] | [INFO] [stderr] 83 | let (maj, min, patch) = (mmp[0] as u64, mmp[1] as u64, mmp[2] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(mmp[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | let mut components = last_line.trim().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:92:76 [INFO] [stderr] | [INFO] [stderr] 92 | let date = components.nth(1).map(|s| s.trim_right().trim_right_matches(")")); [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/lib.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / fn test_version_parse() { [INFO] [stderr] 234 | | check_version!("rustc 1.18.0" => (1, 18, 0)); [INFO] [stderr] 235 | | check_version!("rustc 1.8.0" => (1, 8, 0)); [INFO] [stderr] 236 | | check_version!("rustc 1.20.0-nightly" => (1, 20, 0)); [INFO] [stderr] ... | [INFO] [stderr] 253 | | rustc 1.30.0-nightly (3bc2ca7e4 2018-09-20)" => (1, 30, 0)); [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "147a543145ed92c1f09fd0b5214ba1d2ba1b0cd8077237d20fa98367e35a99c6"` [INFO] running `"docker" "rm" "-f" "147a543145ed92c1f09fd0b5214ba1d2ba1b0cd8077237d20fa98367e35a99c6"` [INFO] [stdout] 147a543145ed92c1f09fd0b5214ba1d2ba1b0cd8077237d20fa98367e35a99c6