[INFO] crate vault 1.0.0 is already in cache [INFO] extracting crate vault 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/vault/1.0.0 [INFO] extracting crate vault 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vault/1.0.0 [INFO] validating manifest of vault-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vault-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vault-1.0.0 [INFO] finished frobbing vault-1.0.0 [INFO] frobbed toml for vault-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/vault/1.0.0/Cargo.toml [INFO] started frobbing vault-1.0.0 [INFO] finished frobbing vault-1.0.0 [INFO] frobbed toml for vault-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vault/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vault-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vault/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f98b7ce713baa9ed7a72282e27e5bdddf62f30f5665cf19cbea0ef9b763e7c42 [INFO] running `"docker" "start" "-a" "f98b7ce713baa9ed7a72282e27e5bdddf62f30f5665cf19cbea0ef9b763e7c42"` [INFO] [stderr] Checking vault v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chat_line.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | tick: tick, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | tick: tick, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tick` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | command_type: command_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | command_bytes: command_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | clean_file: clean_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | item_type: item_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chat_line.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | tick: tick, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | tick: tick, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tick` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | command_type: command_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | command_bytes: command_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | clean_file: clean_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | item_type: item_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | description_long: description_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description_long` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | players: players [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/replay.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | description_long: description_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description_long` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | players: players [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/replay.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/replay.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/replay.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/replay.rs:258:40 [INFO] [stderr] | [INFO] [stderr] 258 | test_eq!(self.file.read_u32(), 0x1A0A0D); // chunky type [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001A_0A0D` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/replay.rs:258:40 [INFO] [stderr] | [INFO] [stderr] 258 | test_eq!(self.file.read_u32(), 0x1A0A0D); // chunky type [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001A_0A0D` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `item::*` [INFO] [stderr] --> src/tests.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use item::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `u64` [INFO] [stderr] --> src/tests.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | use std::{u32, u64}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:184:44 [INFO] [stderr] | [INFO] [stderr] 184 | assert_eq!(stream.read_u32().unwrap(), 0x03020100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0302_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:185:44 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(stream.read_u32().unwrap(), 0x07060504); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0706_0504` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:186:44 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(stream.read_u32().unwrap(), 0x0B0A0908); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0B0A_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:202:44 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(stream.read_u32().unwrap(), 0x0B0A0908); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0B0A_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:211:44 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(stream.read_u64().unwrap(), 0x0706050403020100); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0706_0504_0302_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:212:44 [INFO] [stderr] | [INFO] [stderr] 212 | assert_eq!(stream.read_u64().unwrap(), 0x0F0E0D0C0B0A0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0F0E_0D0C_0B0A_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:228:44 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(stream.read_u64().unwrap(), 0x0F0E0D0C0B0A0908); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0F0E_0D0C_0B0A_0908` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/replay.rs:929:13 [INFO] [stderr] | [INFO] [stderr] 929 | let mut commands = self.commands.entry(player_id).or_insert(Vec::new()); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::Map` [INFO] [stderr] --> src/map.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Map { [INFO] [stderr] 30 | | Map { [INFO] [stderr] 31 | | file: String::new(), [INFO] [stderr] 32 | | name: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `player::Player` [INFO] [stderr] --> src/player.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Player { [INFO] [stderr] 36 | | Player { [INFO] [stderr] 37 | | id: 0xF, [INFO] [stderr] 38 | | name: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:399:33 [INFO] [stderr] | [INFO] [stderr] 399 | let check = try!(self.file.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 399 | let check = u32::from(match $ expr { [INFO] [stderr] 400 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 401 | :: Err ( err ) => { [INFO] [stderr] 402 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 403 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:412:50 [INFO] [stderr] | [INFO] [stderr] 412 | let bundle_part_length = try!(self.file.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 412 | let bundle_part_length = u32::from(match $ expr { [INFO] [stderr] 413 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 414 | :: Err ( err ) => { [INFO] [stderr] 415 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 416 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/replay.rs:581:17 [INFO] [stderr] | [INFO] [stderr] 581 | / match command_sub_id { [INFO] [stderr] 582 | | 0x22 => { [INFO] [stderr] 583 | | try!(self.file.skip_ahead(1)); // inner data length [INFO] [stderr] 584 | | try!(self.file.skip_ahead(1)); // usually 0x1 [INFO] [stderr] ... | [INFO] [stderr] 588 | | _ => {} [INFO] [stderr] 589 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 581 | if let 0x22 = command_sub_id { [INFO] [stderr] 582 | try!(self.file.skip_ahead(1)); // inner data length [INFO] [stderr] 583 | try!(self.file.skip_ahead(1)); // usually 0x1 [INFO] [stderr] 584 | command.entity_id = try!(self.file.read_u32()); [INFO] [stderr] 585 | try!(self.file.skip_ahead(1)); // usually 0x0 [INFO] [stderr] 586 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:881:35 [INFO] [stderr] | [INFO] [stderr] 881 | try!(self.file.skip_ahead(size as u32)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/replay.rs:929:59 [INFO] [stderr] | [INFO] [stderr] 929 | let mut commands = self.commands.entry(player_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:981:64 [INFO] [stderr] | [INFO] [stderr] 981 | player.cpm = commands.len() as f64 / ( self.duration as f64 / 480.0f64 ); // 8 ticks/s x 60s = 480 ticks/min [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:999:68 [INFO] [stderr] | [INFO] [stderr] 999 | player.cpm = commands.len() as f64 / ( self.duration as f64 / 480.0f64 ); // 8 ticks/s x 60s = 480 ticks/min [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | if meta.len() >= u32::MAX as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:167:28 [INFO] [stderr] | [INFO] [stderr] 167 | let result: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:167:55 [INFO] [stderr] | [INFO] [stderr] 167 | let result: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | let result: u32 = ((stream[3] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:191:28 [INFO] [stderr] | [INFO] [stderr] 191 | ((stream[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | ((stream[1] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | (stream[0] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | let result: u64 = ((stream[7] as u64) << 56) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | ((stream[6] as u64) << 48) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | ((stream[5] as u64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:219:28 [INFO] [stderr] | [INFO] [stderr] 219 | ((stream[4] as u64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:220:28 [INFO] [stderr] | [INFO] [stderr] 220 | ((stream[3] as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:221:28 [INFO] [stderr] | [INFO] [stderr] 221 | ((stream[2] as u64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:222:28 [INFO] [stderr] | [INFO] [stderr] 222 | ((stream[1] as u64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | (stream[0] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/stream.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | Ok(unsafe { mem::transmute(result_u32) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(result_u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:260:27 [INFO] [stderr] | [INFO] [stderr] 260 | buff.push(*val as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:264:30 [INFO] [stderr] | [INFO] [stderr] 264 | buff[idx] += (*val as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:292:25 [INFO] [stderr] | [INFO] [stderr] 292 | let raw: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:292:52 [INFO] [stderr] | [INFO] [stderr] 292 | let raw: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/replay.rs:929:13 [INFO] [stderr] | [INFO] [stderr] 929 | let mut commands = self.commands.entry(player_id).or_insert(Vec::new()); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::Map` [INFO] [stderr] --> src/map.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Map { [INFO] [stderr] 30 | | Map { [INFO] [stderr] 31 | | file: String::new(), [INFO] [stderr] 32 | | name: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `player::Player` [INFO] [stderr] --> src/player.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Player { [INFO] [stderr] 36 | | Player { [INFO] [stderr] 37 | | id: 0xF, [INFO] [stderr] 38 | | name: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:399:33 [INFO] [stderr] | [INFO] [stderr] 399 | let check = try!(self.file.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 399 | let check = u32::from(match $ expr { [INFO] [stderr] 400 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 401 | :: Err ( err ) => { [INFO] [stderr] 402 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 403 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:412:50 [INFO] [stderr] | [INFO] [stderr] 412 | let bundle_part_length = try!(self.file.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 412 | let bundle_part_length = u32::from(match $ expr { [INFO] [stderr] 413 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 414 | :: Err ( err ) => { [INFO] [stderr] 415 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 416 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/replay.rs:581:17 [INFO] [stderr] | [INFO] [stderr] 581 | / match command_sub_id { [INFO] [stderr] 582 | | 0x22 => { [INFO] [stderr] 583 | | try!(self.file.skip_ahead(1)); // inner data length [INFO] [stderr] 584 | | try!(self.file.skip_ahead(1)); // usually 0x1 [INFO] [stderr] ... | [INFO] [stderr] 588 | | _ => {} [INFO] [stderr] 589 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 581 | if let 0x22 = command_sub_id { [INFO] [stderr] 582 | try!(self.file.skip_ahead(1)); // inner data length [INFO] [stderr] 583 | try!(self.file.skip_ahead(1)); // usually 0x1 [INFO] [stderr] 584 | command.entity_id = try!(self.file.read_u32()); [INFO] [stderr] 585 | try!(self.file.skip_ahead(1)); // usually 0x0 [INFO] [stderr] 586 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:881:35 [INFO] [stderr] | [INFO] [stderr] 881 | try!(self.file.skip_ahead(size as u32)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/replay.rs:929:59 [INFO] [stderr] | [INFO] [stderr] 929 | let mut commands = self.commands.entry(player_id).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:981:64 [INFO] [stderr] | [INFO] [stderr] 981 | player.cpm = commands.len() as f64 / ( self.duration as f64 / 480.0f64 ); // 8 ticks/s x 60s = 480 ticks/min [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/replay.rs:999:68 [INFO] [stderr] | [INFO] [stderr] 999 | player.cpm = commands.len() as f64 / ( self.duration as f64 / 480.0f64 ); // 8 ticks/s x 60s = 480 ticks/min [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | if meta.len() >= u32::MAX as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:167:28 [INFO] [stderr] | [INFO] [stderr] 167 | let result: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:167:55 [INFO] [stderr] | [INFO] [stderr] 167 | let result: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | let result: u32 = ((stream[3] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:191:28 [INFO] [stderr] | [INFO] [stderr] 191 | ((stream[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | ((stream[1] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | (stream[0] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | let result: u64 = ((stream[7] as u64) << 56) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | ((stream[6] as u64) << 48) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | ((stream[5] as u64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:219:28 [INFO] [stderr] | [INFO] [stderr] 219 | ((stream[4] as u64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:220:28 [INFO] [stderr] | [INFO] [stderr] 220 | ((stream[3] as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:221:28 [INFO] [stderr] | [INFO] [stderr] 221 | ((stream[2] as u64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:222:28 [INFO] [stderr] | [INFO] [stderr] 222 | ((stream[1] as u64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | (stream[0] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/stream.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | Ok(unsafe { mem::transmute(result_u32) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(result_u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:260:27 [INFO] [stderr] | [INFO] [stderr] 260 | buff.push(*val as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:264:30 [INFO] [stderr] | [INFO] [stderr] 264 | buff[idx] += (*val as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(*val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:292:25 [INFO] [stderr] | [INFO] [stderr] 292 | let raw: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/stream.rs:292:52 [INFO] [stderr] | [INFO] [stderr] 292 | let raw: u16 = ((stream[1] as u16) << 8) + (stream[0] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(stream[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.78s [INFO] running `"docker" "inspect" "f98b7ce713baa9ed7a72282e27e5bdddf62f30f5665cf19cbea0ef9b763e7c42"` [INFO] running `"docker" "rm" "-f" "f98b7ce713baa9ed7a72282e27e5bdddf62f30f5665cf19cbea0ef9b763e7c42"` [INFO] [stdout] f98b7ce713baa9ed7a72282e27e5bdddf62f30f5665cf19cbea0ef9b763e7c42