[INFO] crate urlparse 0.7.3 is already in cache [INFO] extracting crate urlparse 0.7.3 into work/ex/clippy-test-run/sources/stable/reg/urlparse/0.7.3 [INFO] extracting crate urlparse 0.7.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urlparse/0.7.3 [INFO] validating manifest of urlparse-0.7.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of urlparse-0.7.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing urlparse-0.7.3 [INFO] finished frobbing urlparse-0.7.3 [INFO] frobbed toml for urlparse-0.7.3 written to work/ex/clippy-test-run/sources/stable/reg/urlparse/0.7.3/Cargo.toml [INFO] started frobbing urlparse-0.7.3 [INFO] finished frobbing urlparse-0.7.3 [INFO] frobbed toml for urlparse-0.7.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urlparse/0.7.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting urlparse-0.7.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urlparse/0.7.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc32027f97b1f12d1b95d11b4bded17e96cd9bbd3c81c2bdc1df48a91bd6841d [INFO] running `"docker" "start" "-a" "cc32027f97b1f12d1b95d11b4bded17e96cd9bbd3c81c2bdc1df48a91bd6841d"` [INFO] [stderr] Checking urlparse v0.7.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/quote.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const ALWAYS_SAFE_BYTES : &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quote.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return String::from_utf8(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quote.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(result) => return Ok(result.replace(" ", "+")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result.replace(" ", "+"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quote.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/unquote.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const DIGIT : &'static [u8] = b"0123456789ABCDEFabcdef"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unquote.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return String::from_utf8(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unquote.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return unquote(_s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unquote(_s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unquote.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(byte); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_string.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/url.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | const SCHEMA_CHARS : &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/url.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/unquote.rs:36:48 [INFO] [stderr] | [INFO] [stderr] 36 | if let Some(digit) = to_digit(*fs.get(0).unwrap(), *fs.get(1).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&fs[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/unquote.rs:36:69 [INFO] [stderr] | [INFO] [stderr] 36 | if let Some(digit) = to_digit(*fs.get(0).unwrap(), *fs.get(1).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&fs[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/quote.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const ALWAYS_SAFE_BYTES : &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quote.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return String::from_utf8(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quote.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(result) => return Ok(result.replace(" ", "+")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result.replace(" ", "+"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quote.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/unquote.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const DIGIT : &'static [u8] = b"0123456789ABCDEFabcdef"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unquote.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return String::from_utf8(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unquote.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return unquote(_s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unquote(_s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unquote.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(byte); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query_string.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/url.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | const SCHEMA_CHARS : &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/url.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/query_string.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | fn get_first(&self, k: &String) -> Option<&String>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `url::Url` [INFO] [stderr] --> src/url.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Url { [INFO] [stderr] 47 | | Url { [INFO] [stderr] 48 | | scheme: "".to_string(), [INFO] [stderr] 49 | | netloc: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/url.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | let (netloc, extra) = match extra.starts_with("//") { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 107 | | true => { [INFO] [stderr] 108 | | let _extra = &extra[2..]; [INFO] [stderr] 109 | | let mut a = _extra; [INFO] [stderr] ... | [INFO] [stderr] 127 | | false => ("", extra), [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 106 | let (netloc, extra) = if extra.starts_with("//") { [INFO] [stderr] 107 | let _extra = &extra[2..]; [INFO] [stderr] 108 | let mut a = _extra; [INFO] [stderr] 109 | let mut b = ""; [INFO] [stderr] 110 | let mut delim = !0 as usize; [INFO] [stderr] 111 | for c in "/?#".chars() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/unquote.rs:36:48 [INFO] [stderr] | [INFO] [stderr] 36 | if let Some(digit) = to_digit(*fs.get(0).unwrap(), *fs.get(1).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&fs[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/unquote.rs:36:69 [INFO] [stderr] | [INFO] [stderr] 36 | if let Some(digit) = to_digit(*fs.get(0).unwrap(), *fs.get(1).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `&fs[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/query_string.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | fn get_first(&self, k: &String) -> Option<&String>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `url::Url` [INFO] [stderr] --> src/url.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Url { [INFO] [stderr] 47 | | Url { [INFO] [stderr] 48 | | scheme: "".to_string(), [INFO] [stderr] 49 | | netloc: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/url.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | let (netloc, extra) = match extra.starts_with("//") { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 107 | | true => { [INFO] [stderr] 108 | | let _extra = &extra[2..]; [INFO] [stderr] 109 | | let mut a = _extra; [INFO] [stderr] ... | [INFO] [stderr] 127 | | false => ("", extra), [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 106 | let (netloc, extra) = if extra.starts_with("//") { [INFO] [stderr] 107 | let _extra = &extra[2..]; [INFO] [stderr] 108 | let mut a = _extra; [INFO] [stderr] 109 | let mut b = ""; [INFO] [stderr] 110 | let mut delim = !0 as usize; [INFO] [stderr] 111 | for c in "/?#".chars() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `urlparse`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/test_query.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let q = map1.get(&"q".to_string()).unwrap().get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map1[&"q".to_string()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/test_query.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let e = map1.get(&"e".to_string()).unwrap().get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map1[&"e".to_string()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/test_query.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let a = map2.get(&"a".to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map2[&"a".to_string()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/test_query.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let b = map2.get(&"b".to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map2[&"b".to_string()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/test_query.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(*a.get(2).unwrap(), "亀井"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `&a[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 121 [INFO] [stderr] --> tests/test_urlparse.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn test_urlparse_rfc2732() { [INFO] [stderr] 21 | | let url = Url::parse("http://Test.python.org:5432/foo/"); [INFO] [stderr] 22 | | assert_eq!(url.scheme, "http"); [INFO] [stderr] 23 | | assert_eq!(url.netloc, "Test.python.org:5432"); [INFO] [stderr] ... | [INFO] [stderr] 164 | | assert_eq!(url.port, None); [INFO] [stderr] 165 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> tests/test_urlparse.rs:215:1 [INFO] [stderr] | [INFO] [stderr] 215 | / fn test_urlparse_anyscheme() { [INFO] [stderr] 216 | | let url = Url::parse("file:///tmp/junk.txt"); [INFO] [stderr] 217 | | assert_eq!(url.scheme, "file"); [INFO] [stderr] 218 | | assert_eq!(url.netloc, ""); [INFO] [stderr] ... | [INFO] [stderr] 266 | | assert_eq!(url.fragment, None); [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "cc32027f97b1f12d1b95d11b4bded17e96cd9bbd3c81c2bdc1df48a91bd6841d"` [INFO] running `"docker" "rm" "-f" "cc32027f97b1f12d1b95d11b4bded17e96cd9bbd3c81c2bdc1df48a91bd6841d"` [INFO] [stdout] cc32027f97b1f12d1b95d11b4bded17e96cd9bbd3c81c2bdc1df48a91bd6841d