[INFO] crate unic-ucd-normal 0.7.0 is already in cache [INFO] extracting crate unic-ucd-normal 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/unic-ucd-normal/0.7.0 [INFO] extracting crate unic-ucd-normal 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-normal/0.7.0 [INFO] validating manifest of unic-ucd-normal-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unic-ucd-normal-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unic-ucd-normal-0.7.0 [INFO] finished frobbing unic-ucd-normal-0.7.0 [INFO] frobbed toml for unic-ucd-normal-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/unic-ucd-normal/0.7.0/Cargo.toml [INFO] started frobbing unic-ucd-normal-0.7.0 [INFO] finished frobbing unic-ucd-normal-0.7.0 [INFO] frobbed toml for unic-ucd-normal-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-normal/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unic-ucd-normal-0.7.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-normal/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83f98fa23d4caad3f947f7c045ec3981061cf1d658d02ed472c740509de3e007 [INFO] running `"docker" "start" "-a" "83f98fa23d4caad3f947f7c045ec3981061cf1d658d02ed472c740509de3e007"` [INFO] [stderr] Checking unic-common v0.7.0 [INFO] [stderr] Checking unic-char-range v0.7.0 [INFO] [stderr] Checking unic-char-property v0.7.0 [INFO] [stderr] Checking unic-ucd-version v0.7.0 [INFO] [stderr] Checking unic-ucd-category v0.7.0 [INFO] [stderr] Checking unic-ucd-normal v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/composition.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canonical_combining_class.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn number(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canonical_combining_class.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn is_not_reordered(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canonical_combining_class.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn is_reordered(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/composition.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canonical_combining_class.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn number(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canonical_combining_class.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn is_not_reordered(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canonical_combining_class.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn is_reordered(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/canonical_combining_class.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / fn test_bmp() { [INFO] [stderr] 162 | | // Combining Diacritical Marks [INFO] [stderr] 163 | | assert_eq!(CCC::of('\u{0300}'), ccc::Above); [INFO] [stderr] 164 | | assert_eq!(CCC::of('\u{0314}'), ccc::Above); [INFO] [stderr] ... | [INFO] [stderr] 218 | | assert_eq!(CCC::of('\u{FFFF}'), ccc::NotReordered); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 65 [INFO] [stderr] --> src/decomposition_type.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / fn test_bmp() { [INFO] [stderr] 191 | | // Compatibility [INFO] [stderr] 192 | | assert_eq!(DT::of('\u{a0}'), Some(DT::NoBreak)); [INFO] [stderr] 193 | | assert_eq!(DT::of('\u{a8}'), Some(DT::Compat)); [INFO] [stderr] ... | [INFO] [stderr] 270 | | assert_eq!(DT::of('\u{FFFF}'), None); [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.20s [INFO] running `"docker" "inspect" "83f98fa23d4caad3f947f7c045ec3981061cf1d658d02ed472c740509de3e007"` [INFO] running `"docker" "rm" "-f" "83f98fa23d4caad3f947f7c045ec3981061cf1d658d02ed472c740509de3e007"` [INFO] [stdout] 83f98fa23d4caad3f947f7c045ec3981061cf1d658d02ed472c740509de3e007