[INFO] crate ulog 0.3.0 is already in cache [INFO] extracting crate ulog 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/ulog/0.3.0 [INFO] extracting crate ulog 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ulog/0.3.0 [INFO] validating manifest of ulog-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ulog-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ulog-0.3.0 [INFO] finished frobbing ulog-0.3.0 [INFO] frobbed toml for ulog-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/ulog/0.3.0/Cargo.toml [INFO] started frobbing ulog-0.3.0 [INFO] finished frobbing ulog-0.3.0 [INFO] frobbed toml for ulog-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ulog/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ulog-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ulog/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 485ccf89373bfc2e86321fce77046c5358d43c45c42f3d46f8860ca7751e5ada [INFO] running `"docker" "start" "-a" "485ccf89373bfc2e86321fce77046c5358d43c45c42f3d46f8860ca7751e5ada"` [INFO] [stderr] Checking ulog v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | location: record.location().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*record.location()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:146:16 [INFO] [stderr] | [INFO] [stderr] 146 | if let Err(_) = self.sender().try_send(msg) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 147 | | // failed to send log message; increase failure count [INFO] [stderr] 148 | | self.failures.fetch_add(1, Ordering::Relaxed); [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________- help: try this: `if self.sender().try_send(msg).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / loop { [INFO] [stderr] 166 | | // FIXME: maybe just exit successfully? [INFO] [stderr] 167 | | let msg = match rx.recv() { [INFO] [stderr] 168 | | Ok(m) => m, [INFO] [stderr] ... | [INFO] [stderr] 171 | | handle(msg); [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(m) = rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | location: record.location().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*record.location()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:146:16 [INFO] [stderr] | [INFO] [stderr] 146 | if let Err(_) = self.sender().try_send(msg) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 147 | | // failed to send log message; increase failure count [INFO] [stderr] 148 | | self.failures.fetch_add(1, Ordering::Relaxed); [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________- help: try this: `if self.sender().try_send(msg).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / loop { [INFO] [stderr] 166 | | // FIXME: maybe just exit successfully? [INFO] [stderr] 167 | | let msg = match rx.recv() { [INFO] [stderr] 168 | | Ok(m) => m, [INFO] [stderr] ... | [INFO] [stderr] 171 | | handle(msg); [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(m) = rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "485ccf89373bfc2e86321fce77046c5358d43c45c42f3d46f8860ca7751e5ada"` [INFO] running `"docker" "rm" "-f" "485ccf89373bfc2e86321fce77046c5358d43c45c42f3d46f8860ca7751e5ada"` [INFO] [stdout] 485ccf89373bfc2e86321fce77046c5358d43c45c42f3d46f8860ca7751e5ada