[INFO] crate ukhasnet-parser 0.4.0 is already in cache [INFO] extracting crate ukhasnet-parser 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/ukhasnet-parser/0.4.0 [INFO] extracting crate ukhasnet-parser 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ukhasnet-parser/0.4.0 [INFO] validating manifest of ukhasnet-parser-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ukhasnet-parser-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ukhasnet-parser-0.4.0 [INFO] finished frobbing ukhasnet-parser-0.4.0 [INFO] frobbed toml for ukhasnet-parser-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/ukhasnet-parser/0.4.0/Cargo.toml [INFO] started frobbing ukhasnet-parser-0.4.0 [INFO] finished frobbing ukhasnet-parser-0.4.0 [INFO] frobbed toml for ukhasnet-parser-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ukhasnet-parser/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ukhasnet-parser-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ukhasnet-parser/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5e35bf0f21bfe303f9ec9b34ddc2aae6a6ccb0e2e50291c65abd70fd9f5a506 [INFO] running `"docker" "start" "-a" "e5e35bf0f21bfe303f9ec9b34ddc2aae6a6ccb0e2e50291c65abd70fd9f5a506"` [INFO] [stderr] Checking ukhasnet-parser v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | ParserError{ position: position, expected: exp } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | ParserError{ position: position, expected: exp } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::short_circuit_statement)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused logical operation that must be used [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: boolean short circuit operator in statement may be clearer using an explicit test [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#short_circuit_statement [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn parse(packet: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match parser.packet() { [INFO] [stderr] 16 | | true => Ok(parser.parse()), [INFO] [stderr] 17 | | false => Err(ParserError::from_parser(&mut parser)), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if parser.packet() { Ok(parser.parse()) } else { Err(ParserError::from_parser(&mut parser)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / impl_rdp! { [INFO] [stderr] 7 | | /* [INFO] [stderr] 8 | | * UKHASnet Packet Grammar [INFO] [stderr] 9 | | * [INFO] [stderr] ... | [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn parse(packet: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match parser.packet() { [INFO] [stderr] 16 | | true => Ok(parser.parse()), [INFO] [stderr] 17 | | false => Err(ParserError::from_parser(&mut parser)), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if parser.packet() { Ok(parser.parse()) } else { Err(ParserError::from_parser(&mut parser)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/cli.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/socket_stream.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/cli.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match parser.packet() { [INFO] [stderr] 16 | | true => println!("Parsed OK:"), [INFO] [stderr] 17 | | false => { [INFO] [stderr] 18 | | let (expected, position) = parser.expected(); [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 15 | if parser.packet() { println!("Parsed OK:") } else { [INFO] [stderr] 16 | let (expected, position) = parser.expected(); [INFO] [stderr] 17 | [INFO] [stderr] 18 | println!("Failure at input position {}", position); [INFO] [stderr] 19 | println!("\n{}", packet); [INFO] [stderr] 20 | for _ in 0..position { print!(" "); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/batch.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | Err(_) => panic!() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/batch.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match parse(&line) { [INFO] [stderr] 25 | | Ok(_) => parsed += 1, [INFO] [stderr] 26 | | Err(_) => (), [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = parse(&line) { parsed += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `"docker" "inspect" "e5e35bf0f21bfe303f9ec9b34ddc2aae6a6ccb0e2e50291c65abd70fd9f5a506"` [INFO] running `"docker" "rm" "-f" "e5e35bf0f21bfe303f9ec9b34ddc2aae6a6ccb0e2e50291c65abd70fd9f5a506"` [INFO] [stdout] e5e35bf0f21bfe303f9ec9b34ddc2aae6a6ccb0e2e50291c65abd70fd9f5a506