[INFO] crate uid 0.1.2 is already in cache [INFO] extracting crate uid 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/uid/0.1.2 [INFO] extracting crate uid 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uid/0.1.2 [INFO] validating manifest of uid-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uid-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uid-0.1.2 [INFO] finished frobbing uid-0.1.2 [INFO] frobbed toml for uid-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/uid/0.1.2/Cargo.toml [INFO] started frobbing uid-0.1.2 [INFO] finished frobbing uid-0.1.2 [INFO] frobbed toml for uid-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uid/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uid-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uid/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50e9fe8f33523fe6c952e7ed98927f2a967aee173376f76ee434ec1ced193de5 [INFO] running `"docker" "start" "-a" "50e9fe8f33523fe6c952e7ed98927f2a967aee173376f76ee434ec1ced193de5"` [INFO] [stderr] Checking uid v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | redundant_field_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | redundant_field_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] [INFO] [stderr] error: you should consider adding a `Default` implementation for `Id` [INFO] [stderr] --> src/lib.rs:124:3 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | static NEXT_ID: AtomicUsize = AtomicUsize::new(1); [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | let id = NEXT_ID.fetch_add(1, Ordering::Relaxed); [INFO] [stderr] 128 | | Self::new_unchecked(id) [INFO] [stderr] 129 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | impl Default for Id { [INFO] [stderr] 112 | fn default() -> Self { [INFO] [stderr] 113 | Self::new() [INFO] [stderr] 114 | } [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:132:14 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `uid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you should consider adding a `Default` implementation for `Id` [INFO] [stderr] --> src/lib.rs:124:3 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | static NEXT_ID: AtomicUsize = AtomicUsize::new(1); [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | let id = NEXT_ID.fetch_add(1, Ordering::Relaxed); [INFO] [stderr] 128 | | Self::new_unchecked(id) [INFO] [stderr] 129 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | impl Default for Id { [INFO] [stderr] 112 | fn default() -> Self { [INFO] [stderr] 113 | Self::new() [INFO] [stderr] 114 | } [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:132:14 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/lib.rs:189:24 [INFO] [stderr] | [INFO] [stderr] 189 | .map(|_| spawn(|| TestId::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `TestId::new` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `uid`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "50e9fe8f33523fe6c952e7ed98927f2a967aee173376f76ee434ec1ced193de5"` [INFO] running `"docker" "rm" "-f" "50e9fe8f33523fe6c952e7ed98927f2a967aee173376f76ee434ec1ced193de5"` [INFO] [stdout] 50e9fe8f33523fe6c952e7ed98927f2a967aee173376f76ee434ec1ced193de5