[INFO] crate typescriptify-derive 0.1.5 is already in cache [INFO] extracting crate typescriptify-derive 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/typescriptify-derive/0.1.5 [INFO] extracting crate typescriptify-derive 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/typescriptify-derive/0.1.5 [INFO] validating manifest of typescriptify-derive-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of typescriptify-derive-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing typescriptify-derive-0.1.5 [INFO] finished frobbing typescriptify-derive-0.1.5 [INFO] frobbed toml for typescriptify-derive-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/typescriptify-derive/0.1.5/Cargo.toml [INFO] started frobbing typescriptify-derive-0.1.5 [INFO] finished frobbing typescriptify-derive-0.1.5 [INFO] frobbed toml for typescriptify-derive-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/typescriptify-derive/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting typescriptify-derive-0.1.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/typescriptify-derive/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 948617650a9e7b81f3250298866b0a3c0eeb686cf6407610df76823791c0a523 [INFO] running `"docker" "start" "-a" "948617650a9e7b81f3250298866b0a3c0eeb686cf6407610df76823791c0a523"` [INFO] [stderr] Checking typescriptify-derive v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / fn impl_hello_world(ast: &syn::DeriveInput) -> quote::Tokens { [INFO] [stderr] 25 | | let name = &ast.ident; [INFO] [stderr] 26 | | let structname = name.to_string(); [INFO] [stderr] 27 | | let _body = &ast.body; [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | let fieldname: String = format!("{}", field.ident.clone().unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `field.ident.clone().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | let generic_params_unformated = &path.segments.last().clone().unwrap().parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `path.segments.last()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | / match generic_params_unformated { [INFO] [stderr] 51 | | &syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] 52 | | for ty in &angle_bracketed_parameter_data.types { [INFO] [stderr] 53 | | match ty { [INFO] [stderr] ... | [INFO] [stderr] 61 | | _ => unimplemented!(), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *generic_params_unformated { [INFO] [stderr] 51 | syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | / match ty { [INFO] [stderr] 54 | | &syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] 55 | | generics_parameters.push(format!("{}", qotherpath.segments.last().unwrap().ident)); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | _ => unimplemented!(), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *ty { [INFO] [stderr] 54 | syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ", "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ", "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:91:33 [INFO] [stderr] | [INFO] [stderr] 91 | / generic_term_in_angle_brackets = generic_term_in_angle_brackets + match gen.as_ref() { [INFO] [stderr] 92 | | "i8" => "number", [INFO] [stderr] 93 | | "i16" => "number", [INFO] [stderr] 94 | | "i32" => "number", [INFO] [stderr] ... | [INFO] [stderr] 109 | | a @ _ => a, [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 91 | generic_term_in_angle_brackets += match gen.as_ref() { [INFO] [stderr] 92 | "i8" => "number", [INFO] [stderr] 93 | "i16" => "number", [INFO] [stderr] 94 | "i32" => "number", [INFO] [stderr] 95 | "i64" => "number", [INFO] [stderr] 96 | "u8" => "number", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ">"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | a @ _ => a.to_string(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:168:45 [INFO] [stderr] | [INFO] [stderr] 168 | let fieldname: String = format!("{}", field.ident.clone().unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `field.ident.clone().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:178:62 [INFO] [stderr] | [INFO] [stderr] 178 | let generic_params_unformated = &path.segments.last().clone().unwrap().parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `path.segments.last()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | / match generic_params_unformated { [INFO] [stderr] 181 | | &syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] 182 | | for ty in &angle_bracketed_parameter_data.types { [INFO] [stderr] 183 | | match ty { [INFO] [stderr] ... | [INFO] [stderr] 191 | | _ => unimplemented!(), [INFO] [stderr] 192 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 180 | match *generic_params_unformated { [INFO] [stderr] 181 | syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:183:41 [INFO] [stderr] | [INFO] [stderr] 183 | / match ty { [INFO] [stderr] 184 | | &syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] 185 | | generics_parameters.push(format!("{}", qotherpath.segments.last().unwrap().ident)); [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | _ => unimplemented!(), [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 183 | match *ty { [INFO] [stderr] 184 | syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:213:37 [INFO] [stderr] | [INFO] [stderr] 213 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:219:41 [INFO] [stderr] | [INFO] [stderr] 219 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ", "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ", "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:221:37 [INFO] [stderr] | [INFO] [stderr] 221 | / generic_term_in_angle_brackets = generic_term_in_angle_brackets + match gen.as_ref() { [INFO] [stderr] 222 | | "i8" => "number", [INFO] [stderr] 223 | | "i16" => "number", [INFO] [stderr] 224 | | "i32" => "number", [INFO] [stderr] ... | [INFO] [stderr] 239 | | a @ _ => a, [INFO] [stderr] 240 | | }; [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 221 | generic_term_in_angle_brackets += match gen.as_ref() { [INFO] [stderr] 222 | "i8" => "number", [INFO] [stderr] 223 | "i16" => "number", [INFO] [stderr] 224 | "i32" => "number", [INFO] [stderr] 225 | "i64" => "number", [INFO] [stderr] 226 | "u8" => "number", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:239:41 [INFO] [stderr] | [INFO] [stderr] 239 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ">"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:263:37 [INFO] [stderr] | [INFO] [stderr] 263 | a @ _ => a.to_string(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / fn impl_hello_world(ast: &syn::DeriveInput) -> quote::Tokens { [INFO] [stderr] 25 | | let name = &ast.ident; [INFO] [stderr] 26 | | let structname = name.to_string(); [INFO] [stderr] 27 | | let _body = &ast.body; [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | let fieldname: String = format!("{}", field.ident.clone().unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `field.ident.clone().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | let generic_params_unformated = &path.segments.last().clone().unwrap().parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `path.segments.last()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | / match generic_params_unformated { [INFO] [stderr] 51 | | &syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] 52 | | for ty in &angle_bracketed_parameter_data.types { [INFO] [stderr] 53 | | match ty { [INFO] [stderr] ... | [INFO] [stderr] 61 | | _ => unimplemented!(), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *generic_params_unformated { [INFO] [stderr] 51 | syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | / match ty { [INFO] [stderr] 54 | | &syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] 55 | | generics_parameters.push(format!("{}", qotherpath.segments.last().unwrap().ident)); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | _ => unimplemented!(), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *ty { [INFO] [stderr] 54 | syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ", "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ", "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:91:33 [INFO] [stderr] | [INFO] [stderr] 91 | / generic_term_in_angle_brackets = generic_term_in_angle_brackets + match gen.as_ref() { [INFO] [stderr] 92 | | "i8" => "number", [INFO] [stderr] 93 | | "i16" => "number", [INFO] [stderr] 94 | | "i32" => "number", [INFO] [stderr] ... | [INFO] [stderr] 109 | | a @ _ => a, [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 91 | generic_term_in_angle_brackets += match gen.as_ref() { [INFO] [stderr] 92 | "i8" => "number", [INFO] [stderr] 93 | "i16" => "number", [INFO] [stderr] 94 | "i32" => "number", [INFO] [stderr] 95 | "i64" => "number", [INFO] [stderr] 96 | "u8" => "number", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ">"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | a @ _ => a.to_string(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:168:45 [INFO] [stderr] | [INFO] [stderr] 168 | let fieldname: String = format!("{}", field.ident.clone().unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `field.ident.clone().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:178:62 [INFO] [stderr] | [INFO] [stderr] 178 | let generic_params_unformated = &path.segments.last().clone().unwrap().parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `path.segments.last()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | / match generic_params_unformated { [INFO] [stderr] 181 | | &syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] 182 | | for ty in &angle_bracketed_parameter_data.types { [INFO] [stderr] 183 | | match ty { [INFO] [stderr] ... | [INFO] [stderr] 191 | | _ => unimplemented!(), [INFO] [stderr] 192 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 180 | match *generic_params_unformated { [INFO] [stderr] 181 | syn::PathParameters::AngleBracketed(ref angle_bracketed_parameter_data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:183:41 [INFO] [stderr] | [INFO] [stderr] 183 | / match ty { [INFO] [stderr] 184 | | &syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] 185 | | generics_parameters.push(format!("{}", qotherpath.segments.last().unwrap().ident)); [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | _ => unimplemented!(), [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 183 | match *ty { [INFO] [stderr] 184 | syn::Ty::Path(ref _qotherself, ref qotherpath) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:213:37 [INFO] [stderr] | [INFO] [stderr] 213 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:219:41 [INFO] [stderr] | [INFO] [stderr] 219 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ", "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ", "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:221:37 [INFO] [stderr] | [INFO] [stderr] 221 | / generic_term_in_angle_brackets = generic_term_in_angle_brackets + match gen.as_ref() { [INFO] [stderr] 222 | | "i8" => "number", [INFO] [stderr] 223 | | "i16" => "number", [INFO] [stderr] 224 | | "i32" => "number", [INFO] [stderr] ... | [INFO] [stderr] 239 | | a @ _ => a, [INFO] [stderr] 240 | | }; [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 221 | generic_term_in_angle_brackets += match gen.as_ref() { [INFO] [stderr] 222 | "i8" => "number", [INFO] [stderr] 223 | "i16" => "number", [INFO] [stderr] 224 | "i32" => "number", [INFO] [stderr] 225 | "i64" => "number", [INFO] [stderr] 226 | "u8" => "number", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:239:41 [INFO] [stderr] | [INFO] [stderr] 239 | a @ _ => a, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | generic_term_in_angle_brackets = generic_term_in_angle_brackets + ">"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generic_term_in_angle_brackets += ">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/lib.rs:263:37 [INFO] [stderr] | [INFO] [stderr] 263 | a @ _ => a.to_string(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "948617650a9e7b81f3250298866b0a3c0eeb686cf6407610df76823791c0a523"` [INFO] running `"docker" "rm" "-f" "948617650a9e7b81f3250298866b0a3c0eeb686cf6407610df76823791c0a523"` [INFO] [stdout] 948617650a9e7b81f3250298866b0a3c0eeb686cf6407610df76823791c0a523