[INFO] crate typedopts 1.1.2 is already in cache [INFO] extracting crate typedopts 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/typedopts/1.1.2 [INFO] extracting crate typedopts 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/typedopts/1.1.2 [INFO] validating manifest of typedopts-1.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of typedopts-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing typedopts-1.1.2 [INFO] finished frobbing typedopts-1.1.2 [INFO] frobbed toml for typedopts-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/typedopts/1.1.2/Cargo.toml [INFO] started frobbing typedopts-1.1.2 [INFO] finished frobbing typedopts-1.1.2 [INFO] frobbed toml for typedopts-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/typedopts/1.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting typedopts-1.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/typedopts/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 482bef367283818fb88e1586ac5067022d5f3baf573636a8c006e66e63004f03 [INFO] running `"docker" "start" "-a" "482bef367283818fb88e1586ac5067022d5f3baf573636a8c006e66e63004f03"` [INFO] [stderr] Checking typedopts v1.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:190:16 [INFO] [stderr] | [INFO] [stderr] 190 | let data = f(self); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:190:16 [INFO] [stderr] | [INFO] [stderr] 190 | let data = f(self); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `field` [INFO] [stderr] --> src/lib.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_field(&self, field: &str) -> Option { [INFO] [stderr] | ^^^^^ help: consider using `_field` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_idx` [INFO] [stderr] --> src/lib.rs:163:45 [INFO] [stderr] | [INFO] [stderr] 163 | fn read_enum_variant_arg(&mut self, a_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_a_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `names` [INFO] [stderr] --> src/lib.rs:169:48 [INFO] [stderr] | [INFO] [stderr] 169 | fn read_enum_struct_variant(&mut self, names: &[&str], f: F) -> DecodeResult where F: FnOnce(&mut Decoder, usize) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_names` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_name` [INFO] [stderr] --> src/lib.rs:175:54 [INFO] [stderr] | [INFO] [stderr] 175 | fn read_enum_struct_variant_field(&mut self, f_name: &str, f_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^^ help: consider using `_f_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_idx` [INFO] [stderr] --> src/lib.rs:175:68 [INFO] [stderr] | [INFO] [stderr] 175 | fn read_enum_struct_variant_field(&mut self, f_name: &str, f_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_f_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/lib.rs:181:49 [INFO] [stderr] | [INFO] [stderr] 181 | fn read_struct(&mut self, s_name: &str, len: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_idx` [INFO] [stderr] --> src/lib.rs:187:55 [INFO] [stderr] | [INFO] [stderr] 187 | fn read_struct_field(&mut self, f_name: &str, f_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_f_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tuple_len` [INFO] [stderr] --> src/lib.rs:210:35 [INFO] [stderr] | [INFO] [stderr] 210 | fn read_tuple(&mut self, tuple_len: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_tuple_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_idx` [INFO] [stderr] --> src/lib.rs:215:38 [INFO] [stderr] | [INFO] [stderr] 215 | fn read_tuple_arg(&mut self, a_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_a_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s_name` [INFO] [stderr] --> src/lib.rs:220:41 [INFO] [stderr] | [INFO] [stderr] 220 | fn read_tuple_struct(&mut self, s_name: &str, len:usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^^ help: consider using `_s_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/lib.rs:220:55 [INFO] [stderr] | [INFO] [stderr] 220 | fn read_tuple_struct(&mut self, s_name: &str, len:usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_idx` [INFO] [stderr] --> src/lib.rs:225:45 [INFO] [stderr] | [INFO] [stderr] 225 | fn read_tuple_struct_arg(&mut self, a_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_a_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/lib.rs:236:36 [INFO] [stderr] | [INFO] [stderr] 236 | fn read_seq_elt(&mut self, idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/lib.rs:246:40 [INFO] [stderr] | [INFO] [stderr] 246 | fn read_map_elt_key(&mut self, idx: usize, f: F) -> DecodeResult where F:FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/lib.rs:251:40 [INFO] [stderr] | [INFO] [stderr] 251 | fn read_map_elt_val(&mut self, idx: usize, f: F) -> DecodeResult where F:FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_field` [INFO] [stderr] --> src/lib.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_field(&self, field: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn to_err_msg(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | ErrorType::UnimplementedDecoder => format!("this function is not implemented"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"this function is not implemented".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:152:51 [INFO] [stderr] | [INFO] [stderr] 152 | Some(s) => match names.iter().position(|&e| e == &s) { [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | f(self, 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | f(self, 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | f(self, 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `field` [INFO] [stderr] --> src/lib.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_field(&self, field: &str) -> Option { [INFO] [stderr] | ^^^^^ help: consider using `_field` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_idx` [INFO] [stderr] --> src/lib.rs:163:45 [INFO] [stderr] | [INFO] [stderr] 163 | fn read_enum_variant_arg(&mut self, a_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_a_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `names` [INFO] [stderr] --> src/lib.rs:169:48 [INFO] [stderr] | [INFO] [stderr] 169 | fn read_enum_struct_variant(&mut self, names: &[&str], f: F) -> DecodeResult where F: FnOnce(&mut Decoder, usize) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_names` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_name` [INFO] [stderr] --> src/lib.rs:175:54 [INFO] [stderr] | [INFO] [stderr] 175 | fn read_enum_struct_variant_field(&mut self, f_name: &str, f_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^^ help: consider using `_f_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_idx` [INFO] [stderr] --> src/lib.rs:175:68 [INFO] [stderr] | [INFO] [stderr] 175 | fn read_enum_struct_variant_field(&mut self, f_name: &str, f_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_f_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/lib.rs:181:49 [INFO] [stderr] | [INFO] [stderr] 181 | fn read_struct(&mut self, s_name: &str, len: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f_idx` [INFO] [stderr] --> src/lib.rs:187:55 [INFO] [stderr] | [INFO] [stderr] 187 | fn read_struct_field(&mut self, f_name: &str, f_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_f_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tuple_len` [INFO] [stderr] --> src/lib.rs:210:35 [INFO] [stderr] | [INFO] [stderr] 210 | fn read_tuple(&mut self, tuple_len: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_tuple_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_idx` [INFO] [stderr] --> src/lib.rs:215:38 [INFO] [stderr] | [INFO] [stderr] 215 | fn read_tuple_arg(&mut self, a_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_a_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s_name` [INFO] [stderr] --> src/lib.rs:220:41 [INFO] [stderr] | [INFO] [stderr] 220 | fn read_tuple_struct(&mut self, s_name: &str, len:usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^^ help: consider using `_s_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/lib.rs:220:55 [INFO] [stderr] | [INFO] [stderr] 220 | fn read_tuple_struct(&mut self, s_name: &str, len:usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a_idx` [INFO] [stderr] --> src/lib.rs:225:45 [INFO] [stderr] | [INFO] [stderr] 225 | fn read_tuple_struct_arg(&mut self, a_idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^^^ help: consider using `_a_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/lib.rs:236:36 [INFO] [stderr] | [INFO] [stderr] 236 | fn read_seq_elt(&mut self, idx: usize, f: F) -> DecodeResult where F: FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/lib.rs:246:40 [INFO] [stderr] | [INFO] [stderr] 246 | fn read_map_elt_key(&mut self, idx: usize, f: F) -> DecodeResult where F:FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/lib.rs:251:40 [INFO] [stderr] | [INFO] [stderr] 251 | fn read_map_elt_val(&mut self, idx: usize, f: F) -> DecodeResult where F:FnOnce(&mut Decoder) -> DecodeResult { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_field` [INFO] [stderr] --> src/lib.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_field(&self, field: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn to_err_msg(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | ErrorType::UnimplementedDecoder => format!("this function is not implemented"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"this function is not implemented".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:152:51 [INFO] [stderr] | [INFO] [stderr] 152 | Some(s) => match names.iter().position(|&e| e == &s) { [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | f(self, 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | f(self, 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | f(self, 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | f(self); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `DecodeResult` [INFO] [stderr] --> examples/getopt.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | use typedopts::{DecodeResult,ErrorType}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/getopt.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | return opts; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `opts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/getopt.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | / help_opts.parse(args).map(|m| { [INFO] [stderr] 49 | | if m.opt_present("h") { [INFO] [stderr] 50 | | print_usage(&program, generate_options()); [INFO] [stderr] 51 | | return; [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Result value where `f` is a unit closure [INFO] [stderr] --> examples/getopt.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | help_opts.parse(args).map(|m| { [INFO] [stderr] | ___^ [INFO] [stderr] | |___| [INFO] [stderr] | || [INFO] [stderr] 49 | || if m.opt_present("h") { [INFO] [stderr] 50 | || print_usage(&program, generate_options()); [INFO] [stderr] 51 | || return; [INFO] [stderr] 52 | || } [INFO] [stderr] 53 | || }); [INFO] [stderr] | ||____^- help: try this: `if let Ok(m) = help_opts.parse(args) { ... }` [INFO] [stderr] | |_____| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::result_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> tests/test.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | use typedopts::{Error,ErrorType,DecodeResult}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let matches = go.parse(vec!["-n".to_string(), "10".to_string()]).ok().expect("getopts match"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let decoded: ParseInt = Decodable::decode(&mut decoder).ok().expect("ParseInt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | let matches = go.parse(vec!["-n".to_string(), "10.0".to_string()]).ok().expect("getopts match"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let matches = go.parse(vec!["-n".to_string(), "10".to_string()]).ok().expect("getopts match"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | let decoded: ParseFloat = Decodable::decode(&mut decoder).ok().expect("ParseFloat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/test.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(decoded.number, 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/test.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(decoded.number, 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let matches = go.parse(vec!["--boolean=true".to_string()]).ok().expect("getopts match"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:59:31 [INFO] [stderr] | [INFO] [stderr] 59 | let decoded: ParseBoolean = Decodable::decode(&mut decoder).ok().expect("ParseBoolean"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | let matches = go.parse(vec!["-c".to_string(), "a".to_string()]).ok().expect("getopts match"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | let decoded: ParseChar = Decodable::decode(&mut decoder).ok().expect("ParseChar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | let decoded: ParseString = Decodable::decode(&mut decoder).ok().expect("ParseString"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | let decoded: ParseEnum = Decodable::decode(&mut decoder).ok().expect("ParseEnum"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:128:30 [INFO] [stderr] | [INFO] [stderr] 128 | let decoded: ParseOption = Decodable::decode(&mut decoder).ok().expect("ParseOption"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:139:30 [INFO] [stderr] | [INFO] [stderr] 139 | let decoded: ParseOption = Decodable::decode(&mut decoder).ok().expect("ParseOption"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | let decoded: ParseStruct = Decodable::decode(&mut decoder).ok().expect("ParseStruct"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:174:30 [INFO] [stderr] | [INFO] [stderr] 174 | let decoded: ParseStruct = Decodable::decode(&mut decoder).ok().expect("ParseStruct"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:189:30 [INFO] [stderr] | [INFO] [stderr] 189 | let decoded: ParseStruct = result.ok().expect("ParseStruct"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `typedopts`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "482bef367283818fb88e1586ac5067022d5f3baf573636a8c006e66e63004f03"` [INFO] running `"docker" "rm" "-f" "482bef367283818fb88e1586ac5067022d5f3baf573636a8c006e66e63004f03"` [INFO] [stdout] 482bef367283818fb88e1586ac5067022d5f3baf573636a8c006e66e63004f03