[INFO] crate type1-encoding-parser 0.1.0 is already in cache
[INFO] extracting crate type1-encoding-parser 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/type1-encoding-parser/0.1.0
[INFO] extracting crate type1-encoding-parser 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/type1-encoding-parser/0.1.0
[INFO] validating manifest of type1-encoding-parser-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of type1-encoding-parser-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing type1-encoding-parser-0.1.0
[INFO] finished frobbing type1-encoding-parser-0.1.0
[INFO] frobbed toml for type1-encoding-parser-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/type1-encoding-parser/0.1.0/Cargo.toml
[INFO] started frobbing type1-encoding-parser-0.1.0
[INFO] finished frobbing type1-encoding-parser-0.1.0
[INFO] frobbed toml for type1-encoding-parser-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/type1-encoding-parser/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting type1-encoding-parser-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/type1-encoding-parser/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 543f2dbf21249147591a68026e00ccb4ace1fcb6ee3790e88c532220fb5e8f66
[INFO] running `"docker" "start" "-a" "543f2dbf21249147591a68026e00ccb4ace1fcb6ee3790e88c532220fb5e8f66"`
[INFO] [stderr]     Checking pom v1.1.0
[INFO] [stderr]     Checking type1-encoding-parser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]   --> src/lib.rs:90:18
[INFO] [stderr]    |
[INFO] [stderr] 90 |     sym(b'/') * (none_of(b" \t\n\r\x0C()<>[]{}/%#") | sym(b'#') * hex_char()).repeat(0..)
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `none_of(b" \t\n\r\x0C()<>[]{}/%#") | (sym(b'#') * hex_char())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:100:11
[INFO] [stderr]     |
[INFO] [stderr] 100 |           ( (one_of(b"0123456789") - one_of(b"0123456789").repeat(0..).discard())
[INFO] [stderr]     |  ___________^
[INFO] [stderr] 101 | |             | (one_of(b"0123456789").repeat(1..) * sym(b'.') - one_of(b"0123456789").repeat(0..))
[INFO] [stderr] 102 | |             | sym(b'.') - one_of(b"0123456789").repeat(1..)
[INFO] [stderr]     | |___________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] help: consider parenthesizing your expression
[INFO] [stderr]     |
[INFO] [stderr] 100 |         ( (one_of(b"0123456789") - one_of(b"0123456789").repeat(0..).discard())
[INFO] [stderr] 101 |             | (one_of(b"0123456789").repeat(1..) * sym(b'.') - one_of(b"0123456789").repeat(0..)) | (sym(b'.') - one_of(b"0123456789").repeat(1..))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 |     sym(b'\r') * sym(b'\n') | sym(b'\n') | sym(b'\r')
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(sym(b'\r') * sym(b'\n')) | sym(b'\n')`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]   --> src/lib.rs:90:18
[INFO] [stderr]    |
[INFO] [stderr] 90 |     sym(b'/') * (none_of(b" \t\n\r\x0C()<>[]{}/%#") | sym(b'#') * hex_char()).repeat(0..)
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `none_of(b" \t\n\r\x0C()<>[]{}/%#") | (sym(b'#') * hex_char())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:100:11
[INFO] [stderr]     |
[INFO] [stderr] 100 |           ( (one_of(b"0123456789") - one_of(b"0123456789").repeat(0..).discard())
[INFO] [stderr]     |  ___________^
[INFO] [stderr] 101 | |             | (one_of(b"0123456789").repeat(1..) * sym(b'.') - one_of(b"0123456789").repeat(0..))
[INFO] [stderr] 102 | |             | sym(b'.') - one_of(b"0123456789").repeat(1..)
[INFO] [stderr]     | |___________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] help: consider parenthesizing your expression
[INFO] [stderr]     |
[INFO] [stderr] 100 |         ( (one_of(b"0123456789") - one_of(b"0123456789").repeat(0..).discard())
[INFO] [stderr] 101 |             | (one_of(b"0123456789").repeat(1..) * sym(b'.') - one_of(b"0123456789").repeat(0..)) | (sym(b'.') - one_of(b"0123456789").repeat(1..))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/lib.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 |     sym(b'\r') * sym(b'\n') | sym(b'\n') | sym(b'\r')
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(sym(b'\r') * sym(b'\n')) | sym(b'\n')`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `count`
[INFO] [stderr]    --> src/lib.rs:178:29
[INFO] [stderr]     |
[INFO] [stderr] 178 |                         let count = if let &Value::Integer(ref c) = &lexed[i-1] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                             ^^^^^ help: consider using `_count` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:38:57
[INFO] [stderr]    |
[INFO] [stderr] 38 |     (is_a(alpha) | one_of(b"*'\"")).repeat(1..).convert(|v|String::from_utf8(v))
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:95:30
[INFO] [stderr]    |
[INFO] [stderr] 95 |     number.collect().convert(|v|String::from_utf8(v)).convert(|s|i64::from_str(&s))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:104:30
[INFO] [stderr]     |
[INFO] [stderr] 104 |     number.collect().convert(|v|String::from_utf8(v))
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:133:21
[INFO] [stderr]     |
[INFO] [stderr] 133 |     | integer().map(|v| Value::Integer(v))
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Integer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |     | number().map(|v| Value::Number(v))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:135:18
[INFO] [stderr]     |
[INFO] [stderr] 135 |     | name().map(|v| Value::Name(v))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:136:22
[INFO] [stderr]     |
[INFO] [stderr] 136 |     | operator().map(|v| Value::Operator(v))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Operator`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:137:28
[INFO] [stderr]     |
[INFO] [stderr] 137 |     | literal_string().map(|v| Value::LiteralString(v))
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::LiteralString`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:138:24
[INFO] [stderr]     |
[INFO] [stderr] 138 |     | dictionary().map(|v| Value::Dictionary(v))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Dictionary`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:139:32
[INFO] [stderr]     |
[INFO] [stderr] 139 |     | hexadecimal_string().map(|v| Value::LiteralString(v))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::LiteralString`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:140:19
[INFO] [stderr]     |
[INFO] [stderr] 140 |     | array().map(|v| Value::Array(v))
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:141:23
[INFO] [stderr]     |
[INFO] [stderr] 141 |     | procedure().map(|v| Value::Procedure(v))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Procedure`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:178:37
[INFO] [stderr]     |
[INFO] [stderr] 178 |                         let count = if let &Value::Integer(ref c) = &lexed[i-1] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 178 |                         let count = if let Value::Integer(ref c) = lexed[i-1] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:179:36
[INFO] [stderr]     |
[INFO] [stderr] 179 |                         let name = if let &Value::Name(ref n) = &lexed[i-2] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 179 |                         let name = if let Value::Name(ref n) = lexed[i-2] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:183:33
[INFO] [stderr]     |
[INFO] [stderr] 183 | /                                 match lexed[i] {
[INFO] [stderr] 184 | |                                     Value::Operator(ref o) => {
[INFO] [stderr] 185 | |                                         match o.as_ref() {
[INFO] [stderr] 186 | |                                             "put" => {
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |                                     _ => {}
[INFO] [stderr] 198 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 183 |                                 if let Value::Operator(ref o) = lexed[i] {
[INFO] [stderr] 184 |     match o.as_ref() {
[INFO] [stderr] 185 |         "put" => {
[INFO] [stderr] 186 |             let name = if let &Value::Name(ref n) = &lexed[i-1] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr] 187 |             let id = if let &Value::Integer(ref c) = &lexed[i-2] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr] 188 |             map.insert(id as u32, name.clone());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:187:60
[INFO] [stderr]     |
[INFO] [stderr] 187 |                                                 let name = if let &Value::Name(ref n) = &lexed[i-1] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 187 |                                                 let name = if let Value::Name(ref n) = lexed[i-1] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:188:58
[INFO] [stderr]     |
[INFO] [stderr] 188 |                                                 let id = if let &Value::Integer(ref c) = &lexed[i-2] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 188 |                                                 let id = if let Value::Integer(ref c) = lexed[i-2] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `count`
[INFO] [stderr]    --> src/lib.rs:178:29
[INFO] [stderr]     |
[INFO] [stderr] 178 |                         let count = if let &Value::Integer(ref c) = &lexed[i-1] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                             ^^^^^ help: consider using `_count` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:38:57
[INFO] [stderr]    |
[INFO] [stderr] 38 |     (is_a(alpha) | one_of(b"*'\"")).repeat(1..).convert(|v|String::from_utf8(v))
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:95:30
[INFO] [stderr]    |
[INFO] [stderr] 95 |     number.collect().convert(|v|String::from_utf8(v)).convert(|s|i64::from_str(&s))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:104:30
[INFO] [stderr]     |
[INFO] [stderr] 104 |     number.collect().convert(|v|String::from_utf8(v))
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from_utf8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:133:21
[INFO] [stderr]     |
[INFO] [stderr] 133 |     | integer().map(|v| Value::Integer(v))
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Integer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |     | number().map(|v| Value::Number(v))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:135:18
[INFO] [stderr]     |
[INFO] [stderr] 135 |     | name().map(|v| Value::Name(v))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:136:22
[INFO] [stderr]     |
[INFO] [stderr] 136 |     | operator().map(|v| Value::Operator(v))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Operator`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:137:28
[INFO] [stderr]     |
[INFO] [stderr] 137 |     | literal_string().map(|v| Value::LiteralString(v))
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::LiteralString`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:138:24
[INFO] [stderr]     |
[INFO] [stderr] 138 |     | dictionary().map(|v| Value::Dictionary(v))
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Dictionary`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:139:32
[INFO] [stderr]     |
[INFO] [stderr] 139 |     | hexadecimal_string().map(|v| Value::LiteralString(v))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::LiteralString`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:140:19
[INFO] [stderr]     |
[INFO] [stderr] 140 |     | array().map(|v| Value::Array(v))
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:141:23
[INFO] [stderr]     |
[INFO] [stderr] 141 |     | procedure().map(|v| Value::Procedure(v))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Procedure`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:178:37
[INFO] [stderr]     |
[INFO] [stderr] 178 |                         let count = if let &Value::Integer(ref c) = &lexed[i-1] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 178 |                         let count = if let Value::Integer(ref c) = lexed[i-1] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:179:36
[INFO] [stderr]     |
[INFO] [stderr] 179 |                         let name = if let &Value::Name(ref n) = &lexed[i-2] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 179 |                         let name = if let Value::Name(ref n) = lexed[i-2] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:183:33
[INFO] [stderr]     |
[INFO] [stderr] 183 | /                                 match lexed[i] {
[INFO] [stderr] 184 | |                                     Value::Operator(ref o) => {
[INFO] [stderr] 185 | |                                         match o.as_ref() {
[INFO] [stderr] 186 | |                                             "put" => {
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |                                     _ => {}
[INFO] [stderr] 198 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 183 |                                 if let Value::Operator(ref o) = lexed[i] {
[INFO] [stderr] 184 |     match o.as_ref() {
[INFO] [stderr] 185 |         "put" => {
[INFO] [stderr] 186 |             let name = if let &Value::Name(ref n) = &lexed[i-1] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr] 187 |             let id = if let &Value::Integer(ref c) = &lexed[i-2] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr] 188 |             map.insert(id as u32, name.clone());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:187:60
[INFO] [stderr]     |
[INFO] [stderr] 187 |                                                 let name = if let &Value::Name(ref n) = &lexed[i-1] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 187 |                                                 let name = if let Value::Name(ref n) = lexed[i-1] { Ok(n) } else { Err("expected name") }?;
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:188:58
[INFO] [stderr]     |
[INFO] [stderr] 188 |                                                 let id = if let &Value::Integer(ref c) = &lexed[i-2] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 188 |                                                 let id = if let Value::Integer(ref c) = lexed[i-2] { Ok(*c) } else { Err("array expected int") }?;
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/lib.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |         f.read_to_end(&mut contents);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::path::Path`
[INFO] [stderr]  --> examples/dump.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::path::Path;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> examples/dump.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     f.read_to_end(&mut contents);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.28s
[INFO] running `"docker" "inspect" "543f2dbf21249147591a68026e00ccb4ace1fcb6ee3790e88c532220fb5e8f66"`
[INFO] running `"docker" "rm" "-f" "543f2dbf21249147591a68026e00ccb4ace1fcb6ee3790e88c532220fb5e8f66"`
[INFO] [stdout] 543f2dbf21249147591a68026e00ccb4ace1fcb6ee3790e88c532220fb5e8f66