[INFO] crate txtdist 0.2.1 is already in cache [INFO] extracting crate txtdist 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/txtdist/0.2.1 [INFO] extracting crate txtdist 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/txtdist/0.2.1 [INFO] validating manifest of txtdist-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of txtdist-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing txtdist-0.2.1 [INFO] finished frobbing txtdist-0.2.1 [INFO] frobbed toml for txtdist-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/txtdist/0.2.1/Cargo.toml [INFO] started frobbing txtdist-0.2.1 [INFO] finished frobbing txtdist-0.2.1 [INFO] frobbed toml for txtdist-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/txtdist/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting txtdist-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/txtdist/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b3ed188adfb480da7b8f9cde7045bb799888a909bc5012ca6fb47e9eab8d311d [INFO] running `"docker" "start" "-a" "b3ed188adfb480da7b8f9cde7045bb799888a909bc5012ca6fb47e9eab8d311d"` [INFO] [stderr] Checking txtdist v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / fn index<'a>(&'a self, (x, y): (usize, usize)) -> &'a T { [INFO] [stderr] 29 | | &self.buf[(x * self.y_size) + y] [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / fn index_mut<'a>(&'a mut self, (x, y): (usize, usize)) -> &'a mut T { [INFO] [stderr] 36 | | &mut self.buf[(x * self.y_size) + y] [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 1..n+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 1..m+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:117:14 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 0..n+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | for j in 0..m+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | last_row.insert(char_s.clone(), row); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `char_s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / fn index<'a>(&'a self, (x, y): (usize, usize)) -> &'a T { [INFO] [stderr] 29 | | &self.buf[(x * self.y_size) + y] [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / fn index_mut<'a>(&'a mut self, (x, y): (usize, usize)) -> &'a mut T { [INFO] [stderr] 36 | | &mut self.buf[(x * self.y_size) + y] [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 1..n+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 1..m+1 { [INFO] [stderr] | ^^^^^^ help: use: `1..=m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:117:14 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 0..n+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:121:14 [INFO] [stderr] | [INFO] [stderr] 121 | for j in 0..m+1 { [INFO] [stderr] | ^^^^^^ help: use: `0..=m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | last_row.insert(char_s.clone(), row); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `char_s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "b3ed188adfb480da7b8f9cde7045bb799888a909bc5012ca6fb47e9eab8d311d"` [INFO] running `"docker" "rm" "-f" "b3ed188adfb480da7b8f9cde7045bb799888a909bc5012ca6fb47e9eab8d311d"` [INFO] [stdout] b3ed188adfb480da7b8f9cde7045bb799888a909bc5012ca6fb47e9eab8d311d