[INFO] crate txdo 0.1.0 is already in cache [INFO] extracting crate txdo 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/txdo/0.1.0 [INFO] extracting crate txdo 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/txdo/0.1.0 [INFO] validating manifest of txdo-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of txdo-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing txdo-0.1.0 [INFO] finished frobbing txdo-0.1.0 [INFO] frobbed toml for txdo-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/txdo/0.1.0/Cargo.toml [INFO] started frobbing txdo-0.1.0 [INFO] finished frobbing txdo-0.1.0 [INFO] frobbed toml for txdo-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/txdo/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting txdo-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/txdo/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc3004a1cad557b1c553d7d799f7d011891f20520fa17167ba1b66eebf44d5cc [INFO] running `"docker" "start" "-a" "dc3004a1cad557b1c553d7d799f7d011891f20520fa17167ba1b66eebf44d5cc"` [INFO] [stderr] Checking txdo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:41 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'x' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:69 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | && buffer[0] == ('(' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'(' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | && buffer[2] == (')' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b')' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | && buffer[3] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | char == ('-' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | && buffer[DATE_LENGTH] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | let (date2, buffer) = match completed { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 21 | | true => matchers::parse_date(buffer), [INFO] [stderr] 22 | | false => (None, buffer), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { matchers::parse_date(buffer) } else { (None, buffer) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let completed_at = match completed { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | true => date1, [INFO] [stderr] 27 | | false => None, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date1 } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | let created_at = match completed { [INFO] [stderr] | __________________________^ [INFO] [stderr] 31 | | true => date2, [INFO] [stderr] 32 | | false => date1, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date2 } else { date1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:41 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'x' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:2:69 [INFO] [stderr] | [INFO] [stderr] 2 | if buffer.len() > 1 && buffer[0] == ('x' as u8) && buffer[1] == (' ' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | && buffer[0] == ('(' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'(' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | && buffer[2] == (')' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b')' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | && buffer[3] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | char == ('-' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | && buffer[DATE_LENGTH] == (' ' as u8) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"x "` [INFO] [stderr] ... [INFO] [stderr] 66 | assert_eq!(parse_completed(input!("x ")).0, true); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"x"` [INFO] [stderr] ... [INFO] [stderr] 69 | assert_eq!(parse_completed(input!("x")).0, false); [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xylophone"` [INFO] [stderr] ... [INFO] [stderr] 70 | assert_eq!(parse_completed(input!("xylophone")).0, false); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" x"` [INFO] [stderr] ... [INFO] [stderr] 72 | assert_eq!(parse_completed(input!(" x")).0, false); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"X "` [INFO] [stderr] ... [INFO] [stderr] 74 | assert_eq!(parse_completed(input!("X ")).0, false); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(A) "` [INFO] [stderr] ... [INFO] [stderr] 79 | assert_eq!(parse_priority(input!("(A) ")).0, Some('A' as u8)); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:79:59 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(parse_priority(input!("(A) ")).0, Some('A' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(X) "` [INFO] [stderr] ... [INFO] [stderr] 80 | assert_eq!(parse_priority(input!("(X) ")).0, Some('X' as u8)); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/matchers.rs:80:59 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(parse_priority(input!("(X) ")).0, Some('X' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"(c) "` [INFO] [stderr] ... [INFO] [stderr] 83 | assert_eq!(parse_priority(input!("(c) ")).0, None); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" (c)"` [INFO] [stderr] ... [INFO] [stderr] 85 | assert_eq!(parse_priority(input!(" (c)")).0, None); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" (O).(o)"` [INFO] [stderr] ... [INFO] [stderr] 86 | assert_eq!(parse_priority(input!(" (O).(o)")).0, None); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01 "` [INFO] [stderr] ... [INFO] [stderr] 95 | parse_date(input!("2018-01-01 ")).0.map(coerce_to_string), [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01"` [INFO] [stderr] ... [INFO] [stderr] 104 | parse_date(input!("2018-01-01")).0.map(coerce_to_string), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"18-01-01 "` [INFO] [stderr] ... [INFO] [stderr] 110 | parse_date(input!("18-01-01 ")).0.map(coerce_to_string), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-1-01 "` [INFO] [stderr] ... [INFO] [stderr] 114 | parse_date(input!("2018-1-01 ")).0.map(coerce_to_string), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-1 "` [INFO] [stderr] ... [INFO] [stderr] 118 | parse_date(input!("2018-01-1 ")).0.map(coerce_to_string), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/matchers.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | $val.as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018_01_01 "` [INFO] [stderr] ... [INFO] [stderr] 124 | parse_date(input!("2018_01_01 ")).0.map(coerce_to_string), [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | let (date2, buffer) = match completed { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 21 | | true => matchers::parse_date(buffer), [INFO] [stderr] 22 | | false => (None, buffer), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { matchers::parse_date(buffer) } else { (None, buffer) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let completed_at = match completed { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | true => date1, [INFO] [stderr] 27 | | false => None, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date1 } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | let created_at = match completed { [INFO] [stderr] | __________________________^ [INFO] [stderr] 31 | | true => date2, [INFO] [stderr] 32 | | false => date1, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if completed { date2 } else { date1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:64:36 [INFO] [stderr] | [INFO] [stderr] 64 | let expected_date: &[u8] = "2018-01-01".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:74:46 [INFO] [stderr] | [INFO] [stderr] 74 | let expected_completed_date: &[u8] = "2018-01-01".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-01-01"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | let expected_created_date: &[u8] = "2018-12-31".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2018-12-31"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "dc3004a1cad557b1c553d7d799f7d011891f20520fa17167ba1b66eebf44d5cc"` [INFO] running `"docker" "rm" "-f" "dc3004a1cad557b1c553d7d799f7d011891f20520fa17167ba1b66eebf44d5cc"` [INFO] [stdout] dc3004a1cad557b1c553d7d799f7d011891f20520fa17167ba1b66eebf44d5cc