[INFO] crate tsz 0.1.0 is already in cache [INFO] extracting crate tsz 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tsz/0.1.0 [INFO] extracting crate tsz 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsz/0.1.0 [INFO] validating manifest of tsz-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsz-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsz-0.1.0 [INFO] finished frobbing tsz-0.1.0 [INFO] frobbed toml for tsz-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tsz/0.1.0/Cargo.toml [INFO] started frobbing tsz-0.1.0 [INFO] finished frobbing tsz-0.1.0 [INFO] frobbed toml for tsz-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsz/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsz-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsz/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0d5987ed65b4ce8c253fa84c83c6553216efab5c5fb69eb533fa9d1ea642488 [INFO] running `"docker" "start" "-a" "f0d5987ed65b4ce8c253fa84c83c6553216efab5c5fb69eb533fa9d1ea642488"` [INFO] [stderr] Checking tsz v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode/std_encoder.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/std_decoder.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode/std_encoder.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/std_decoder.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/stream/mod.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | fn read_bits(&mut self, mut num: u32) -> Result; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stream/buffered_write.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return self.buf.into_boxed_slice(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buf.into_boxed_slice()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | pub const END_MARKER: u64 = 0b111100000000000000000000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0000_0000_0000_0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn to_u64(self) -> u64 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stream::buffered_write::BufferedWriter` [INFO] [stderr] --> src/stream/buffered_write.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | BufferedWriter { [INFO] [stderr] 19 | | buf: Vec::new(), [INFO] [stderr] 20 | | // set pos to 8 to indicate the buffer has no space presently since it is empty [INFO] [stderr] 21 | | pos: 8, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/stream/buffered_read.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | self.bytes.get(self.index).map(|byte| *byte).ok_or(Error::EOF) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.bytes.get(self.index).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/buffered_read.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | byte = byte | (b.wrapping_shl(self.pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `byte |= (b.wrapping_shl(self.pos))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/buffered_read.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | byte = byte | (b.wrapping_shr(8 - self.pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `byte |= (b.wrapping_shr(8 - self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream/buffered_read.rs:83:52 [INFO] [stderr] | [INFO] [stderr] 83 | let byte = self.read_byte().map(|byte| byte as u64)?; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/encode/std_encoder.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | 0 => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/encode/std_encoder.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | -63...64 => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode/std_encoder.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | self.w.write_bits(leading_zeroes as u64, 6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(leading_zeroes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode/std_encoder.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | self.w.write_bits((significant_digits - 1) as u64, 6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(significant_digits - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode/std_decoder.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | dod = dod | mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dod |= mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decode/std_decoder.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / let value_bits; [INFO] [stderr] 178 | | [INFO] [stderr] 179 | | if self.first { [INFO] [stderr] 180 | | self.first = false; [INFO] [stderr] ... | [INFO] [stderr] 197 | | value_bits = self.read_next_value()?; [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let value_bits = if self.first { ..; self.read_first_value()? } else { ..; self.read_next_value()? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/decode/std_decoder.rs:200:30 [INFO] [stderr] | [INFO] [stderr] 200 | let value = unsafe { mem::transmute::(value_bits) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(value_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/stream/mod.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | fn read_bits(&mut self, mut num: u32) -> Result; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stream/buffered_write.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return self.buf.into_boxed_slice(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buf.into_boxed_slice()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_write.rs:177:22 [INFO] [stderr] | [INFO] [stderr] 177 | b.write_byte(0b11110000); // 1111 1111 0000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_write.rs:178:22 [INFO] [stderr] | [INFO] [stderr] 178 | b.write_byte(0b00001111); // 1111 1111 0000 0000 1111 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_write.rs:179:22 [INFO] [stderr] | [INFO] [stderr] 179 | b.write_byte(0b00001111); // 1111 1111 0000 0000 1111 0000 1111 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_write.rs:201:22 [INFO] [stderr] | [INFO] [stderr] 201 | b.write_bits(708157, 20); [INFO] [stderr] | ^^^^^^ help: consider: `708_157` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | let bytes = vec![0b01101100, 0b11101001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:119:38 [INFO] [stderr] | [INFO] [stderr] 119 | let bytes = vec![0b01101100, 0b11101001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:166:26 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:166:38 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:166:50 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:166:62 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:171:46 [INFO] [stderr] | [INFO] [stderr] 171 | assert_eq!(b.read_bits(20).unwrap(), 0b01110001110111110101); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0111_0001_1101_1111_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:172:45 [INFO] [stderr] | [INFO] [stderr] 172 | assert_eq!(b.read_bits(8).unwrap(), 0b00010100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | let bytes = vec![0b01101101, 0b01101101]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:178:38 [INFO] [stderr] | [INFO] [stderr] 178 | let bytes = vec![0b01101101, 0b01101101]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:183:44 [INFO] [stderr] | [INFO] [stderr] 183 | assert_eq!(b.read_byte().unwrap(), 0b11010110); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:192:50 [INFO] [stderr] | [INFO] [stderr] 192 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:192:62 [INFO] [stderr] | [INFO] [stderr] 192 | let bytes = vec![0b01010111, 0b00011101, 0b11110101, 0b00010100]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:197:45 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(b.peak_bits(8).unwrap(), 0b01010111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:198:46 [INFO] [stderr] | [INFO] [stderr] 198 | assert_eq!(b.peak_bits(20).unwrap(), 0b01010111000111011111); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0111_0001_1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:202:46 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(b.read_bits(12).unwrap(), 0b010101110001); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b0101_0111_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:206:45 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(b.peak_bits(8).unwrap(), 0b11011111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stream/buffered_read.rs:207:46 [INFO] [stderr] | [INFO] [stderr] 207 | assert_eq!(b.peak_bits(20).unwrap(), 0b11011111010100010100); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1101_1111_0101_0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | pub const END_MARKER: u64 = 0b111100000000000000000000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0000_0000_0000_0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | let start_time = 1482268055; // 2016-12-20T21:07:35+00:00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:199:26 [INFO] [stderr] | [INFO] [stderr] 199 | let start_time = 1482268055; // 2016-12-20T21:07:35+00:00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:202:33 [INFO] [stderr] | [INFO] [stderr] 202 | let d1 = DataPoint::new(1482268055 + 10, 1.24); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:216:26 [INFO] [stderr] | [INFO] [stderr] 216 | let start_time = 1482268055; // 2016-12-20T21:07:35+00:00 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | let d1 = DataPoint::new(1482268055 + 10, 1.24); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | let d2 = DataPoint::new(1482268055 + 20, 1.98); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | let d3 = DataPoint::new(1482268055 + 32, 2.37); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:226:33 [INFO] [stderr] | [INFO] [stderr] 226 | let d4 = DataPoint::new(1482268055 + 44, -7.41); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/std_encoder.rs:227:33 [INFO] [stderr] | [INFO] [stderr] 227 | let d5 = DataPoint::new(1482268055 + 52, 103.50); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/std_decoder.rs:229:49 [INFO] [stderr] | [INFO] [stderr] 229 | let expected_datapoint = DataPoint::new(1482268055 + 10, 1.24); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/std_decoder.rs:244:55 [INFO] [stderr] | [INFO] [stderr] 244 | let first_expected_datapoint = DataPoint::new(1482268055 + 10, 1.24); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/std_decoder.rs:245:56 [INFO] [stderr] | [INFO] [stderr] 245 | let second_expected_datapoint = DataPoint::new(1482268055 + 20, 1.98); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/std_decoder.rs:246:55 [INFO] [stderr] | [INFO] [stderr] 246 | let third_expected_datapoint = DataPoint::new(1482268055 + 32, 2.37); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/std_decoder.rs:247:56 [INFO] [stderr] | [INFO] [stderr] 247 | let fourth_expected_datapoint = DataPoint::new(1482268055 + 44, -7.41); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/std_decoder.rs:248:55 [INFO] [stderr] | [INFO] [stderr] 248 | let fifth_expected_datapoint = DataPoint::new(1482268055 + 52, 103.50); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_268_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | const DATA: &'static str = "1482892270,1.76 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:190:43 [INFO] [stderr] | [INFO] [stderr] 190 | let mut encoder = StdEncoder::new(1482892260, w); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_482_892_260` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn to_u64(self) -> u64 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stream::buffered_write::BufferedWriter` [INFO] [stderr] --> src/stream/buffered_write.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | BufferedWriter { [INFO] [stderr] 19 | | buf: Vec::new(), [INFO] [stderr] 20 | | // set pos to 8 to indicate the buffer has no space presently since it is empty [INFO] [stderr] 21 | | pos: 8, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/stream/buffered_read.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | self.bytes.get(self.index).map(|byte| *byte).ok_or(Error::EOF) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.bytes.get(self.index).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/buffered_read.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | byte = byte | (b.wrapping_shl(self.pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `byte |= (b.wrapping_shl(self.pos))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/stream/buffered_read.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | byte = byte | (b.wrapping_shr(8 - self.pos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `byte |= (b.wrapping_shr(8 - self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/stream/buffered_read.rs:83:52 [INFO] [stderr] | [INFO] [stderr] 83 | let byte = self.read_byte().map(|byte| byte as u64)?; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/encode/std_encoder.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | 0 => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/encode/std_encoder.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | -63...64 => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode/std_encoder.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | self.w.write_bits(leading_zeroes as u64, 6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(leading_zeroes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode/std_encoder.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | self.w.write_bits((significant_digits - 1) as u64, 6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(significant_digits - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decode/std_decoder.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | dod = dod | mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dod |= mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode/std_decoder.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | .map_err(|err| Error::Stream(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decode/std_decoder.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / let value_bits; [INFO] [stderr] 178 | | [INFO] [stderr] 179 | | if self.first { [INFO] [stderr] 180 | | self.first = false; [INFO] [stderr] ... | [INFO] [stderr] 197 | | value_bits = self.read_next_value()?; [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let value_bits = if self.first { ..; self.read_first_value()? } else { ..; self.read_next_value()? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/decode/std_decoder.rs:200:30 [INFO] [stderr] | [INFO] [stderr] 200 | let value = unsafe { mem::transmute::(value_bits) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(value_bits)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:195:52 [INFO] [stderr] | [INFO] [stderr] 195 | let substrings: Vec<&str> = line.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "f0d5987ed65b4ce8c253fa84c83c6553216efab5c5fb69eb533fa9d1ea642488"` [INFO] running `"docker" "rm" "-f" "f0d5987ed65b4ce8c253fa84c83c6553216efab5c5fb69eb533fa9d1ea642488"` [INFO] [stdout] f0d5987ed65b4ce8c253fa84c83c6553216efab5c5fb69eb533fa9d1ea642488