[INFO] crate trove 1.0.1 is already in cache [INFO] extracting crate trove 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/trove/1.0.1 [INFO] extracting crate trove 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trove/1.0.1 [INFO] validating manifest of trove-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trove-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trove-1.0.1 [INFO] finished frobbing trove-1.0.1 [INFO] frobbed toml for trove-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/trove/1.0.1/Cargo.toml [INFO] started frobbing trove-1.0.1 [INFO] finished frobbing trove-1.0.1 [INFO] frobbed toml for trove-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trove/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trove-1.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trove/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1fdf7a7e203d78c43bf5287bed608ddf0d73bb66ec159262f5ac071b70c14d9 [INFO] running `"docker" "start" "-a" "b1fdf7a7e203d78c43bf5287bed608ddf0d73bb66ec159262f5ac071b70c14d9"` [INFO] [stderr] Checking trove v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `mut_from_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #![allow(mut_from_ref)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mut_from_ref` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_from_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #![allow(mut_from_ref)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mut_from_ref` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_from_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #![allow(mut_from_ref)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mut_from_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_from_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #![allow(mut_from_ref)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::mut_from_ref` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:142:56 [INFO] [stderr] | [INFO] [stderr] 142 | let from_a = arenas_a.iter().map(|(k, v)| (k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:143:56 [INFO] [stderr] | [INFO] [stderr] 143 | let from_b = arenas_b.iter().map(|(k, v)| (k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:196:26 [INFO] [stderr] | [INFO] [stderr] 196 | .map_err(|e| Either::Left(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Either::Left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:199:51 [INFO] [stderr] | [INFO] [stderr] 199 | (*self.try_get(arena_idx).map_err(|e| Either::Right(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Either::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `try_get` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:346:35 [INFO] [stderr] | [INFO] [stderr] 346 | let ref_c = arena.try_get(&mut a); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | let c = b.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:142:56 [INFO] [stderr] | [INFO] [stderr] 142 | let from_a = arenas_a.iter().map(|(k, v)| (k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:143:56 [INFO] [stderr] | [INFO] [stderr] 143 | let from_b = arenas_b.iter().map(|(k, v)| (k.clone(), v.clone())); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:196:26 [INFO] [stderr] | [INFO] [stderr] 196 | .map_err(|e| Either::Left(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Either::Left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:199:51 [INFO] [stderr] | [INFO] [stderr] 199 | (*self.try_get(arena_idx).map_err(|e| Either::Right(e))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Either::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "b1fdf7a7e203d78c43bf5287bed608ddf0d73bb66ec159262f5ac071b70c14d9"` [INFO] running `"docker" "rm" "-f" "b1fdf7a7e203d78c43bf5287bed608ddf0d73bb66ec159262f5ac071b70c14d9"` [INFO] [stdout] b1fdf7a7e203d78c43bf5287bed608ddf0d73bb66ec159262f5ac071b70c14d9