[INFO] crate trees 0.2.1 is already in cache
[INFO] extracting crate trees 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/trees/0.2.1
[INFO] extracting crate trees 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trees/0.2.1
[INFO] validating manifest of trees-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of trees-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing trees-0.2.1
[INFO] finished frobbing trees-0.2.1
[INFO] frobbed toml for trees-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/trees/0.2.1/Cargo.toml
[INFO] started frobbing trees-0.2.1
[INFO] finished frobbing trees-0.2.1
[INFO] frobbed toml for trees-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trees/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting trees-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trees/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 856f2c6e9f93c639caad400981b0938330c4b483927e5200dc76c16c36582f5c
[INFO] running `"docker" "start" "-a" "856f2c6e9f93c639caad400981b0938330c4b483927e5200dc76c16c36582f5c"`
[INFO] [stderr]     Checking indexed v0.1.1
[INFO] [stderr]     Checking trees v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bfs.rs:25:57
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Self{ iter: Splitted::<Iter>::from( treelike ), size: size }
[INFO] [stderr]    |                                                         ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bfs.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Self{ iter: Splitted::<Iter>::from( treelike ), size: size }
[INFO] [stderr]    |                                                         ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bfs.rs:25:57
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Self{ iter: Splitted::<Iter>::from( treelike ), size: size }
[INFO] [stderr]    |                                                         ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bfs.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |         Self{ iter: Splitted::<Iter>::from( treelike ), size: size }
[INFO] [stderr]    |                                                         ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/linked/singly/walk.rs:225:9
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return self.get();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/linked/fully/walk.rs:225:9
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return self.get();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/potted/pot.rs:77:17
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 return Some( index + nth );
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some( index + nth )`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/potted/pot.rs:90:28
[INFO] [stderr]    |
[INFO] [stderr] 90 |                       } else {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 91 | |                         if nth == 0 {
[INFO] [stderr] 92 | |                             return Some( index );
[INFO] [stderr] 93 | |                         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |                         }
[INFO] [stderr] 97 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 90 |                     } else if nth == 0 {
[INFO] [stderr] 91 |     return Some( index );
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |     nth -= 1;
[INFO] [stderr] 94 |     index = self.next( index );
[INFO] [stderr] 95 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/linked/singly/walk.rs:225:9
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return self.get();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/linked/fully/walk.rs:225:9
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return self.get();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/potted/pot.rs:77:17
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 return Some( index + nth );
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some( index + nth )`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/potted/pot.rs:90:28
[INFO] [stderr]    |
[INFO] [stderr] 90 |                       } else {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 91 | |                         if nth == 0 {
[INFO] [stderr] 92 | |                             return Some( index );
[INFO] [stderr] 93 | |                         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |                         }
[INFO] [stderr] 97 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 90 |                     } else if nth == 0 {
[INFO] [stderr] 91 |     return Some( index );
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |     nth -= 1;
[INFO] [stderr] 94 |     index = self.next( index );
[INFO] [stderr] 95 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/singly/tree.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     fn ne( &self, other: &Self ) -> bool { self.root().ne( other.root() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/linked/singly/forest.rs:425:34
[INFO] [stderr]     |
[INFO] [stderr] 425 |         while let Some( node ) = iter.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^ help: try: `for node in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/singly/forest.rs:469:5
[INFO] [stderr]     |
[INFO] [stderr] 469 |     fn ne( &self, other: &Self ) -> bool { self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/singly/node.rs:451:5
[INFO] [stderr]     |
[INFO] [stderr] 451 |     fn ne( &self, other: &Self ) -> bool { self.data != other.data || self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/linked/singly/walk.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 | /             match self.visit_type {
[INFO] [stderr] 97 | |                 VisitType::None => self.path.push( Nodes::sibs( self.origin )),
[INFO] [stderr] 98 | |                 _ => (),
[INFO] [stderr] 99 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let VisitType::None = self.visit_type { self.path.push( Nodes::sibs( self.origin )) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/singly/walk.rs:149:21
[INFO] [stderr]     |
[INFO] [stderr] 149 |                     new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:182:29
[INFO] [stderr]     |
[INFO] [stderr] 182 |     #[inline] fn to_parent( &mut self ) -> Option<Visit<T>> {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:207:26
[INFO] [stderr]     |
[INFO] [stderr] 207 |     #[inline] fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:230:28
[INFO] [stderr]     |
[INFO] [stderr] 230 |     #[inline] fn to_child( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                            ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/singly/walk.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 |         new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:327:15
[INFO] [stderr]     |
[INFO] [stderr] 327 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:342:33
[INFO] [stderr]     |
[INFO] [stderr] 342 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:373:32
[INFO] [stderr]     |
[INFO] [stderr] 373 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:388:30
[INFO] [stderr]     |
[INFO] [stderr] 388 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:517:15
[INFO] [stderr]     |
[INFO] [stderr] 517 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:532:33
[INFO] [stderr]     |
[INFO] [stderr] 532 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:563:32
[INFO] [stderr]     |
[INFO] [stderr] 563 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:578:30
[INFO] [stderr]     |
[INFO] [stderr] 578 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/fully/tree.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     fn ne( &self, other: &Self ) -> bool { self.root().ne( other.root() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/linked/fully/forest.rs:526:34
[INFO] [stderr]     |
[INFO] [stderr] 526 |         while let Some( node ) = iter.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^ help: try: `for node in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/fully/forest.rs:570:5
[INFO] [stderr]     |
[INFO] [stderr] 570 |     fn ne( &self, other: &Self ) -> bool { self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/fully/node.rs:576:5
[INFO] [stderr]     |
[INFO] [stderr] 576 |     fn ne( &self, other: &Self ) -> bool { self.data != other.data || self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/linked/fully/walk.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 | /             match self.visit_type {
[INFO] [stderr] 97 | |                 VisitType::None => self.path.push( Nodes::sibs( self.origin )),
[INFO] [stderr] 98 | |                 _ => (),
[INFO] [stderr] 99 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let VisitType::None = self.visit_type { self.path.push( Nodes::sibs( self.origin )) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/fully/walk.rs:149:21
[INFO] [stderr]     |
[INFO] [stderr] 149 |                     new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:182:29
[INFO] [stderr]     |
[INFO] [stderr] 182 |     #[inline] fn to_parent( &mut self ) -> Option<Visit<T>> {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:207:26
[INFO] [stderr]     |
[INFO] [stderr] 207 |     #[inline] fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:230:28
[INFO] [stderr]     |
[INFO] [stderr] 230 |     #[inline] fn to_child( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                            ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/fully/walk.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 |         new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:327:15
[INFO] [stderr]     |
[INFO] [stderr] 327 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:342:33
[INFO] [stderr]     |
[INFO] [stderr] 342 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:373:32
[INFO] [stderr]     |
[INFO] [stderr] 373 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:388:30
[INFO] [stderr]     |
[INFO] [stderr] 388 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:517:15
[INFO] [stderr]     |
[INFO] [stderr] 517 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:532:33
[INFO] [stderr]     |
[INFO] [stderr] 532 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:563:32
[INFO] [stderr]     |
[INFO] [stderr] 563 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:578:30
[INFO] [stderr]     |
[INFO] [stderr] 578 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/potted/tree.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     fn ne( &self, other: &Self ) -> bool { self.root().ne( other.root() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/potted/forest.rs:505:5
[INFO] [stderr]     |
[INFO] [stderr] 505 |     fn ne( &self, other: &Self ) -> bool { self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/potted/node.rs:585:35
[INFO] [stderr]     |
[INFO] [stderr] 585 |         while let Some( visit ) = iter.next() {
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: try: `for visit in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/singly/tree.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     fn ne( &self, other: &Self ) -> bool { self.root().ne( other.root() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/potted/node.rs:662:5
[INFO] [stderr]     |
[INFO] [stderr] 662 |     fn ne( &self, other: &Self ) -> bool { self.data != other.data || self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/linked/singly/forest.rs:425:34
[INFO] [stderr]     |
[INFO] [stderr] 425 |         while let Some( node ) = iter.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^ help: try: `for node in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/singly/forest.rs:469:5
[INFO] [stderr]     |
[INFO] [stderr] 469 |     fn ne( &self, other: &Self ) -> bool { self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/potted/pot.rs:71:40
[INFO] [stderr]    |
[INFO] [stderr] 71 |     #[inline] pub(crate) fn nth_child( &self, mut index: usize, mut nth: usize ) -> Option<usize> {
[INFO] [stderr]    |                                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:106:35
[INFO] [stderr]     |
[INFO] [stderr] 106 |     #[inline] pub(crate) fn prev( &self, index: usize ) -> usize { self[ index ].prev as usize }
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:107:35
[INFO] [stderr]     |
[INFO] [stderr] 107 |     #[inline] pub(crate) fn next( &self, index: usize ) -> usize { self[ index ].next as usize }
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:112:29
[INFO] [stderr]     |
[INFO] [stderr] 112 |     pub(crate) fn prev_sib( &self, index: usize ) -> usize {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:128:29
[INFO] [stderr]     |
[INFO] [stderr] 128 |     pub(crate) fn next_sib( &self, index: usize ) -> usize {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:141:44
[INFO] [stderr]     |
[INFO] [stderr] 141 |     #[inline] pub(crate) fn is_forest_pot( &self ) -> bool { self.is_forest( NULL )}
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:145:39
[INFO] [stderr]     |
[INFO] [stderr] 145 |     #[inline] pub(crate) fn adjoined( &self, index: usize )-> usize { self[ index ].adjoined as usize }
[INFO] [stderr]     |                                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:147:37
[INFO] [stderr]     |
[INFO] [stderr] 147 |     #[inline] pub(crate) fn degree( &self, index: usize ) -> usize { self[ index ].size.degree as usize }
[INFO] [stderr]     |                                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:149:39
[INFO] [stderr]     |
[INFO] [stderr] 149 |     #[inline] pub(crate) fn node_cnt( &self, index: usize ) -> usize { self[ index ].size.node_cnt as usize }
[INFO] [stderr]     |                                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:151:38
[INFO] [stderr]     |
[INFO] [stderr] 151 |     #[inline] pub(crate) fn is_leaf( &self, index: usize ) -> bool { self[ index ].child.is_null() }
[INFO] [stderr]     |                                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:153:40
[INFO] [stderr]     |
[INFO] [stderr] 153 |     #[inline] pub(crate) fn is_forest( &self, index: usize ) -> bool { self[ index ].is_forest() }
[INFO] [stderr]     |                                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:155:37
[INFO] [stderr]     |
[INFO] [stderr] 155 |     #[inline] pub(crate) fn parent( &self, index: usize ) -> usize { self[ index ].parent as usize }
[INFO] [stderr]     |                                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/singly/node.rs:451:5
[INFO] [stderr]     |
[INFO] [stderr] 451 |     fn ne( &self, other: &Self ) -> bool { self.data != other.data || self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:161:35
[INFO] [stderr]     |
[INFO] [stderr] 161 |     #[inline] pub(crate) fn tail( &self, index: usize ) -> usize { self[ index ].child() }
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:163:35
[INFO] [stderr]     |
[INFO] [stderr] 163 |     #[inline] pub(crate) fn head( &self, index: usize ) -> usize {
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:171:46
[INFO] [stderr]     |
[INFO] [stderr] 171 |     #[inline] pub(crate) unsafe fn new_tail( &self, index: usize ) -> usize {
[INFO] [stderr]     |                                              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/linked/singly/walk.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 | /             match self.visit_type {
[INFO] [stderr] 97 | |                 VisitType::None => self.path.push( Nodes::sibs( self.origin )),
[INFO] [stderr] 98 | |                 _ => (),
[INFO] [stderr] 99 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let VisitType::None = self.visit_type { self.path.push( Nodes::sibs( self.origin )) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/singly/walk.rs:149:21
[INFO] [stderr]     |
[INFO] [stderr] 149 |                     new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:182:29
[INFO] [stderr]     |
[INFO] [stderr] 182 |     #[inline] fn to_parent( &mut self ) -> Option<Visit<T>> {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:207:26
[INFO] [stderr]     |
[INFO] [stderr] 207 |     #[inline] fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:230:28
[INFO] [stderr]     |
[INFO] [stderr] 230 |     #[inline] fn to_child( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                            ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/singly/walk.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 |         new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:327:15
[INFO] [stderr]     |
[INFO] [stderr] 327 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:342:33
[INFO] [stderr]     |
[INFO] [stderr] 342 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:373:32
[INFO] [stderr]     |
[INFO] [stderr] 373 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:388:30
[INFO] [stderr]     |
[INFO] [stderr] 388 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:517:15
[INFO] [stderr]     |
[INFO] [stderr] 517 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:532:33
[INFO] [stderr]     |
[INFO] [stderr] 532 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:563:32
[INFO] [stderr]     |
[INFO] [stderr] 563 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/singly/walk.rs:578:30
[INFO] [stderr]     |
[INFO] [stderr] 578 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/fully/tree.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     fn ne( &self, other: &Self ) -> bool { self.root().ne( other.root() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/linked/fully/forest.rs:526:34
[INFO] [stderr]     |
[INFO] [stderr] 526 |         while let Some( node ) = iter.next() {
[INFO] [stderr]     |                                  ^^^^^^^^^^^ help: try: `for node in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/fully/forest.rs:570:5
[INFO] [stderr]     |
[INFO] [stderr] 570 |     fn ne( &self, other: &Self ) -> bool { self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/linked/fully/node.rs:576:5
[INFO] [stderr]     |
[INFO] [stderr] 576 |     fn ne( &self, other: &Self ) -> bool { self.data != other.data || self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/linked/fully/walk.rs:96:13
[INFO] [stderr]    |
[INFO] [stderr] 96 | /             match self.visit_type {
[INFO] [stderr] 97 | |                 VisitType::None => self.path.push( Nodes::sibs( self.origin )),
[INFO] [stderr] 98 | |                 _ => (),
[INFO] [stderr] 99 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let VisitType::None = self.visit_type { self.path.push( Nodes::sibs( self.origin )) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/fully/walk.rs:149:21
[INFO] [stderr]     |
[INFO] [stderr] 149 |                     new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:182:29
[INFO] [stderr]     |
[INFO] [stderr] 182 |     #[inline] fn to_parent( &mut self ) -> Option<Visit<T>> {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:207:26
[INFO] [stderr]     |
[INFO] [stderr] 207 |     #[inline] fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:230:28
[INFO] [stderr]     |
[INFO] [stderr] 230 |     #[inline] fn to_child( &mut self, n: usize ) -> Option<Visit<T>> {
[INFO] [stderr]     |                            ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/linked/fully/walk.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 |         new_nodes.map( |nodes| self.path.push( nodes ));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: try this: `if let Some(nodes) = new_nodes { self.path.push( nodes ) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:327:15
[INFO] [stderr]     |
[INFO] [stderr] 327 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:342:33
[INFO] [stderr]     |
[INFO] [stderr] 342 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:373:32
[INFO] [stderr]     |
[INFO] [stderr] 373 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:388:30
[INFO] [stderr]     |
[INFO] [stderr] 388 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:517:15
[INFO] [stderr]     |
[INFO] [stderr] 517 |     #[inline] pub fn next( &mut self ) -> Option<Visit<T>> { self.walk.next() }
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:532:33
[INFO] [stderr]     |
[INFO] [stderr] 532 |     #[inline] pub fn to_parent( &mut self ) -> Option<Visit<T>> { self.walk.to_parent() }
[INFO] [stderr]     |                                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:563:32
[INFO] [stderr]     |
[INFO] [stderr] 563 |     #[inline] pub fn to_child( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_child(n) }
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/linked/fully/walk.rs:578:30
[INFO] [stderr]     |
[INFO] [stderr] 578 |     #[inline] pub fn to_sib( &mut self, n: usize ) -> Option<Visit<T>> { self.walk.to_sib(n) }
[INFO] [stderr]     |                              ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/potted/tree.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     fn ne( &self, other: &Self ) -> bool { self.root().ne( other.root() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/potted/forest.rs:505:5
[INFO] [stderr]     |
[INFO] [stderr] 505 |     fn ne( &self, other: &Self ) -> bool { self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/potted/node.rs:585:35
[INFO] [stderr]     |
[INFO] [stderr] 585 |         while let Some( visit ) = iter.next() {
[INFO] [stderr]     |                                   ^^^^^^^^^^^ help: try: `for visit in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/potted/node.rs:662:5
[INFO] [stderr]     |
[INFO] [stderr] 662 |     fn ne( &self, other: &Self ) -> bool { self.data != other.data || self.iter().ne( other.iter() )}
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/potted/pot.rs:71:40
[INFO] [stderr]    |
[INFO] [stderr] 71 |     #[inline] pub(crate) fn nth_child( &self, mut index: usize, mut nth: usize ) -> Option<usize> {
[INFO] [stderr]    |                                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:106:35
[INFO] [stderr]     |
[INFO] [stderr] 106 |     #[inline] pub(crate) fn prev( &self, index: usize ) -> usize { self[ index ].prev as usize }
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:107:35
[INFO] [stderr]     |
[INFO] [stderr] 107 |     #[inline] pub(crate) fn next( &self, index: usize ) -> usize { self[ index ].next as usize }
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:112:29
[INFO] [stderr]     |
[INFO] [stderr] 112 |     pub(crate) fn prev_sib( &self, index: usize ) -> usize {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:128:29
[INFO] [stderr]     |
[INFO] [stderr] 128 |     pub(crate) fn next_sib( &self, index: usize ) -> usize {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:141:44
[INFO] [stderr]     |
[INFO] [stderr] 141 |     #[inline] pub(crate) fn is_forest_pot( &self ) -> bool { self.is_forest( NULL )}
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:145:39
[INFO] [stderr]     |
[INFO] [stderr] 145 |     #[inline] pub(crate) fn adjoined( &self, index: usize )-> usize { self[ index ].adjoined as usize }
[INFO] [stderr]     |                                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:147:37
[INFO] [stderr]     |
[INFO] [stderr] 147 |     #[inline] pub(crate) fn degree( &self, index: usize ) -> usize { self[ index ].size.degree as usize }
[INFO] [stderr]     |                                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:149:39
[INFO] [stderr]     |
[INFO] [stderr] 149 |     #[inline] pub(crate) fn node_cnt( &self, index: usize ) -> usize { self[ index ].size.node_cnt as usize }
[INFO] [stderr]     |                                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:151:38
[INFO] [stderr]     |
[INFO] [stderr] 151 |     #[inline] pub(crate) fn is_leaf( &self, index: usize ) -> bool { self[ index ].child.is_null() }
[INFO] [stderr]     |                                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:153:40
[INFO] [stderr]     |
[INFO] [stderr] 153 |     #[inline] pub(crate) fn is_forest( &self, index: usize ) -> bool { self[ index ].is_forest() }
[INFO] [stderr]     |                                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:155:37
[INFO] [stderr]     |
[INFO] [stderr] 155 |     #[inline] pub(crate) fn parent( &self, index: usize ) -> usize { self[ index ].parent as usize }
[INFO] [stderr]     |                                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:161:35
[INFO] [stderr]     |
[INFO] [stderr] 161 |     #[inline] pub(crate) fn tail( &self, index: usize ) -> usize { self[ index ].child() }
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:163:35
[INFO] [stderr]     |
[INFO] [stderr] 163 |     #[inline] pub(crate) fn head( &self, index: usize ) -> usize {
[INFO] [stderr]     |                                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/potted/pot.rs:171:46
[INFO] [stderr]     |
[INFO] [stderr] 171 |     #[inline] pub(crate) unsafe fn new_tail( &self, index: usize ) -> usize {
[INFO] [stderr]     |                                              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/potted/mod.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 | /         fn tree_to_string<'a, T:Display>( node: &'a Node<T> ) -> String {
[INFO] [stderr] 86 | |             if node.is_leaf() {
[INFO] [stderr] 87 | |                 node.data.to_string()
[INFO] [stderr] 88 | |             } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 92 | |             }
[INFO] [stderr] 93 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/potted/mod.rs:91:31
[INFO] [stderr]    |
[INFO] [stderr] 91 |                         |s,c| s + &tree_to_string(c) + &" " ))
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^----
[INFO] [stderr]    |                                                        |
[INFO] [stderr]    |                                                        help: use the right value directly: `" "`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.17s
[INFO] running `"docker" "inspect" "856f2c6e9f93c639caad400981b0938330c4b483927e5200dc76c16c36582f5c"`
[INFO] running `"docker" "rm" "-f" "856f2c6e9f93c639caad400981b0938330c4b483927e5200dc76c16c36582f5c"`
[INFO] [stdout] 856f2c6e9f93c639caad400981b0938330c4b483927e5200dc76c16c36582f5c