[INFO] crate treebitmap 0.3.1 is already in cache [INFO] extracting crate treebitmap 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/treebitmap/0.3.1 [INFO] extracting crate treebitmap 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treebitmap/0.3.1 [INFO] validating manifest of treebitmap-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of treebitmap-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing treebitmap-0.3.1 [INFO] finished frobbing treebitmap-0.3.1 [INFO] frobbed toml for treebitmap-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/treebitmap/0.3.1/Cargo.toml [INFO] started frobbing treebitmap-0.3.1 [INFO] finished frobbing treebitmap-0.3.1 [INFO] frobbed toml for treebitmap-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treebitmap/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting treebitmap-0.3.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treebitmap/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 945ce5ae2207383d854ecb372ff3b69aefc75636caf96eece6260003f1b1f17a [INFO] running `"docker" "start" "-a" "945ce5ae2207383d854ecb372ff3b69aefc75636caf96eece6260003f1b1f17a"` [INFO] [stderr] Checking treebitmap v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/node.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/node.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/node.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/mod.rs:387:1 [INFO] [stderr] | [INFO] [stderr] 387 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/node.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/node.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/node.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tree_bitmap/mod.rs:387:1 [INFO] [stderr] | [INFO] [stderr] 387 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tree_bitmap/allocator.rs:463:43 [INFO] [stderr] | [INFO] [stderr] 463 | bucket.insert_slot_entry(slot, 0, 123456); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tree_bitmap/allocator.rs:464:53 [INFO] [stderr] | [INFO] [stderr] 464 | assert_eq!(*bucket.get_slot_entry(slot, 0), 123456); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/address.rs:132:33 [INFO] [stderr] | [INFO] [stderr] 132 | let ip = Ipv4Addr::from(0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree_bitmap/allocator.rs:376:32 [INFO] [stderr] | [INFO] [stderr] 376 | unsafe { &mut *ptr.offset(next_bucket_index as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(next_bucket_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree_bitmap/allocator.rs:399:32 [INFO] [stderr] | [INFO] [stderr] 399 | unsafe { &mut *buckets_base_ptr.offset(next_bucket_index as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buckets_base_ptr.add(next_bucket_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `IpLookupTable` [INFO] [stderr] --> src/lib.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Self { [INFO] [stderr] 39 | | IpLookupTable { [INFO] [stderr] 40 | | inner: TreeBitmap::new(), [INFO] [stderr] 41 | | _addrtype: PhantomData, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for IpLookupTable { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree_bitmap/allocator.rs:376:32 [INFO] [stderr] | [INFO] [stderr] 376 | unsafe { &mut *ptr.offset(next_bucket_index as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(next_bucket_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree_bitmap/allocator.rs:399:32 [INFO] [stderr] | [INFO] [stderr] 399 | unsafe { &mut *buckets_base_ptr.offset(next_bucket_index as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buckets_base_ptr.add(next_bucket_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `IpLookupTable` [INFO] [stderr] --> src/lib.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Self { [INFO] [stderr] 39 | | IpLookupTable { [INFO] [stderr] 40 | | inner: TreeBitmap::new(), [INFO] [stderr] 41 | | _addrtype: PhantomData, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for IpLookupTable { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:57:47 [INFO] [stderr] | [INFO] [stderr] 57 | tbm.insert(Ipv4Addr::new(10, 0, 0, 0), 8, 100002); [INFO] [stderr] | ^^^^^^ help: consider: `100_002` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:58:50 [INFO] [stderr] | [INFO] [stderr] 58 | tbm.insert(Ipv4Addr::new(100, 64, 0, 0), 24, 10064024); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_064_024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:59:50 [INFO] [stderr] | [INFO] [stderr] 59 | tbm.insert(Ipv4Addr::new(100, 64, 1, 0), 24, 10064124); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_064_124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:60:50 [INFO] [stderr] | [INFO] [stderr] 60 | tbm.insert(Ipv4Addr::new(100, 64, 0, 0), 10, 100004); [INFO] [stderr] | ^^^^^^ help: consider: `100_004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:63:62 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(result, Some((Ipv4Addr::new(10, 0, 0, 0), 8, &100002))); [INFO] [stderr] | ^^^^^^ help: consider: `100_002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:66:65 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(result, Some((Ipv4Addr::new(100, 64, 0, 0), 10, &100004))); [INFO] [stderr] | ^^^^^^ help: consider: `100_004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:69:65 [INFO] [stderr] | [INFO] [stderr] 69 | assert_eq!(result, Some((Ipv4Addr::new(100, 64, 0, 0), 24, &10064024))); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_064_024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.04s [INFO] running `"docker" "inspect" "945ce5ae2207383d854ecb372ff3b69aefc75636caf96eece6260003f1b1f17a"` [INFO] running `"docker" "rm" "-f" "945ce5ae2207383d854ecb372ff3b69aefc75636caf96eece6260003f1b1f17a"` [INFO] [stdout] 945ce5ae2207383d854ecb372ff3b69aefc75636caf96eece6260003f1b1f17a