[INFO] crate translator 0.3.0 is already in cache [INFO] extracting crate translator 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/translator/0.3.0 [INFO] extracting crate translator 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/translator/0.3.0 [INFO] validating manifest of translator-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of translator-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing translator-0.3.0 [INFO] finished frobbing translator-0.3.0 [INFO] frobbed toml for translator-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/translator/0.3.0/Cargo.toml [INFO] started frobbing translator-0.3.0 [INFO] finished frobbing translator-0.3.0 [INFO] frobbed toml for translator-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/translator/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting translator-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/translator/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1de33beefd8646f89617e90c7599d6cab9b2fb5b53925459ee74b22e6bb39714 [INFO] running `"docker" "start" "-a" "1de33beefd8646f89617e90c7599d6cab9b2fb5b53925459ee74b22e6bb39714"` [INFO] [stderr] Checking proc-macro2 v0.2.3 [INFO] [stderr] Checking quote v0.4.2 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking translator v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | Some(t) => write!(file, "\t{} {};\n", t, name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | None => write!(file, "\t{} {};\n", dtype, name).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | Some(t) => write!(file, "\t\tpublic {} {};\n", t, name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | None => write!(file, "\t\tpublic {} {};\n", dtype, name).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:165:28 [INFO] [stderr] | [INFO] [stderr] 165 | Some(t) => write!(file, "\t{} {}[{}];\n", t, name, length).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | None => write!(file, "\t{} {}[{}];\n", dtype, name, length).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | write!(file, "\t\t[MarshalAs(UnmanagedType.LPArray, ArraySubType=UnmanagedType.LPStr, SizeConst={})]\n", length).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | write!(file, "\t\t[MarshalAs(UnmanagedType.ByValArray, SizeConst = {})]\n", length).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | write!(file, "\t\tpublic {}[] {};\n", t, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | write!(file, "\t\t[MarshalAs(UnmanagedType.ByValArray, SizeConst = {})]\n", length).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:197:21 [INFO] [stderr] | [INFO] [stderr] 197 | write!(file, "\t\tpublic {}[] {};\n", dtype, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | Some(t) => write!(file, "\t{}* {};\n", t, name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | None => write!(file, "\t{}* {};\n", dtype, name).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | write!(file, "\t\t[MarshalAs(UnmanagedType.LPStr)]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | write!(file, "\t\tpublic {} {};\n", t, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:262:25 [INFO] [stderr] | [INFO] [stderr] 262 | write!(file, "\t\t//This is a '{}' type\n", name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:263:25 [INFO] [stderr] | [INFO] [stderr] 263 | write!(file, "\t\tpublic IntPtr {};\n", name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | write!(file, "\t\t[MarshalAs(UnmanagedType.LPStruct)]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | write!(file, "\t\tpublic {} {};\n", dtype, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | write!(file, "typedef struct {}Tag {{\n", structname).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | write!(file, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | Some(t) => write!(file, "\t{} {};\n", t, name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | None => write!(file, "\t{} {};\n", dtype, name).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | Some(t) => write!(file, "\t\tpublic {} {};\n", t, name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:151:25 [INFO] [stderr] | [INFO] [stderr] 151 | None => write!(file, "\t\tpublic {} {};\n", dtype, name).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:165:28 [INFO] [stderr] | [INFO] [stderr] 165 | Some(t) => write!(file, "\t{} {}[{}];\n", t, name, length).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | None => write!(file, "\t{} {}[{}];\n", dtype, name, length).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | write!(file, "\t\t[MarshalAs(UnmanagedType.LPArray, ArraySubType=UnmanagedType.LPStr, SizeConst={})]\n", length).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | write!(file, "\t\t[MarshalAs(UnmanagedType.ByValArray, SizeConst = {})]\n", length).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | write!(file, "\t\tpublic {}[] {};\n", t, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | write!(file, "\t\t[MarshalAs(UnmanagedType.ByValArray, SizeConst = {})]\n", length).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:197:21 [INFO] [stderr] | [INFO] [stderr] 197 | write!(file, "\t\tpublic {}[] {};\n", dtype, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | Some(t) => write!(file, "\t{}* {};\n", t, name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | None => write!(file, "\t{}* {};\n", dtype, name).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | write!(file, "\t\t[MarshalAs(UnmanagedType.LPStr)]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | write!(file, "\t\tpublic {} {};\n", t, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:262:25 [INFO] [stderr] | [INFO] [stderr] 262 | write!(file, "\t\t//This is a '{}' type\n", name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:263:25 [INFO] [stderr] | [INFO] [stderr] 263 | write!(file, "\t\tpublic IntPtr {};\n", name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | write!(file, "\t\t[MarshalAs(UnmanagedType.LPStruct)]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | write!(file, "\t\tpublic {} {};\n", dtype, name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | write!(file, "typedef struct {}Tag {{\n", structname).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/filewriter.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | write!(file, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:122:8 [INFO] [stderr] | [INFO] [stderr] 122 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:122:39 [INFO] [stderr] | [INFO] [stderr] 122 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:159:39 [INFO] [stderr] | [INFO] [stderr] 159 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:211:8 [INFO] [stderr] | [INFO] [stderr] 211 | if dtype.to_string() == "c_char" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/filewriter.rs:289:43 [INFO] [stderr] | [INFO] [stderr] 289 | PY_LINES.lock().unwrap().push(format!(" _fields_ = [\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" _fields_ = [\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/filewriter.rs:305:43 [INFO] [stderr] | [INFO] [stderr] 305 | PY_LINES.lock().unwrap().push(format!(" ]\n\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" ]\n\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / lazy_static! { [INFO] [stderr] 27 | | static ref EXPORT_NAME: RwLock = { [INFO] [stderr] 28 | | RwLock::new("TranslateOutput".to_string()) [INFO] [stderr] 29 | | }; [INFO] [stderr] ... | [INFO] [stderr] 59 | | }; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:30:43 [INFO] [stderr] | [INFO] [stderr] 30 | static ref CLOSED_FLAG: Mutex = { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 31 | | Mutex::new(false) [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | Mutex::new(false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / lazy_static! { [INFO] [stderr] 27 | | static ref EXPORT_NAME: RwLock = { [INFO] [stderr] 28 | | RwLock::new("TranslateOutput".to_string()) [INFO] [stderr] 29 | | }; [INFO] [stderr] ... | [INFO] [stderr] 59 | | }; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | fn check_magic_struct(id: &syn::Ident) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:98:8 [INFO] [stderr] | [INFO] [stderr] 98 | if id.to_string() == "__FinalizeTranslatorStruct__" { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `*id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:122:8 [INFO] [stderr] | [INFO] [stderr] 122 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:122:39 [INFO] [stderr] | [INFO] [stderr] 122 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / match token.kind { [INFO] [stderr] 129 | | TokenNode::Group(_, ts) => { [INFO] [stderr] 130 | | for t in ts.into_iter() { [INFO] [stderr] 131 | | match t.kind { [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => {} [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let TokenNode::Group(_, ts) = token.kind { [INFO] [stderr] 129 | for t in ts.into_iter() { [INFO] [stderr] 130 | match t.kind { [INFO] [stderr] 131 | TokenNode::Term(t) => { [INFO] [stderr] 132 | is_reprc = t.as_str() == "C"; [INFO] [stderr] 133 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | / match t.kind { [INFO] [stderr] 132 | | TokenNode::Term(t) => { [INFO] [stderr] 133 | | is_reprc = t.as_str() == "C"; [INFO] [stderr] 134 | | }, [INFO] [stderr] 135 | | _ => {} [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let TokenNode::Term(t) = t.kind { [INFO] [stderr] 132 | is_reprc = t.as_str() == "C"; [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:159:39 [INFO] [stderr] | [INFO] [stderr] 159 | if dtype.to_string() == "i128" || dtype.to_string() == "u128" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/filewriter.rs:211:8 [INFO] [stderr] | [INFO] [stderr] 211 | if dtype.to_string() == "c_char" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*dtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/filewriter.rs:289:43 [INFO] [stderr] | [INFO] [stderr] 289 | PY_LINES.lock().unwrap().push(format!(" _fields_ = [\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" _fields_ = [\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/filewriter.rs:305:43 [INFO] [stderr] | [INFO] [stderr] 305 | PY_LINES.lock().unwrap().push(format!(" ]\n\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" ]\n\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / lazy_static! { [INFO] [stderr] 27 | | static ref EXPORT_NAME: RwLock = { [INFO] [stderr] 28 | | RwLock::new("TranslateOutput".to_string()) [INFO] [stderr] 29 | | }; [INFO] [stderr] ... | [INFO] [stderr] 59 | | }; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:30:43 [INFO] [stderr] | [INFO] [stderr] 30 | static ref CLOSED_FLAG: Mutex = { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 31 | | Mutex::new(false) [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | Mutex::new(false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / lazy_static! { [INFO] [stderr] 27 | | static ref EXPORT_NAME: RwLock = { [INFO] [stderr] 28 | | RwLock::new("TranslateOutput".to_string()) [INFO] [stderr] 29 | | }; [INFO] [stderr] ... | [INFO] [stderr] 59 | | }; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | fn check_magic_struct(id: &syn::Ident) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:98:8 [INFO] [stderr] | [INFO] [stderr] 98 | if id.to_string() == "__FinalizeTranslatorStruct__" { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `*id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / match token.kind { [INFO] [stderr] 129 | | TokenNode::Group(_, ts) => { [INFO] [stderr] 130 | | for t in ts.into_iter() { [INFO] [stderr] 131 | | match t.kind { [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => {} [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let TokenNode::Group(_, ts) = token.kind { [INFO] [stderr] 129 | for t in ts.into_iter() { [INFO] [stderr] 130 | match t.kind { [INFO] [stderr] 131 | TokenNode::Term(t) => { [INFO] [stderr] 132 | is_reprc = t.as_str() == "C"; [INFO] [stderr] 133 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | / match t.kind { [INFO] [stderr] 132 | | TokenNode::Term(t) => { [INFO] [stderr] 133 | | is_reprc = t.as_str() == "C"; [INFO] [stderr] 134 | | }, [INFO] [stderr] 135 | | _ => {} [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let TokenNode::Term(t) = t.kind { [INFO] [stderr] 132 | is_reprc = t.as_str() == "C"; [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.87s [INFO] running `"docker" "inspect" "1de33beefd8646f89617e90c7599d6cab9b2fb5b53925459ee74b22e6bb39714"` [INFO] running `"docker" "rm" "-f" "1de33beefd8646f89617e90c7599d6cab9b2fb5b53925459ee74b22e6bb39714"` [INFO] [stdout] 1de33beefd8646f89617e90c7599d6cab9b2fb5b53925459ee74b22e6bb39714