[INFO] crate trait_derive_core 0.1.0 is already in cache [INFO] extracting crate trait_derive_core 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/trait_derive_core/0.1.0 [INFO] extracting crate trait_derive_core 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trait_derive_core/0.1.0 [INFO] validating manifest of trait_derive_core-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trait_derive_core-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trait_derive_core-0.1.0 [INFO] finished frobbing trait_derive_core-0.1.0 [INFO] frobbed toml for trait_derive_core-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/trait_derive_core/0.1.0/Cargo.toml [INFO] started frobbing trait_derive_core-0.1.0 [INFO] finished frobbing trait_derive_core-0.1.0 [INFO] frobbed toml for trait_derive_core-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trait_derive_core/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trait_derive_core-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trait_derive_core/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a30163851c2de616bdc1d9426e2c3033ccab7686ccaebde3fc1deab6689c601 [INFO] running `"docker" "start" "-a" "6a30163851c2de616bdc1d9426e2c3033ccab7686ccaebde3fc1deab6689c601"` [INFO] [stderr] Checking unicode-xid v0.0.4 [INFO] [stderr] Checking synom v0.11.3 [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking trait_derive_core v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fnargs.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn parse_args(decl: &Vec) -> FnArgs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::FnArg]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `argc` is used as a loop counter. Consider using `for (argc, item) in decl.enumerate()` or similar iterators [INFO] [stderr] --> src/fnargs.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | for input in decl { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fnargs.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match input { [INFO] [stderr] 32 | | &syn::FnArg::SelfRef(ref lifetime, ref mutability) => { [INFO] [stderr] 33 | | args.args_with_types = quote! { &#lifetime #mutability self }; [INFO] [stderr] 34 | | args.mutable_status = mutability.clone(); [INFO] [stderr] ... | [INFO] [stderr] 56 | | _ => {} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *input { [INFO] [stderr] 32 | syn::FnArg::SelfRef(ref lifetime, ref mutability) => { [INFO] [stderr] 33 | args.args_with_types = quote! { &#lifetime #mutability self }; [INFO] [stderr] 34 | args.mutable_status = mutability.clone(); [INFO] [stderr] 35 | args.is_instance_method = true; [INFO] [stderr] 36 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fnargs.rs:34:39 [INFO] [stderr] | [INFO] [stderr] 34 | args.mutable_status = mutability.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mutability` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fnargs.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn parse_args(decl: &Vec) -> FnArgs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::FnArg]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] warning: the variable `argc` is used as a loop counter. Consider using `for (argc, item) in decl.enumerate()` or similar iterators [INFO] [stderr] --> src/fnargs.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | for input in decl { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fnargs.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match input { [INFO] [stderr] 32 | | &syn::FnArg::SelfRef(ref lifetime, ref mutability) => { [INFO] [stderr] 33 | | args.args_with_types = quote! { &#lifetime #mutability self }; [INFO] [stderr] 34 | | args.mutable_status = mutability.clone(); [INFO] [stderr] ... | [INFO] [stderr] 56 | | _ => {} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *input { [INFO] [stderr] 32 | syn::FnArg::SelfRef(ref lifetime, ref mutability) => { [INFO] [stderr] 33 | args.args_with_types = quote! { &#lifetime #mutability self }; [INFO] [stderr] 34 | args.mutable_status = mutability.clone(); [INFO] [stderr] 35 | args.is_instance_method = true; [INFO] [stderr] 36 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fnargs.rs:34:39 [INFO] [stderr] | [INFO] [stderr] 34 | args.mutable_status = mutability.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mutability` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fnargs.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | args.mutable_status = mutability.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mutability` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fnargs.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | args.mutable_status = mutability.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mutability` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let ref unsafety = sig.unsafety; [INFO] [stderr] | ----^^^^^^^^^^^^---------------- help: try: `let unsafety = &sig.unsafety;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | let ref inputs = sig.decl.inputs; [INFO] [stderr] | ----^^^^^^^^^^------------------- help: try: `let inputs = &sig.decl.inputs;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | let ref generics = sig.generics; [INFO] [stderr] | ----^^^^^^^^^^^^---------------- help: try: `let generics = &sig.generics;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let ref where_clause = generics.where_clause; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let where_clause = &generics.where_clause;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let ref args_with_types = args.args_with_types; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^------------------------ help: try: `let args_with_types = &args.args_with_types;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | fn parse_methods(items: &Vec) -> (quote::Tokens, quote::Tokens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::ImplItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let ref unsafety = sig.unsafety; [INFO] [stderr] | ----^^^^^^^^^^^^---------------- help: try: `let unsafety = &sig.unsafety;` [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | let ref segments = path.segments; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let segments = &path.segments;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:110:29 [INFO] [stderr] | [INFO] [stderr] 110 | let ref last_ident = segments.last().unwrap().ident; [INFO] [stderr] | ----^^^^^^^^^^^^^^---------------------------------- help: try: `let last_ident = &segments.last().unwrap().ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let ref where_clause = generics.where_clause; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let where_clause = &generics.where_clause;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | let ref inputs = sig.decl.inputs; [INFO] [stderr] | ----^^^^^^^^^^------------------- help: try: `let inputs = &sig.decl.inputs;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | let ref generics = sig.generics; [INFO] [stderr] | ----^^^^^^^^^^^^---------------- help: try: `let generics = &sig.generics;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let ref where_clause = generics.where_clause; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let where_clause = &generics.where_clause;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let ref args_with_types = args.args_with_types; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^------------------------ help: try: `let args_with_types = &args.args_with_types;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | fn parse_methods(items: &Vec) -> (quote::Tokens, quote::Tokens) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::ImplItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | let ref segments = path.segments; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let segments = &path.segments;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:110:29 [INFO] [stderr] | [INFO] [stderr] 110 | let ref last_ident = segments.last().unwrap().ident; [INFO] [stderr] | ----^^^^^^^^^^^^^^---------------------------------- help: try: `let last_ident = &segments.last().unwrap().ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let ref where_clause = generics.where_clause; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------- help: try: `let where_clause = &generics.where_clause;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.84s [INFO] running `"docker" "inspect" "6a30163851c2de616bdc1d9426e2c3033ccab7686ccaebde3fc1deab6689c601"` [INFO] running `"docker" "rm" "-f" "6a30163851c2de616bdc1d9426e2c3033ccab7686ccaebde3fc1deab6689c601"` [INFO] [stdout] 6a30163851c2de616bdc1d9426e2c3033ccab7686ccaebde3fc1deab6689c601