[INFO] crate trailblazer 0.0.0 is already in cache [INFO] extracting crate trailblazer 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/trailblazer/0.0.0 [INFO] extracting crate trailblazer 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trailblazer/0.0.0 [INFO] validating manifest of trailblazer-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trailblazer-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trailblazer-0.0.0 [INFO] finished frobbing trailblazer-0.0.0 [INFO] frobbed toml for trailblazer-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/trailblazer/0.0.0/Cargo.toml [INFO] started frobbing trailblazer-0.0.0 [INFO] finished frobbing trailblazer-0.0.0 [INFO] frobbed toml for trailblazer-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trailblazer/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trailblazer-0.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trailblazer/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 454d45ae026f4ac3c77621610993934a95c86288eba256a59fdee26ec8cb7a04 [INFO] running `"docker" "start" "-a" "454d45ae026f4ac3c77621610993934a95c86288eba256a59fdee26ec8cb7a04"` [INFO] [stderr] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest [INFO] [stderr] Checking trailblazer v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | prop_queue: prop_queue, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prop_queue` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | prop_queue: prop_queue, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prop_queue` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `propagate::PropQueue` [INFO] [stderr] --> src/propagate.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Self { [INFO] [stderr] 16 | | queue: Rc::new(RefCell::new(VecDeque::new())), [INFO] [stderr] 17 | | to_enqueue: Rc::new(RefCell::new(VecDeque::new())), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `propagate::PropQueue` [INFO] [stderr] --> src/propagate.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Self { [INFO] [stderr] 16 | | queue: Rc::new(RefCell::new(VecDeque::new())), [INFO] [stderr] 17 | | to_enqueue: Rc::new(RefCell::new(VecDeque::new())), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `trail::Trail` [INFO] [stderr] --> src/trail.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self { [INFO] [stderr] 17 | | trail: Rc::new(RefCell::new(vec![])), [INFO] [stderr] 18 | | nodes: Rc::new(RefCell::new(vec![])), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/trail.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | self.nodes.borrow_mut().pop().map(|n| self.undo_until(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = self.nodes.borrow_mut().pop() { self.undo_until(n) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/trail.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | trail.pop().map(|mut c| c.undo()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut c) = trail.pop() { c.undo() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `trail::Trail` [INFO] [stderr] --> src/trail.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self { [INFO] [stderr] 17 | | trail: Rc::new(RefCell::new(vec![])), [INFO] [stderr] 18 | | nodes: Rc::new(RefCell::new(vec![])), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/trail.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | self.nodes.borrow_mut().pop().map(|n| self.undo_until(n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(n) = self.nodes.borrow_mut().pop() { self.undo_until(n) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/trail.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | trail.pop().map(|mut c| c.undo()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(mut c) = trail.pop() { c.undo() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "454d45ae026f4ac3c77621610993934a95c86288eba256a59fdee26ec8cb7a04"` [INFO] running `"docker" "rm" "-f" "454d45ae026f4ac3c77621610993934a95c86288eba256a59fdee26ec8cb7a04"` [INFO] [stdout] 454d45ae026f4ac3c77621610993934a95c86288eba256a59fdee26ec8cb7a04