[INFO] crate touch 0.0.1 is already in cache [INFO] extracting crate touch 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/touch/0.0.1 [INFO] extracting crate touch 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/touch/0.0.1 [INFO] validating manifest of touch-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of touch-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing touch-0.0.1 [INFO] finished frobbing touch-0.0.1 [INFO] frobbed toml for touch-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/touch/0.0.1/Cargo.toml [INFO] started frobbing touch-0.0.1 [INFO] finished frobbing touch-0.0.1 [INFO] frobbed toml for touch-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/touch/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting touch-0.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/touch/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea4f4567247625ee020b978e09e643a16a819fbc8a42fcdec7da198b0a3d6576 [INFO] running `"docker" "start" "-a" "ea4f4567247625ee020b978e09e643a16a819fbc8a42fcdec7da198b0a3d6576"` [INFO] [stderr] Checking touch v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub const CREATE: &'static str = "create"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DELETE: &'static str = "delete"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | pub const READ: &'static str = "read"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | pub const WRITE: &'static str = "write"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub const CREATE: &'static str = "create"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64| #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DELETE: &'static str = "delete"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | pub const READ: &'static str = "read"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/operation.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | pub const WRITE: &'static str = "write"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/file.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | let directory = try!(Path::new(path).parent().ok_or( [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 26 | | Error::new(&Operation::Read, path) [INFO] [stderr] 27 | | ).and_then(|parent| { [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::new(&Operation::Read, path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/file.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | parent.as_os_str().to_str().ok_or( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 29 | | Error::new(&Operation::Read, path) [INFO] [stderr] 30 | | ) [INFO] [stderr] | |_________^ help: try this: `ok_or_else(|| Error::new(&Operation::Read, path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `touch`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ea4f4567247625ee020b978e09e643a16a819fbc8a42fcdec7da198b0a3d6576"` [INFO] running `"docker" "rm" "-f" "ea4f4567247625ee020b978e09e643a16a819fbc8a42fcdec7da198b0a3d6576"` [INFO] [stdout] ea4f4567247625ee020b978e09e643a16a819fbc8a42fcdec7da198b0a3d6576