[INFO] crate total-order-multi-map 0.4.5 is already in cache [INFO] extracting crate total-order-multi-map 0.4.5 into work/ex/clippy-test-run/sources/stable/reg/total-order-multi-map/0.4.5 [INFO] extracting crate total-order-multi-map 0.4.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/total-order-multi-map/0.4.5 [INFO] validating manifest of total-order-multi-map-0.4.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of total-order-multi-map-0.4.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing total-order-multi-map-0.4.5 [INFO] finished frobbing total-order-multi-map-0.4.5 [INFO] frobbed toml for total-order-multi-map-0.4.5 written to work/ex/clippy-test-run/sources/stable/reg/total-order-multi-map/0.4.5/Cargo.toml [INFO] started frobbing total-order-multi-map-0.4.5 [INFO] finished frobbing total-order-multi-map-0.4.5 [INFO] frobbed toml for total-order-multi-map-0.4.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/total-order-multi-map/0.4.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting total-order-multi-map-0.4.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/total-order-multi-map/0.4.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28b02fad2ea1121f84fd10885a3c083441568fa5f0b224239d085482d7f2c98a [INFO] running `"docker" "start" "-a" "28b02fad2ea1121f84fd10885a3c083441568fa5f0b224239d085482d7f2c98a"` [INFO] [stderr] Checking vec-drain-where v1.0.0 [INFO] [stderr] Checking total-order-multi-map v0.4.5 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entry.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn add(self, val: V) -> EntryValuesMut<'a, V::Target> { [INFO] [stderr] 92 | | use self::hash_map::Entry::*; [INFO] [stderr] 93 | | let mut val = val; [INFO] [stderr] 94 | | [INFO] [stderr] ... | [INFO] [stderr] 114 | | EntryValuesMut::new(vals.iter_mut()) [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/map_iter.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.inner_iter.next().map(|&k|k) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.inner_iter.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/map_iter.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | key: self.key.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:298:29 [INFO] [stderr] | [INFO] [stderr] 298 | .unwrap_or_else(|| EntryValues::empty()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EntryValues::empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:308:29 [INFO] [stderr] | [INFO] [stderr] 308 | .unwrap_or_else(|| EntryValuesMut::empty()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EntryValuesMut::empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:419:16 [INFO] [stderr] | [INFO] [stderr] 419 | if let Some(_) = self.map_access.remove(&key_to_remove) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 420 | | self.vec_data.retain(|&(key, _)| key != key_to_remove); [INFO] [stderr] 421 | | true [INFO] [stderr] 422 | | } else { [INFO] [stderr] 423 | | false [INFO] [stderr] 424 | | } [INFO] [stderr] | |_________- help: try this: `if self.map_access.remove(&key_to_remove).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/entry.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn add(self, val: V) -> EntryValuesMut<'a, V::Target> { [INFO] [stderr] 92 | | use self::hash_map::Entry::*; [INFO] [stderr] 93 | | let mut val = val; [INFO] [stderr] 94 | | [INFO] [stderr] ... | [INFO] [stderr] 114 | | EntryValuesMut::new(vals.iter_mut()) [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/map_iter.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.inner_iter.next().map(|&k|k) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.inner_iter.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/map_iter.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | key: self.key.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:298:29 [INFO] [stderr] | [INFO] [stderr] 298 | .unwrap_or_else(|| EntryValues::empty()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EntryValues::empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:308:29 [INFO] [stderr] | [INFO] [stderr] 308 | .unwrap_or_else(|| EntryValuesMut::empty()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `EntryValuesMut::empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:419:16 [INFO] [stderr] | [INFO] [stderr] 419 | if let Some(_) = self.map_access.remove(&key_to_remove) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 420 | | self.vec_data.retain(|&(key, _)| key != key_to_remove); [INFO] [stderr] 421 | | true [INFO] [stderr] 422 | | } else { [INFO] [stderr] 423 | | false [INFO] [stderr] 424 | | } [INFO] [stderr] | |_________- help: try this: `if self.map_access.remove(&key_to_remove).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:931:30 [INFO] [stderr] | [INFO] [stderr] 931 | assert_eq!(vec![44], map.get(ka).map(|v|*v).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `map.get(ka).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:932:30 [INFO] [stderr] | [INFO] [stderr] 932 | assert_eq!(vec![13], map.get(kb).map(|v|*v).collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `map.get(kb).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.16s [INFO] running `"docker" "inspect" "28b02fad2ea1121f84fd10885a3c083441568fa5f0b224239d085482d7f2c98a"` [INFO] running `"docker" "rm" "-f" "28b02fad2ea1121f84fd10885a3c083441568fa5f0b224239d085482d7f2c98a"` [INFO] [stdout] 28b02fad2ea1121f84fd10885a3c083441568fa5f0b224239d085482d7f2c98a