[INFO] crate tinyjson 0.1.0 is already in cache
[INFO] extracting crate tinyjson 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tinyjson/0.1.0
[INFO] extracting crate tinyjson 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyjson/0.1.0
[INFO] validating manifest of tinyjson-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tinyjson-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tinyjson-0.1.0
[INFO] finished frobbing tinyjson-0.1.0
[INFO] frobbed toml for tinyjson-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tinyjson/0.1.0/Cargo.toml
[INFO] started frobbing tinyjson-0.1.0
[INFO] finished frobbing tinyjson-0.1.0
[INFO] frobbed toml for tinyjson-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyjson/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tinyjson-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tinyjson/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 22542c95f9d186a6aafb0986a827095a97387f3450730dc8d95caea728729611
[INFO] running `"docker" "start" "-a" "22542c95f9d186a6aafb0986a827095a97387f3450730dc8d95caea728729611"`
[INFO] [stderr]     Checking tinyjson v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 |         JsonParseError {msg: msg, line: line, col: col}
[INFO] [stderr]    |                         ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:17:35
[INFO] [stderr]    |
[INFO] [stderr] 17 |         JsonParseError {msg: msg, line: line, col: col}
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:17:47
[INFO] [stderr]    |
[INFO] [stderr] 17 |         JsonParseError {msg: msg, line: line, col: col}
[INFO] [stderr]    |                                               ^^^^^^^^ help: replace it with: `col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 |         JsonParseError {msg: msg, line: line, col: col}
[INFO] [stderr]    |                         ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:17:35
[INFO] [stderr]    |
[INFO] [stderr] 17 |         JsonParseError {msg: msg, line: line, col: col}
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:17:47
[INFO] [stderr]    |
[INFO] [stderr] 17 |         JsonParseError {msg: msg, line: line, col: col}
[INFO] [stderr]    |                                               ^^^^^^^^ help: replace it with: `col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/parser.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         loop {
[INFO] [stderr] 44 | |             match self.chars.peek() {
[INFO] [stderr] 45 | |                 Some(c) => {
[INFO] [stderr] 46 | |                     if !c.is_whitespace() {
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |             self.chars.next();
[INFO] [stderr] 59 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(c) = self.chars.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/parser.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         loop {
[INFO] [stderr] 44 | |             match self.chars.peek() {
[INFO] [stderr] 45 | |                 Some(c) => {
[INFO] [stderr] 46 | |                     if !c.is_whitespace() {
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |             self.chars.next();
[INFO] [stderr] 59 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(c) = self.chars.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:244:9
[INFO] [stderr]     |
[INFO] [stderr] 244 | /         loop {
[INFO] [stderr] 245 | |             let d = match self.chars.peek() {
[INFO] [stderr] 246 | |                 Some(x) => *x,
[INFO] [stderr] 247 | |                 None => break,
[INFO] [stderr] ...   |
[INFO] [stderr] 256 | |             self.chars.next();
[INFO] [stderr] 257 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(x) = self.chars.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:244:9
[INFO] [stderr]     |
[INFO] [stderr] 244 | /         loop {
[INFO] [stderr] 245 | |             let d = match self.chars.peek() {
[INFO] [stderr] 246 | |                 Some(x) => *x,
[INFO] [stderr] 247 | |                 None => break,
[INFO] [stderr] ...   |
[INFO] [stderr] 256 | |             self.chars.next();
[INFO] [stderr] 257 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(x) = self.chars.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/parser.rs:289:30
[INFO] [stderr]     |
[INFO] [stderr] 289 | pub fn make_string_parser(s: &String) -> JsonParser<Chars> {
[INFO] [stderr]     |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/parser.rs:289:30
[INFO] [stderr]     |
[INFO] [stderr] 289 | pub fn make_string_parser(s: &String) -> JsonParser<Chars> {
[INFO] [stderr]     |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         match v {
[INFO] [stderr] 23 | |             &JsonValue::Number(ref n) => Some(n),
[INFO] [stderr] 24 | |             _ => None,
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         match *v {
[INFO] [stderr] 23 |             JsonValue::Number(ref n) => Some(n),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         match v {
[INFO] [stderr] 32 | |             &JsonValue::Boolean(ref b) => Some(b),
[INFO] [stderr] 33 | |             _ => None,
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match *v {
[INFO] [stderr] 32 |             JsonValue::Boolean(ref b) => Some(b),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         match v {
[INFO] [stderr] 41 | |             &JsonValue::String(ref s) => Some(s),
[INFO] [stderr] 42 | |             _ => None,
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 40 |         match *v {
[INFO] [stderr] 41 |             JsonValue::String(ref s) => Some(s),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         match v {
[INFO] [stderr] 23 | |             &JsonValue::Number(ref n) => Some(n),
[INFO] [stderr] 24 | |             _ => None,
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 22 |         match *v {
[INFO] [stderr] 23 |             JsonValue::Number(ref n) => Some(n),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         match v {
[INFO] [stderr] 32 | |             &JsonValue::Boolean(ref b) => Some(b),
[INFO] [stderr] 33 | |             _ => None,
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |         match *v {
[INFO] [stderr] 32 |             JsonValue::Boolean(ref b) => Some(b),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match v {
[INFO] [stderr] 50 | |             &JsonValue::Null => Some(&NULL),
[INFO] [stderr] 51 | |             _ => None,
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         match v {
[INFO] [stderr] 41 | |             &JsonValue::String(ref s) => Some(s),
[INFO] [stderr] 42 | |             _ => None,
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 40 |         match *v {
[INFO] [stderr] 41 |             JsonValue::String(ref s) => Some(s),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *v {
[INFO] [stderr] 50 |             JsonValue::Null => Some(&NULL),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match v {
[INFO] [stderr] 50 | |             &JsonValue::Null => Some(&NULL),
[INFO] [stderr] 51 | |             _ => None,
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match v {
[INFO] [stderr] 59 | |             &JsonValue::Array(ref a) => Some(a),
[INFO] [stderr] 60 | |             _ => None,
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr] 58 |         match *v {
[INFO] [stderr]    |
[INFO] [stderr] 59 |             JsonValue::Array(ref a) => Some(a),
[INFO] [stderr] 49 |         match *v {
[INFO] [stderr]    |
[INFO] [stderr] 50 |             JsonValue::Null => Some(&NULL),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         match v {
[INFO] [stderr] 68 | |             &JsonValue::Object(ref h) => Some(h),
[INFO] [stderr] 69 | |             _ => None,
[INFO] [stderr] 70 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 67 |         match *v {
[INFO] [stderr] 68 |             JsonValue::Object(ref h) => Some(h),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match v {
[INFO] [stderr] 59 | |             &JsonValue::Array(ref a) => Some(a),
[INFO] [stderr] 60 | |             _ => None,
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *v {
[INFO] [stderr] 59 |             JsonValue::Array(ref a) => Some(a),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         match v {
[INFO] [stderr] 68 | |             &JsonValue::Object(ref h) => Some(h),
[INFO] [stderr] 69 | |             _ => None,
[INFO] [stderr] 70 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 67 |         match *v {
[INFO] [stderr] 68 |             JsonValue::Object(ref h) => Some(h),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 | /         match self {
[INFO] [stderr] 81 | |             &JsonValue::Boolean(_) => true,
[INFO] [stderr] 82 | |             _ => false,
[INFO] [stderr] 83 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 80 |         match *self {
[INFO] [stderr] 81 |             JsonValue::Boolean(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 | /         match self {
[INFO] [stderr] 88 | |             &JsonValue::Number(_) => true,
[INFO] [stderr] 89 | |             _ => false,
[INFO] [stderr] 90 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 87 |         match *self {
[INFO] [stderr] 88 |             JsonValue::Number(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 | /         match self {
[INFO] [stderr] 95 | |             &JsonValue::String(_) => true,
[INFO] [stderr] 96 | |             _ => false,
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 94 |         match *self {
[INFO] [stderr] 95 |             JsonValue::String(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 | /         match self {
[INFO] [stderr] 81 | |             &JsonValue::Boolean(_) => true,
[INFO] [stderr] 82 | |             _ => false,
[INFO] [stderr] 83 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         match self {
[INFO] [stderr] 102 | |             &JsonValue::Null => true,
[INFO] [stderr] 103 | |             _ => false,
[INFO] [stderr] 104 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr]    |
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 101 |         match *self {
[INFO] [stderr] 102 |             JsonValue::Null => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 80 |         match *self {
[INFO] [stderr] 81 |             JsonValue::Boolean(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 | /         match self {
[INFO] [stderr] 109 | |             &JsonValue::Array(_) => true,
[INFO] [stderr] 110 | |             _ => false,
[INFO] [stderr] 111 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |         match *self {
[INFO] [stderr] 109 |             JsonValue::Array(_) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 | /         match self {
[INFO] [stderr] 88 | |             &JsonValue::Number(_) => true,
[INFO] [stderr] 89 | |             _ => false,
[INFO] [stderr] 90 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 87 |         match *self {
[INFO] [stderr] 88 |             JsonValue::Number(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 | /         match self {
[INFO] [stderr] 116 | |             &JsonValue::Object(_) => true,
[INFO] [stderr] 117 | |             _ => false,
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 115 |         match *self {
[INFO] [stderr] 116 |             JsonValue::Object(_) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/json_value.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 | /         match self {
[INFO] [stderr] 95 | |             &JsonValue::String(_) => true,
[INFO] [stderr] 96 | |             _ => false,
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 94 |         match *self {
[INFO] [stderr] 95 |             JsonValue::String(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         match self {
[INFO] [stderr] 102 | |             &JsonValue::Null => true,
[INFO] [stderr] 103 | |             _ => false,
[INFO] [stderr] 104 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 101 |         match *self {
[INFO] [stderr] 102 |             JsonValue::Null => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 | /         match self {
[INFO] [stderr] 109 | |             &JsonValue::Array(_) => true,
[INFO] [stderr] 110 | |             _ => false,
[INFO] [stderr] 111 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |         match *self {
[INFO] [stderr] 109 |             JsonValue::Array(_) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 | /         match self {
[INFO] [stderr] 116 | |             &JsonValue::Object(_) => true,
[INFO] [stderr] 117 | |             _ => false,
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 115 |         match *self {
[INFO] [stderr] 116 |             JsonValue::Object(_) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:126:19
[INFO] [stderr]     |
[INFO] [stderr] 126 |           let obj = match self {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 127 | |             &JsonValue::Object(ref o) => o,
[INFO] [stderr] 128 | |             _ => panic!("Attempted to access to an object with key '{}' but actually it was {:?}", key, self),
[INFO] [stderr] 129 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 126 |         let obj = match *self {
[INFO] [stderr] 127 |             JsonValue::Object(ref o) => o,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/json_value.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 | /     fn index<'a>(&'a self, key: String) -> &'a JsonValue {
[INFO] [stderr] 143 | |         // Note:
[INFO] [stderr] 144 | |         //   key   is 'String'
[INFO] [stderr] 145 | |         //   *key  is 'str'
[INFO] [stderr] 146 | |         //   &*key is '&str'
[INFO] [stderr] 147 | |         &self[&*key]
[INFO] [stderr] 148 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/json_value.rs:154:5
[INFO] [stderr]     |
[INFO] [stderr] 154 | /     fn index<'a>(&'a self, i: usize) -> &'a JsonValue {
[INFO] [stderr] 155 | |         let array = match self {
[INFO] [stderr] 156 | |             &JsonValue::Array(ref a) => a,
[INFO] [stderr] 157 | |             _ => panic!("Attempted to access to an array but actually the value was {:?}", self),
[INFO] [stderr] 158 | |         };
[INFO] [stderr] 159 | |         &array[i]
[INFO] [stderr] 160 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:155:21
[INFO] [stderr]     |
[INFO] [stderr] 155 |           let array = match self {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 156 | |             &JsonValue::Array(ref a) => a,
[INFO] [stderr] 157 | |             _ => panic!("Attempted to access to an array but actually the value was {:?}", self),
[INFO] [stderr] 158 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 155 |         let array = match *self {
[INFO] [stderr] 156 |             JsonValue::Array(ref a) => a,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:126:19
[INFO] [stderr]     |
[INFO] [stderr] 126 |           let obj = match self {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 127 | |             &JsonValue::Object(ref o) => o,
[INFO] [stderr] 128 | |             _ => panic!("Attempted to access to an object with key '{}' but actually it was {:?}", key, self),
[INFO] [stderr] 129 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 126 |         let obj = match *self {
[INFO] [stderr] 127 |             JsonValue::Object(ref o) => o,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/json_value.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 | /     fn index<'a>(&'a self, key: String) -> &'a JsonValue {
[INFO] [stderr] 143 | |         // Note:
[INFO] [stderr] 144 | |         //   key   is 'String'
[INFO] [stderr] 145 | |         //   *key  is 'str'
[INFO] [stderr] 146 | |         //   &*key is '&str'
[INFO] [stderr] 147 | |         &self[&*key]
[INFO] [stderr] 148 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/json_value.rs:154:5
[INFO] [stderr]     |
[INFO] [stderr] 154 | /     fn index<'a>(&'a self, i: usize) -> &'a JsonValue {
[INFO] [stderr] 155 | |         let array = match self {
[INFO] [stderr] 156 | |             &JsonValue::Array(ref a) => a,
[INFO] [stderr] 157 | |             _ => panic!("Attempted to access to an array but actually the value was {:?}", self),
[INFO] [stderr] 158 | |         };
[INFO] [stderr] 159 | |         &array[i]
[INFO] [stderr] 160 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/json_value.rs:155:21
[INFO] [stderr]     |
[INFO] [stderr] 155 |           let array = match self {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 156 | |             &JsonValue::Array(ref a) => a,
[INFO] [stderr] 157 | |             _ => panic!("Attempted to access to an array but actually the value was {:?}", self),
[INFO] [stderr] 158 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 155 |         let array = match *self {
[INFO] [stderr] 156 |             JsonValue::Array(ref a) => a,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> tests/value.rs:4:16
[INFO] [stderr]   |
[INFO] [stderr] 4 | const STR_OK: &'static str = r#"
[INFO] [stderr]   |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/parser.rs:40:16
[INFO] [stderr]    |
[INFO] [stderr] 40 | const STR_OK: &'static str = r#"
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `==`
[INFO] [stderr]   --> tests/value.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |     assert!(a == a);
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]   --> tests/value.rs:54:63
[INFO] [stderr]    |
[INFO] [stderr] 54 |     assert!(parsed["nested"]["blahblah"] == JsonValue::Number(3.14));
[INFO] [stderr]    |                                                               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> tests/value.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     &parsed["unknown key"]["not exist key"];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> tests/value.rs:75:9
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let ref v = parsed["nested"]["blah"];
[INFO] [stderr]    |     ----^^^^^---------------------------- help: try: `let v = &parsed["nested"]["blah"];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tinyjson`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "22542c95f9d186a6aafb0986a827095a97387f3450730dc8d95caea728729611"`
[INFO] running `"docker" "rm" "-f" "22542c95f9d186a6aafb0986a827095a97387f3450730dc8d95caea728729611"`
[INFO] [stdout] 22542c95f9d186a6aafb0986a827095a97387f3450730dc8d95caea728729611