[INFO] crate tint 1.0.1 is already in cache [INFO] extracting crate tint 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/tint/1.0.1 [INFO] extracting crate tint 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tint/1.0.1 [INFO] validating manifest of tint-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tint-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tint-1.0.1 [INFO] finished frobbing tint-1.0.1 [INFO] frobbed toml for tint-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/tint/1.0.1/Cargo.toml [INFO] started frobbing tint-1.0.1 [INFO] finished frobbing tint-1.0.1 [INFO] frobbed toml for tint-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tint/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tint-1.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tint/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07247943b51d1706ea0c4ece091fde835fa2ae5d49be29ec1db6af1e33134caa [INFO] running `"docker" "start" "-a" "07247943b51d1706ea0c4ece091fde835fa2ae5d49be29ec1db6af1e33134caa"` [INFO] [stderr] Checking tint v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:53 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:546:9 [INFO] [stderr] | [INFO] [stderr] 546 | let i = 0.74 * (r-y) - 0.27 * (b-y); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:547:9 [INFO] [stderr] | [INFO] [stderr] 547 | let q = 0.48 * (r-y) + 0.41 * (b-y); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:558:9 [INFO] [stderr] | [INFO] [stderr] 558 | let g = y + v22 * i + v23 * q; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:559:9 [INFO] [stderr] | [INFO] [stderr] 559 | let b = y + v32 * i + v33 * q; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:587:9 [INFO] [stderr] | [INFO] [stderr] 587 | let s = delta / cmax; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:589:13 [INFO] [stderr] | [INFO] [stderr] 589 | let mut h = if r >= cmax { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | let p = v * (1.0 - s); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:618:9 [INFO] [stderr] | [INFO] [stderr] 618 | let q = v * (1.0 - (s * ff)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:619:9 [INFO] [stderr] | [INFO] [stderr] 619 | let t = v * (1.0 - (s * (1.0 - ff))); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:639:9 [INFO] [stderr] | [INFO] [stderr] 639 | let d = cmax - cmin; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:640:13 [INFO] [stderr] | [INFO] [stderr] 640 | let mut s = d / (2.0 - cmax - cmin); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:644:13 [INFO] [stderr] | [INFO] [stderr] 644 | let mut h = [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:689:9 [INFO] [stderr] | [INFO] [stderr] 689 | let p = 2.0 * l - q; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:690:9 [INFO] [stderr] | [INFO] [stderr] 690 | let r = hue2rgb(p, q, h + 1./3.); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:691:9 [INFO] [stderr] | [INFO] [stderr] 691 | let g = hue2rgb(p, q, h); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:692:9 [INFO] [stderr] | [INFO] [stderr] 692 | let b = hue2rgb(p, q, h - 1./3.); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:74:53 [INFO] [stderr] | [INFO] [stderr] 74 | Color { red: red, green: green, blue: blue, alpha: alpha } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:546:9 [INFO] [stderr] | [INFO] [stderr] 546 | let i = 0.74 * (r-y) - 0.27 * (b-y); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:547:9 [INFO] [stderr] | [INFO] [stderr] 547 | let q = 0.48 * (r-y) + 0.41 * (b-y); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:558:9 [INFO] [stderr] | [INFO] [stderr] 558 | let g = y + v22 * i + v23 * q; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:559:9 [INFO] [stderr] | [INFO] [stderr] 559 | let b = y + v32 * i + v33 * q; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:587:9 [INFO] [stderr] | [INFO] [stderr] 587 | let s = delta / cmax; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:589:13 [INFO] [stderr] | [INFO] [stderr] 589 | let mut h = if r >= cmax { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | let p = v * (1.0 - s); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:618:9 [INFO] [stderr] | [INFO] [stderr] 618 | let q = v * (1.0 - (s * ff)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:619:9 [INFO] [stderr] | [INFO] [stderr] 619 | let t = v * (1.0 - (s * (1.0 - ff))); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:639:9 [INFO] [stderr] | [INFO] [stderr] 639 | let d = cmax - cmin; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:640:13 [INFO] [stderr] | [INFO] [stderr] 640 | let mut s = d / (2.0 - cmax - cmin); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:644:13 [INFO] [stderr] | [INFO] [stderr] 644 | let mut h = [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:689:9 [INFO] [stderr] | [INFO] [stderr] 689 | let p = 2.0 * l - q; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:690:9 [INFO] [stderr] | [INFO] [stderr] 690 | let r = hue2rgb(p, q, h + 1./3.); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:691:9 [INFO] [stderr] | [INFO] [stderr] 691 | let g = hue2rgb(p, q, h); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:692:9 [INFO] [stderr] | [INFO] [stderr] 692 | let b = hue2rgb(p, q, h - 1./3.); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:527:5 [INFO] [stderr] | [INFO] [stderr] 527 | return std::cmp::Ordering::Equal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::cmp::Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:551:16 [INFO] [stderr] | [INFO] [stderr] 551 | let v33 = 1.7090069284064666; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.709_006_928_406_466_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:552:16 [INFO] [stderr] | [INFO] [stderr] 552 | let v32 = -1.1085450346420322; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.108_545_034_642_032_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:553:16 [INFO] [stderr] | [INFO] [stderr] 553 | let v22 = -0.27478764629897834; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.274_787_646_298_978_34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:554:16 [INFO] [stderr] | [INFO] [stderr] 554 | let v23 = -0.6356910791873801; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.635_691_079_187_380_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:555:16 [INFO] [stderr] | [INFO] [stderr] 555 | let v13 = 0.6235565819861433; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.623_556_581_986_143_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:556:16 [INFO] [stderr] | [INFO] [stderr] 556 | let v12 = 0.9468822170900693; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.946_882_217_090_069_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:676:5 [INFO] [stderr] | [INFO] [stderr] 676 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:527:5 [INFO] [stderr] | [INFO] [stderr] 527 | return std::cmp::Ordering::Equal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::cmp::Ordering::Equal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:551:16 [INFO] [stderr] | [INFO] [stderr] 551 | let v33 = 1.7090069284064666; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.709_006_928_406_466_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:552:16 [INFO] [stderr] | [INFO] [stderr] 552 | let v32 = -1.1085450346420322; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.108_545_034_642_032_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:553:16 [INFO] [stderr] | [INFO] [stderr] 553 | let v22 = -0.27478764629897834; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.274_787_646_298_978_34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:554:16 [INFO] [stderr] | [INFO] [stderr] 554 | let v23 = -0.6356910791873801; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.635_691_079_187_380_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:555:16 [INFO] [stderr] | [INFO] [stderr] 555 | let v13 = 0.6235565819861433; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.623_556_581_986_143_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:556:16 [INFO] [stderr] | [INFO] [stderr] 556 | let v12 = 0.9468822170900693; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.946_882_217_090_069_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:676:5 [INFO] [stderr] | [INFO] [stderr] 676 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | Color::from_rgb1((red as f64)/255., [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | (green as f64)/255., [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | (blue as f64)/255.) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n` [INFO] [stderr] --> src/lib.rs:162:41 [INFO] [stderr] | [INFO] [stderr] 162 | let r = u8::from_str_radix(&hex[n+0..n+2],16).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:203:30 [INFO] [stderr] | [INFO] [stderr] 203 | Some(&c) => Some(c.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn from_hsv(&self) -> Color { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:226:21 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn from_hsl(&self) -> Color { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | pub fn from_yiq(&self) -> Color { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:295:26 [INFO] [stderr] | [INFO] [stderr] 295 | Color::from_rgb1(c.0 as f64, c.1 as f64, c.2 as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:295:38 [INFO] [stderr] | [INFO] [stderr] 295 | Color::from_rgb1(c.0 as f64, c.1 as f64, c.2 as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:295:50 [INFO] [stderr] | [INFO] [stderr] 295 | Color::from_rgb1(c.0 as f64, c.1 as f64, c.2 as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:315:20 [INFO] [stderr] | [INFO] [stderr] 315 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:315:33 [INFO] [stderr] | [INFO] [stderr] 315 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:315:46 [INFO] [stderr] | [INFO] [stderr] 315 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:333:20 [INFO] [stderr] | [INFO] [stderr] 333 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:333:33 [INFO] [stderr] | [INFO] [stderr] 333 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:333:46 [INFO] [stderr] | [INFO] [stderr] 333 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:355:30 [INFO] [stderr] | [INFO] [stderr] 355 | let c64 : Vec<_> = c.into_iter().map(|x| *x as f64).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:355:50 [INFO] [stderr] | [INFO] [stderr] 355 | let c64 : Vec<_> = c.into_iter().map(|x| *x as f64).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:372:50 [INFO] [stderr] | [INFO] [stderr] 372 | let c64 : Vec<_> = c.into_iter().map(|x| x as f64).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:492:17 [INFO] [stderr] | [INFO] [stderr] 492 | / if ! m.contains_key(&name) { [INFO] [stderr] 493 | | m.insert(name, color); [INFO] [stderr] 494 | | } [INFO] [stderr] | |_________________^ help: consider using: `m.entry(name).or_insert(color)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:614:5 [INFO] [stderr] | [INFO] [stderr] 614 | hh = hh / 60.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hh /= 60.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:640:5 [INFO] [stderr] | [INFO] [stderr] 640 | / let mut s = d / (2.0 - cmax - cmin); [INFO] [stderr] 641 | | if l <= 0.5 { [INFO] [stderr] 642 | | s = d / (cmax + cmin); [INFO] [stderr] 643 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let s = if l <= 0.5 { d / (cmax + cmin) } else { d / (2.0 - cmax - cmin) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:655:5 [INFO] [stderr] | [INFO] [stderr] 655 | h = h / 6.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `h /= 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | Color::from_rgb1((red as f64)/255., [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | (green as f64)/255., [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | (blue as f64)/255.) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n` [INFO] [stderr] --> src/lib.rs:162:41 [INFO] [stderr] | [INFO] [stderr] 162 | let r = u8::from_str_radix(&hex[n+0..n+2],16).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:203:30 [INFO] [stderr] | [INFO] [stderr] 203 | Some(&c) => Some(c.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn from_hsv(&self) -> Color { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:226:21 [INFO] [stderr] | [INFO] [stderr] 226 | pub fn from_hsl(&self) -> Color { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:237:21 [INFO] [stderr] | [INFO] [stderr] 237 | pub fn from_yiq(&self) -> Color { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:295:26 [INFO] [stderr] | [INFO] [stderr] 295 | Color::from_rgb1(c.0 as f64, c.1 as f64, c.2 as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:295:38 [INFO] [stderr] | [INFO] [stderr] 295 | Color::from_rgb1(c.0 as f64, c.1 as f64, c.2 as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:295:50 [INFO] [stderr] | [INFO] [stderr] 295 | Color::from_rgb1(c.0 as f64, c.1 as f64, c.2 as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:315:20 [INFO] [stderr] | [INFO] [stderr] 315 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:315:33 [INFO] [stderr] | [INFO] [stderr] 315 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:315:46 [INFO] [stderr] | [INFO] [stderr] 315 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:333:20 [INFO] [stderr] | [INFO] [stderr] 333 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:333:33 [INFO] [stderr] | [INFO] [stderr] 333 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:333:46 [INFO] [stderr] | [INFO] [stderr] 333 | Color::new(c[0] as f64, c[1] as f64, c[2] as f64, 1.0) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:355:30 [INFO] [stderr] | [INFO] [stderr] 355 | let c64 : Vec<_> = c.into_iter().map(|x| *x as f64).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:355:50 [INFO] [stderr] | [INFO] [stderr] 355 | let c64 : Vec<_> = c.into_iter().map(|x| *x as f64).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:372:50 [INFO] [stderr] | [INFO] [stderr] 372 | let c64 : Vec<_> = c.into_iter().map(|x| x as f64).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:492:17 [INFO] [stderr] | [INFO] [stderr] 492 | / if ! m.contains_key(&name) { [INFO] [stderr] 493 | | m.insert(name, color); [INFO] [stderr] 494 | | } [INFO] [stderr] | |_________________^ help: consider using: `m.entry(name).or_insert(color)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:614:5 [INFO] [stderr] | [INFO] [stderr] 614 | hh = hh / 60.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hh /= 60.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:640:5 [INFO] [stderr] | [INFO] [stderr] 640 | / let mut s = d / (2.0 - cmax - cmin); [INFO] [stderr] 641 | | if l <= 0.5 { [INFO] [stderr] 642 | | s = d / (cmax + cmin); [INFO] [stderr] 643 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let s = if l <= 0.5 { d / (cmax + cmin) } else { d / (2.0 - cmax - cmin) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:655:5 [INFO] [stderr] | [INFO] [stderr] 655 | h = h / 6.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `h /= 6.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:853:30 [INFO] [stderr] | [INFO] [stderr] 853 | let rf = r as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:854:30 [INFO] [stderr] | [INFO] [stderr] 854 | let gf = g as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:855:30 [INFO] [stderr] | [INFO] [stderr] 855 | let bf = b as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:871:30 [INFO] [stderr] | [INFO] [stderr] 871 | let rf = r as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:872:30 [INFO] [stderr] | [INFO] [stderr] 872 | let gf = g as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:873:30 [INFO] [stderr] | [INFO] [stderr] 873 | let bf = b as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:907:30 [INFO] [stderr] | [INFO] [stderr] 907 | let rf = r as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:908:30 [INFO] [stderr] | [INFO] [stderr] 908 | let gf = g as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:909:30 [INFO] [stderr] | [INFO] [stderr] 909 | let bf = b as f64/ 255.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "07247943b51d1706ea0c4ece091fde835fa2ae5d49be29ec1db6af1e33134caa"` [INFO] running `"docker" "rm" "-f" "07247943b51d1706ea0c4ece091fde835fa2ae5d49be29ec1db6af1e33134caa"` [INFO] [stdout] 07247943b51d1706ea0c4ece091fde835fa2ae5d49be29ec1db6af1e33134caa