[INFO] crate tiamat 0.2.0 is already in cache [INFO] extracting crate tiamat 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tiamat/0.2.0 [INFO] extracting crate tiamat 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiamat/0.2.0 [INFO] validating manifest of tiamat-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tiamat-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tiamat-0.2.0 [INFO] finished frobbing tiamat-0.2.0 [INFO] frobbed toml for tiamat-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tiamat/0.2.0/Cargo.toml [INFO] started frobbing tiamat-0.2.0 [INFO] finished frobbing tiamat-0.2.0 [INFO] frobbed toml for tiamat-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiamat/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tiamat-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tiamat/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60515ec4e8ad7f3e6629bcd958d2901372ff7f6e3daffec19212395773f2669a [INFO] running `"docker" "start" "-a" "60515ec4e8ad7f3e6629bcd958d2901372ff7f6e3daffec19212395773f2669a"` [INFO] [stderr] Checking tiamat v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/build_random.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] ... [INFO] [stderr] 132 | impl_random_for_halfopen!(f32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/build_random.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] ... [INFO] [stderr] 133 | impl_random_for_halfopen!(f64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/random.rs:125:56 [INFO] [stderr] | [INFO] [stderr] 125 | #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] ... [INFO] [stderr] 151 | impl_random_for_float!(f32, u32, 32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/random.rs:125:56 [INFO] [stderr] | [INFO] [stderr] 125 | #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] ... [INFO] [stderr] 152 | impl_random_for_float!(f64, u64, 64); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/random.rs:199:40 [INFO] [stderr] | [INFO] [stderr] 199 | fn random(_: &mut G) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/random.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/build_random.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] ... [INFO] [stderr] 132 | impl_random_for_halfopen!(f32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/build_random.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] ... [INFO] [stderr] 132 | impl_random_for_halfopen!(f32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/build_random.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] ... [INFO] [stderr] 133 | impl_random_for_halfopen!(f64); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/build_random.rs:253:32 [INFO] [stderr] | [INFO] [stderr] 253 | let mut rng = Pcg::new(0x1337BEEF, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1337_BEEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/build_random.rs:272:32 [INFO] [stderr] | [INFO] [stderr] 272 | let mut rng = Pcg::new(0x1337BEEF, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1337_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/build_random.rs:291:32 [INFO] [stderr] | [INFO] [stderr] 291 | let mut rng = Pcg::new(49849898165, 0); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `49_849_898_165` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/build_random.rs:311:32 [INFO] [stderr] | [INFO] [stderr] 311 | let mut rng = Pcg::new(123456789, 1234); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/build_random.rs:324:32 [INFO] [stderr] | [INFO] [stderr] 324 | let mut rng = Pcg::new(777888999, 444555666); [INFO] [stderr] | ^^^^^^^^^ help: consider: `777_888_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/build_random.rs:324:43 [INFO] [stderr] | [INFO] [stderr] 324 | let mut rng = Pcg::new(777888999, 444555666); [INFO] [stderr] | ^^^^^^^^^ help: consider: `444_555_666` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:144:20 [INFO] [stderr] | [INFO] [stderr] 144 | let seed = 0xBAD1DEA; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0BAD_1DEA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:145:24 [INFO] [stderr] | [INFO] [stderr] 145 | let sequence = 0xBEEFBEEF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBEEF_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:157:36 [INFO] [stderr] | [INFO] [stderr] 157 | let mut rng_one = Pcg::new(0xDEADBEEF, 0xD15EA5E); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:157:48 [INFO] [stderr] | [INFO] [stderr] 157 | let mut rng_one = Pcg::new(0xDEADBEEF, 0xD15EA5E); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0D15_EA5E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:172:32 [INFO] [stderr] | [INFO] [stderr] 172 | let rng_one = Pcg::new(0xDEADDEADBEEF, 0xBADBAD1DEA5); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xDEAD_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:172:48 [INFO] [stderr] | [INFO] [stderr] 172 | let rng_one = Pcg::new(0xDEADDEADBEEF, 0xBADBAD1DEA5); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0BAD_BAD1_DEA5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | let rng_one = Pcg::new(0x0123456789ABCDEF, 0x1FFFFFFF_C0000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0123_4567_89AB_CDEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/pcg.rs:187:52 [INFO] [stderr] | [INFO] [stderr] 187 | let rng_one = Pcg::new(0x0123456789ABCDEF, 0x1FFFFFFF_C0000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x1FFF_FFFF_C000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | let steps = 123456789; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/random.rs:125:56 [INFO] [stderr] | [INFO] [stderr] 125 | #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] ... [INFO] [stderr] 151 | impl_random_for_float!(f32, u32, 32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/random.rs:125:56 [INFO] [stderr] | [INFO] [stderr] 125 | #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] ... [INFO] [stderr] 152 | impl_random_for_float!(f64, u64, 64); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/random.rs:199:40 [INFO] [stderr] | [INFO] [stderr] 199 | fn random(_: &mut G) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/random.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:240:32 [INFO] [stderr] | [INFO] [stderr] 240 | let mut rng = Pcg::new(987654321, 1); [INFO] [stderr] | ^^^^^^^^^ help: consider: `987_654_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:252:32 [INFO] [stderr] | [INFO] [stderr] 252 | let mut rng = Pcg::new(123456789, 1); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/build_random.rs:119:56 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] ... [INFO] [stderr] 132 | impl_random_for_halfopen!(f32); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 98 | impl_build_random_for_integer_ranges!( u8, u8); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 99 | impl_build_random_for_integer_ranges!( u16, u16); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 100 | impl_build_random_for_integer_ranges!( u32, u32); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 101 | impl_build_random_for_integer_ranges!( u64, u64); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 102 | impl_build_random_for_integer_ranges!( u128, u128); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 103 | impl_build_random_for_integer_ranges!(usize, usize); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 104 | impl_build_random_for_integer_ranges!( i8, u8); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 105 | impl_build_random_for_integer_ranges!( i16, u16); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 106 | impl_build_random_for_integer_ranges!( i32, u32); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 107 | impl_build_random_for_integer_ranges!( i64, u64); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 108 | impl_build_random_for_integer_ranges!( i128, u128); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 109 | impl_build_random_for_integer_ranges!(isize, usize); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `os::OsRng` [INFO] [stderr] --> src/os.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> OsRng { [INFO] [stderr] 12 | | OsRng(internal::OsRng::new()) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for os::OsRng { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/random.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | ((rng.gen_u64() as u128) << 64) | (rng.gen_u64() as u128) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(rng.gen_u64())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/random.rs:89:43 [INFO] [stderr] | [INFO] [stderr] 89 | ((rng.gen_u64() as u128) << 64) | (rng.gen_u64() as u128) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(rng.gen_u64())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/random.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | while significand == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 151 | impl_random_for_float!(f32, u32, 32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/random.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | while significand == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 152 | impl_random_for_float!(f64, u64, 64); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/random.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | let sample = (0..(char::MAX as u32) + 1).build(rng); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=(char::MAX as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tiamat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 98 | impl_build_random_for_integer_ranges!( u8, u8); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 99 | impl_build_random_for_integer_ranges!( u16, u16); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 100 | impl_build_random_for_integer_ranges!( u32, u32); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 101 | impl_build_random_for_integer_ranges!( u64, u64); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 102 | impl_build_random_for_integer_ranges!( u128, u128); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 103 | impl_build_random_for_integer_ranges!(usize, usize); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 104 | impl_build_random_for_integer_ranges!( i8, u8); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 105 | impl_build_random_for_integer_ranges!( i16, u16); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 106 | impl_build_random_for_integer_ranges!( i32, u32); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 107 | impl_build_random_for_integer_ranges!( i64, u64); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 108 | impl_build_random_for_integer_ranges!( i128, u128); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | (*self.start()..*self.end() + 1).build(rng) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(*self.start()..=*self.end())` [INFO] [stderr] ... [INFO] [stderr] 109 | impl_build_random_for_integer_ranges!(isize, usize); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/build_random.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | assert!(sample <= ::std::u64::MAX); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because ::std::u64::MAX is the maximum value for this type, this comparison is always true [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/build_random.rs:314:27 [INFO] [stderr] | [INFO] [stderr] 314 | assert_eq!(x, (x..x + 1).build(&mut rng)); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(x..=x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/build_random.rs:327:21 [INFO] [stderr] | [INFO] [stderr] 327 | let y = x as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/build_random.rs:335:21 [INFO] [stderr] | [INFO] [stderr] 335 | let y = x as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `os::OsRng` [INFO] [stderr] --> src/os.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> OsRng { [INFO] [stderr] 12 | | OsRng(internal::OsRng::new()) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | impl Default for os::OsRng { [INFO] [stderr] 10 | fn default() -> Self { [INFO] [stderr] 11 | Self::new() [INFO] [stderr] 12 | } [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/random.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | ((rng.gen_u64() as u128) << 64) | (rng.gen_u64() as u128) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(rng.gen_u64())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/random.rs:89:43 [INFO] [stderr] | [INFO] [stderr] 89 | ((rng.gen_u64() as u128) << 64) | (rng.gen_u64() as u128) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(rng.gen_u64())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/random.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | while significand == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 151 | impl_random_for_float!(f32, u32, 32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/random.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | while significand == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 152 | impl_random_for_float!(f64, u64, 64); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/random.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | let sample = (0..(char::MAX as u32) + 1).build(rng); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=(char::MAX as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tiamat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "60515ec4e8ad7f3e6629bcd958d2901372ff7f6e3daffec19212395773f2669a"` [INFO] running `"docker" "rm" "-f" "60515ec4e8ad7f3e6629bcd958d2901372ff7f6e3daffec19212395773f2669a"` [INFO] [stdout] 60515ec4e8ad7f3e6629bcd958d2901372ff7f6e3daffec19212395773f2669a