[INFO] crate thumb2-stack-size 0.1.1 is already in cache [INFO] extracting crate thumb2-stack-size 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/thumb2-stack-size/0.1.1 [INFO] extracting crate thumb2-stack-size 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumb2-stack-size/0.1.1 [INFO] validating manifest of thumb2-stack-size-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thumb2-stack-size-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thumb2-stack-size-0.1.1 [INFO] finished frobbing thumb2-stack-size-0.1.1 [INFO] frobbed toml for thumb2-stack-size-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/thumb2-stack-size/0.1.1/Cargo.toml [INFO] started frobbing thumb2-stack-size-0.1.1 [INFO] finished frobbing thumb2-stack-size-0.1.1 [INFO] frobbed toml for thumb2-stack-size-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumb2-stack-size/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thumb2-stack-size-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/thumb2-stack-size/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e104956cbae0b6ae820f691eb8dfbda2f41cbc96c8edb447b3b6ead6dd3401fd [INFO] running `"docker" "start" "-a" "e104956cbae0b6ae820f691eb8dfbda2f41cbc96c8edb447b3b6ead6dd3401fd"` [INFO] [stderr] Checking zero v0.1.2 [INFO] [stderr] Checking xmas-elf v0.6.2 [INFO] [stderr] Checking thumb2-stack-size v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | 0b000000...0b111001 => 2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | 0b000000...0b111001 => 2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | 0b000000...0b111001 => 2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | 0b000000...0b111001 => 2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:454:20 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(0x000000aa, d(0<<10, 0b000 << 12 | 0xaa)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:455:20 [INFO] [stderr] | [INFO] [stderr] 455 | assert_eq!(0x00aa00aa, d(0<<10, 0b001 << 12 | 0xaa)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00aa_00aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:456:20 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!(0xaa00aa00, d(0<<10, 0b010 << 12 | 0xaa)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xaa00_aa00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:457:20 [INFO] [stderr] | [INFO] [stderr] 457 | assert_eq!(0xaaaaaaaa, d(0<<10, 0b011 << 12 | 0xaa)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xaaaa_aaaa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:458:20 [INFO] [stderr] | [INFO] [stderr] 458 | assert_eq!(0x81000000, d(0<<10, 0b100 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:459:20 [INFO] [stderr] | [INFO] [stderr] 459 | assert_eq!(0x40800000, d(0<<10, 0b100 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:460:20 [INFO] [stderr] | [INFO] [stderr] 460 | assert_eq!(0x20400000, d(0<<10, 0b101 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:461:20 [INFO] [stderr] | [INFO] [stderr] 461 | assert_eq!(0x10200000, d(0<<10, 0b101 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:462:20 [INFO] [stderr] | [INFO] [stderr] 462 | assert_eq!(0x08100000, d(0<<10, 0b110 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0810_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:463:20 [INFO] [stderr] | [INFO] [stderr] 463 | assert_eq!(0x04080000, d(0<<10, 0b110 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0408_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:464:20 [INFO] [stderr] | [INFO] [stderr] 464 | assert_eq!(0x02040000, d(0<<10, 0b111 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0204_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:465:20 [INFO] [stderr] | [INFO] [stderr] 465 | assert_eq!(0x01020000, d(0<<10, 0b111 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0102_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:466:20 [INFO] [stderr] | [INFO] [stderr] 466 | assert_eq!(0x00810000, d(1<<10, 0b000 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0081_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:467:20 [INFO] [stderr] | [INFO] [stderr] 467 | assert_eq!(0x00408000, d(1<<10, 0b000 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:468:20 [INFO] [stderr] | [INFO] [stderr] 468 | assert_eq!(0x00204000, d(1<<10, 0b001 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:469:20 [INFO] [stderr] | [INFO] [stderr] 469 | assert_eq!(0x00102000, d(1<<10, 0b001 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:470:20 [INFO] [stderr] | [INFO] [stderr] 470 | assert_eq!(0x00081000, d(1<<10, 0b010 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:471:20 [INFO] [stderr] | [INFO] [stderr] 471 | assert_eq!(0x00040800, d(1<<10, 0b010 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:472:20 [INFO] [stderr] | [INFO] [stderr] 472 | assert_eq!(0x00020400, d(1<<10, 0b011 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:473:20 [INFO] [stderr] | [INFO] [stderr] 473 | assert_eq!(0x00010200, d(1<<10, 0b011 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:474:20 [INFO] [stderr] | [INFO] [stderr] 474 | assert_eq!(0x00008100, d(1<<10, 0b100 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:475:20 [INFO] [stderr] | [INFO] [stderr] 475 | assert_eq!(0x00004080, d(1<<10, 0b100 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | assert_eq!(0x00002040, d(1<<10, 0b101 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:477:20 [INFO] [stderr] | [INFO] [stderr] 477 | assert_eq!(0x00001020, d(1<<10, 0b101 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:478:20 [INFO] [stderr] | [INFO] [stderr] 478 | assert_eq!(0x00000810, d(1<<10, 0b110 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0810` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:479:20 [INFO] [stderr] | [INFO] [stderr] 479 | assert_eq!(0x00000408, d(1<<10, 0b110 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0408` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:480:20 [INFO] [stderr] | [INFO] [stderr] 480 | assert_eq!(0x00000204, d(1<<10, 0b111 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0204` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/insn.rs:481:20 [INFO] [stderr] | [INFO] [stderr] 481 | assert_eq!(0x00000102, d(1<<10, 0b111 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0102` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/cfg.rs:92:56 [INFO] [stderr] | [INFO] [stderr] 92 | let block = block_set.entry(split).or_insert(Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Default::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cfg.rs:183:52 [INFO] [stderr] | [INFO] [stderr] 183 | Some(to) => if let Some(_) = insn_at(to) { [INFO] [stderr] | _____________________________________________- ^^^^^^^ [INFO] [stderr] 184 | | block.successors.push(to); [INFO] [stderr] 185 | | reachable.push_back(to); [INFO] [stderr] 186 | | }, [INFO] [stderr] | |_________________________________- help: try this: `if insn_at(to).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cfg.rs:194:52 [INFO] [stderr] | [INFO] [stderr] 194 | Some(to) => if let Some(_) = insn_at(to) { [INFO] [stderr] | _____________________________________________- ^^^^^^^ [INFO] [stderr] 195 | | block.successors.push(to); [INFO] [stderr] 196 | | reachable.push_back(to); [INFO] [stderr] 197 | | }, [INFO] [stderr] | |_________________________________- help: try this: `if insn_at(to).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(op[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(op[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(op[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(op[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | (i<<11 | imm3<<8 | imm8) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i<<11 | imm3<<8 | imm8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | let abcdefgh = (self.op.1 & 0xff) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.op.1 & 0xff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / (match kind { [INFO] [stderr] 64 | | 0b00000 | 0b00001 => abcdefgh, [INFO] [stderr] 65 | | 0b00010 | 0b00011 => abcdefgh<<16 | abcdefgh, [INFO] [stderr] 66 | | 0b00100 | 0b00101 => abcdefgh<<24 | abcdefgh<<8, [INFO] [stderr] 67 | | 0b00110 | 0b00111 => abcdefgh<<24 | abcdefgh<<16 | abcdefgh<<8 | abcdefgh, [INFO] [stderr] 68 | | _ => ((0x80 | abcdefgh) << 24) >> (kind - 0b01000), [INFO] [stderr] 69 | | }) as i64 [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | i64::from((match kind { [INFO] [stderr] 64 | 0b00000 | 0b00001 => abcdefgh, [INFO] [stderr] 65 | 0b00010 | 0b00011 => abcdefgh<<16 | abcdefgh, [INFO] [stderr] 66 | 0b00100 | 0b00101 => abcdefgh<<24 | abcdefgh<<8, [INFO] [stderr] 67 | 0b00110 | 0b00111 => abcdefgh<<24 | abcdefgh<<16 | abcdefgh<<8 | abcdefgh, [INFO] [stderr] 68 | _ => ((0x80 | abcdefgh) << 24) >> (kind - 0b01000), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 74 [INFO] [stderr] --> src/insn.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn effect(&self) -> InstructionEffect { [INFO] [stderr] 80 | | macro_rules! bits { [INFO] [stderr] 81 | | ( ($last:tt : $first:tt) $from:expr ) => {{ [INFO] [stderr] 82 | | let mut raw = [0; $last - $first + 1]; [INFO] [stderr] ... | [INFO] [stderr] 442 | | } [INFO] [stderr] 443 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(9..=9)` [INFO] [stderr] ... [INFO] [stderr] 108 | self.addr + 4 + (extract!((9:9, 7:3) op0 as u64) << 1) [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:108:50 [INFO] [stderr] | [INFO] [stderr] 108 | self.addr + 4 + (extract!((9:9, 7:3) op0 as u64) << 1) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(3..=7)` [INFO] [stderr] ... [INFO] [stderr] 108 | self.addr + 4 + (extract!((9:9, 7:3) op0 as u64) << 1) [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=immed_msb)` [INFO] [stderr] ... [INFO] [stderr] 111 | let offset_raw = extract!((immed_msb:0) op0 as u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:111:53 [INFO] [stderr] | [INFO] [stderr] 111 | let offset_raw = extract!((immed_msb:0) op0 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | let s = (op0 as u64 >> 10) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | let j1 = (op1 as u64 >> 13) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | let j2 = (op1 as u64 >> 11) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=5)` [INFO] [stderr] ... [INFO] [stderr] 120 | let imm6 = extract!((5:0) op0 as u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:120:39 [INFO] [stderr] | [INFO] [stderr] 120 | let imm6 = extract!((5:0) op0 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=10)` [INFO] [stderr] ... [INFO] [stderr] 121 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | let s = (op0 as u64 >> 10) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | let j1 = (op1 as u64 >> 13) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | let j2 = (op1 as u64 >> 11) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=9)` [INFO] [stderr] ... [INFO] [stderr] 133 | let imm10 = extract!((9:0) op0 as u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:133:40 [INFO] [stderr] | [INFO] [stderr] 133 | let imm10 = extract!((9:0) op0 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=10)` [INFO] [stderr] ... [INFO] [stderr] 134 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `10..=15` [INFO] [stderr] ... [INFO] [stderr] 150 | match bits!((15:10) op0) { [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `6..=9` [INFO] [stderr] ... [INFO] [stderr] 157 | match bits!((9:6) op0 ) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(7..=7)` [INFO] [stderr] ... [INFO] [stderr] 160 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=2)` [INFO] [stderr] ... [INFO] [stderr] 160 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(7..=7)` [INFO] [stderr] ... [INFO] [stderr] 170 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=2)` [INFO] [stderr] ... [INFO] [stderr] 170 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(3..=6)` [INFO] [stderr] ... [INFO] [stderr] 177 | match extract!((6:3) op0) { [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `5..=11` [INFO] [stderr] ... [INFO] [stderr] 195 | match bits!((11:5) op0) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:199:52 [INFO] [stderr] | [INFO] [stderr] 199 | [0,0,0,0,0,_,_] => e(Some(-4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 199 | [0,0,0,0,0,_,_] => e(Some(-4 * i64::from({ [INFO] [stderr] 200 | let mut result = 0; [INFO] [stderr] 201 | $( [INFO] [stderr] 202 | for i in ($first..$last+1).rev() { [INFO] [stderr] 203 | result <<= 1; [INFO] [stderr] 204 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=6)` [INFO] [stderr] ... [INFO] [stderr] 199 | [0,0,0,0,0,_,_] => e(Some(-4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:201:51 [INFO] [stderr] | [INFO] [stderr] 201 | [0,0,0,0,1,_,_] => e(Some(4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 201 | [0,0,0,0,1,_,_] => e(Some(4 * i64::from({ [INFO] [stderr] 202 | let mut result = 0; [INFO] [stderr] 203 | $( [INFO] [stderr] 204 | for i in ($first..$last+1).rev() { [INFO] [stderr] 205 | result <<= 1; [INFO] [stderr] 206 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=6)` [INFO] [stderr] ... [INFO] [stderr] 201 | [0,0,0,0,1,_,_] => e(Some(4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:209:51 [INFO] [stderr] | [INFO] [stderr] 209 | [0,1,0,_,_,_,_] => e(Some(4 * extract!((8:0) op0).count_ones() as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extract!((8:0) op0).count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=8)` [INFO] [stderr] ... [INFO] [stderr] 209 | [0,1,0,_,_,_,_] => e(Some(4 * extract!((8:0) op0).count_ones() as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:219:41 [INFO] [stderr] | [INFO] [stderr] 219 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Return) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extract!((8:0) op0).count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=8)` [INFO] [stderr] ... [INFO] [stderr] 219 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Return) [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:221:41 [INFO] [stderr] | [INFO] [stderr] 221 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Next) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extract!((8:0) op0).count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=8)` [INFO] [stderr] ... [INFO] [stderr] 221 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Next) [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/insn.rs:228:28 [INFO] [stderr] | [INFO] [stderr] 228 | if op0 & 0xf == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `op0.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `8..=11` [INFO] [stderr] ... [INFO] [stderr] 248 | match bits!((11:8) op0) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `11..=12` [INFO] [stderr] ... [INFO] [stderr] 260 | match (bits!((12:11) op0), bits!((10:4) op0), op1 >> 15) { [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=10` [INFO] [stderr] ... [INFO] [stderr] 260 | match (bits!((12:11) op0), bits!((10:4) op0), op1 >> 15) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `7..=8` [INFO] [stderr] ... [INFO] [stderr] 263 | match (bits!((8:7) op0), (op0 >> 5) & 1, op0 & 0b1111) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:268:56 [INFO] [stderr] | [INFO] [stderr] 268 | e(Some(direction * op1.count_ones() as i64), Return) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(op1.count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:270:56 [INFO] [stderr] | [INFO] [stderr] 270 | e(Some(direction * op1.count_ones() as i64), Next) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(op1.count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `7..=8` [INFO] [stderr] ... [INFO] [stderr] 278 | match (bits!((8:7) op0), bits!((5:4) op0), bits!((7:4) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=5` [INFO] [stderr] ... [INFO] [stderr] 278 | match (bits!((8:7) op0), bits!((5:4) op0), bits!((7:4) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=7` [INFO] [stderr] ... [INFO] [stderr] 278 | match (bits!((8:7) op0), bits!((5:4) op0), bits!((7:4) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:289:68 [INFO] [stderr] | [INFO] [stderr] 289 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 289 | (1, SP) => e(Some(-4 * i64::from({ [INFO] [stderr] 290 | let mut result = 0; [INFO] [stderr] 291 | $( [INFO] [stderr] 292 | for i in ($first..$last+1).rev() { [INFO] [stderr] 293 | result <<= 1; [INFO] [stderr] 294 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 289 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:291:67 [INFO] [stderr] | [INFO] [stderr] 291 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 291 | (0, SP) => e(Some(4 * i64::from({ [INFO] [stderr] 292 | let mut result = 0; [INFO] [stderr] 293 | $( [INFO] [stderr] 294 | for i in ($first..$last+1).rev() { [INFO] [stderr] 295 | result <<= 1; [INFO] [stderr] 296 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 291 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `5..=8` [INFO] [stderr] ... [INFO] [stderr] 307 | match (bits!((8:5) op0), (op0 >> 4) & 1, op0 & 0b1111, extract!((11:8) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(8..=11)` [INFO] [stderr] ... [INFO] [stderr] 307 | match (bits!((8:5) op0), (op0 >> 4) & 1, op0 & 0b1111, extract!((11:8) op1)) { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=9` [INFO] [stderr] ... [INFO] [stderr] 321 | match (bits!((9:4) op0), (op1 >> 4) & 1) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:331:68 [INFO] [stderr] | [INFO] [stderr] 331 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 331 | (1, SP) => e(Some(-4 * i64::from({ [INFO] [stderr] 332 | let mut result = 0; [INFO] [stderr] 333 | $( [INFO] [stderr] 334 | for i in ($first..$last+1).rev() { [INFO] [stderr] 335 | result <<= 1; [INFO] [stderr] 336 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 331 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:333:67 [INFO] [stderr] | [INFO] [stderr] 333 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 333 | (0, SP) => e(Some(4 * i64::from({ [INFO] [stderr] 334 | let mut result = 0; [INFO] [stderr] 335 | $( [INFO] [stderr] 336 | for i in ($first..$last+1).rev() { [INFO] [stderr] 337 | result <<= 1; [INFO] [stderr] 338 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 333 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=8` [INFO] [stderr] ... [INFO] [stderr] 349 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(8..=11)` [INFO] [stderr] ... [INFO] [stderr] 349 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=8` [INFO] [stderr] ... [INFO] [stderr] 359 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(8..=11)` [INFO] [stderr] ... [INFO] [stderr] 359 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `12..=14` [INFO] [stderr] ... [INFO] [stderr] 368 | match (bits!((14:12) op1), bits!((10:4) op0)) { [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=10` [INFO] [stderr] ... [INFO] [stderr] 368 | match (bits!((14:12) op1), bits!((10:4) op0)) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `5..=7` [INFO] [stderr] ... [INFO] [stderr] 389 | match (bits!((7:5) op0), bits!((11:6) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `6..=11` [INFO] [stderr] ... [INFO] [stderr] 389 | match (bits!((7:5) op0), bits!((11:6) op1)) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/insn.rs:398:63 [INFO] [stderr] | [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:398:68 [INFO] [stderr] | [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * i64::from({ [INFO] [stderr] 399 | let mut result = 0; [INFO] [stderr] 400 | $( [INFO] [stderr] 401 | for i in ($first..$last+1).rev() { [INFO] [stderr] 402 | result <<= 1; [INFO] [stderr] 403 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:400:63 [INFO] [stderr] | [INFO] [stderr] 400 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 400 | (0, SP) => e(Some(i64::from({ [INFO] [stderr] 401 | let mut result = 0; [INFO] [stderr] 402 | $( [INFO] [stderr] 403 | for i in ($first..$last+1).rev() { [INFO] [stderr] 404 | result <<= 1; [INFO] [stderr] 405 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 400 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `7..=8` [INFO] [stderr] ... [INFO] [stderr] 413 | match (bits!((8:7) op0), bits!((11:6) op1), op0 & 0xf, op1 >> 12) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `6..=11` [INFO] [stderr] ... [INFO] [stderr] 413 | match (bits!((8:7) op0), bits!((11:6) op1), op0 & 0xf, op1 >> 12) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/insn.rs:420:63 [INFO] [stderr] | [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:420:68 [INFO] [stderr] | [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * i64::from({ [INFO] [stderr] 421 | let mut result = 0; [INFO] [stderr] 422 | $( [INFO] [stderr] 423 | for i in ($first..$last+1).rev() { [INFO] [stderr] 424 | result <<= 1; [INFO] [stderr] 425 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:422:63 [INFO] [stderr] | [INFO] [stderr] 422 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 422 | (0, SP) => e(Some(i64::from({ [INFO] [stderr] 423 | let mut result = 0; [INFO] [stderr] 424 | $( [INFO] [stderr] 425 | for i in ($first..$last+1).rev() { [INFO] [stderr] 426 | result <<= 1; [INFO] [stderr] 427 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 422 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match f.read_to_end(&mut buf) { [INFO] [stderr] 48 | | Err(e) => return Err(LoadErr::Read(e)), [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = f.read_to_end(&mut buf) { return Err(LoadErr::Read(e)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | for (_, f) in &functions { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 262 | for f in functions.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/cfg.rs:92:56 [INFO] [stderr] | [INFO] [stderr] 92 | let block = block_set.entry(split).or_insert(Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Default::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cfg.rs:183:52 [INFO] [stderr] | [INFO] [stderr] 183 | Some(to) => if let Some(_) = insn_at(to) { [INFO] [stderr] | _____________________________________________- ^^^^^^^ [INFO] [stderr] 184 | | block.successors.push(to); [INFO] [stderr] 185 | | reachable.push_back(to); [INFO] [stderr] 186 | | }, [INFO] [stderr] | |_________________________________- help: try this: `if insn_at(to).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/cfg.rs:194:52 [INFO] [stderr] | [INFO] [stderr] 194 | Some(to) => if let Some(_) = insn_at(to) { [INFO] [stderr] | _____________________________________________- ^^^^^^^ [INFO] [stderr] 195 | | block.successors.push(to); [INFO] [stderr] 196 | | reachable.push_back(to); [INFO] [stderr] 197 | | }, [INFO] [stderr] | |_________________________________- help: try this: `if insn_at(to).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(op[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(op[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(op[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | op[0] as u16 | (op[1] as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(op[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | (i<<11 | imm3<<8 | imm8) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i<<11 | imm3<<8 | imm8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | let abcdefgh = (self.op.1 & 0xff) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.op.1 & 0xff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / (match kind { [INFO] [stderr] 64 | | 0b00000 | 0b00001 => abcdefgh, [INFO] [stderr] 65 | | 0b00010 | 0b00011 => abcdefgh<<16 | abcdefgh, [INFO] [stderr] 66 | | 0b00100 | 0b00101 => abcdefgh<<24 | abcdefgh<<8, [INFO] [stderr] 67 | | 0b00110 | 0b00111 => abcdefgh<<24 | abcdefgh<<16 | abcdefgh<<8 | abcdefgh, [INFO] [stderr] 68 | | _ => ((0x80 | abcdefgh) << 24) >> (kind - 0b01000), [INFO] [stderr] 69 | | }) as i64 [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | i64::from((match kind { [INFO] [stderr] 64 | 0b00000 | 0b00001 => abcdefgh, [INFO] [stderr] 65 | 0b00010 | 0b00011 => abcdefgh<<16 | abcdefgh, [INFO] [stderr] 66 | 0b00100 | 0b00101 => abcdefgh<<24 | abcdefgh<<8, [INFO] [stderr] 67 | 0b00110 | 0b00111 => abcdefgh<<24 | abcdefgh<<16 | abcdefgh<<8 | abcdefgh, [INFO] [stderr] 68 | _ => ((0x80 | abcdefgh) << 24) >> (kind - 0b01000), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 74 [INFO] [stderr] --> src/insn.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn effect(&self) -> InstructionEffect { [INFO] [stderr] 80 | | macro_rules! bits { [INFO] [stderr] 81 | | ( ($last:tt : $first:tt) $from:expr ) => {{ [INFO] [stderr] 82 | | let mut raw = [0; $last - $first + 1]; [INFO] [stderr] ... | [INFO] [stderr] 442 | | } [INFO] [stderr] 443 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(9..=9)` [INFO] [stderr] ... [INFO] [stderr] 108 | self.addr + 4 + (extract!((9:9, 7:3) op0 as u64) << 1) [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:108:50 [INFO] [stderr] | [INFO] [stderr] 108 | self.addr + 4 + (extract!((9:9, 7:3) op0 as u64) << 1) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(3..=7)` [INFO] [stderr] ... [INFO] [stderr] 108 | self.addr + 4 + (extract!((9:9, 7:3) op0 as u64) << 1) [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=immed_msb)` [INFO] [stderr] ... [INFO] [stderr] 111 | let offset_raw = extract!((immed_msb:0) op0 as u64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:111:53 [INFO] [stderr] | [INFO] [stderr] 111 | let offset_raw = extract!((immed_msb:0) op0 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | let s = (op0 as u64 >> 10) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | let j1 = (op1 as u64 >> 13) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | let j2 = (op1 as u64 >> 11) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=5)` [INFO] [stderr] ... [INFO] [stderr] 120 | let imm6 = extract!((5:0) op0 as u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:120:39 [INFO] [stderr] | [INFO] [stderr] 120 | let imm6 = extract!((5:0) op0 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=10)` [INFO] [stderr] ... [INFO] [stderr] 121 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | let s = (op0 as u64 >> 10) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | let j1 = (op1 as u64 >> 13) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | let j2 = (op1 as u64 >> 11) & 1; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=9)` [INFO] [stderr] ... [INFO] [stderr] 133 | let imm10 = extract!((9:0) op0 as u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:133:40 [INFO] [stderr] | [INFO] [stderr] 133 | let imm10 = extract!((9:0) op0 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=10)` [INFO] [stderr] ... [INFO] [stderr] 134 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | let imm11 = extract!((10:0) op1 as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(op1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `10..=15` [INFO] [stderr] ... [INFO] [stderr] 150 | match bits!((15:10) op0) { [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `6..=9` [INFO] [stderr] ... [INFO] [stderr] 157 | match bits!((9:6) op0 ) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(7..=7)` [INFO] [stderr] ... [INFO] [stderr] 160 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=2)` [INFO] [stderr] ... [INFO] [stderr] 160 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(7..=7)` [INFO] [stderr] ... [INFO] [stderr] 170 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=2)` [INFO] [stderr] ... [INFO] [stderr] 170 | match extract!((7:7, 2:0) op0) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(3..=6)` [INFO] [stderr] ... [INFO] [stderr] 177 | match extract!((6:3) op0) { [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `5..=11` [INFO] [stderr] ... [INFO] [stderr] 195 | match bits!((11:5) op0) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:199:52 [INFO] [stderr] | [INFO] [stderr] 199 | [0,0,0,0,0,_,_] => e(Some(-4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 199 | [0,0,0,0,0,_,_] => e(Some(-4 * i64::from({ [INFO] [stderr] 200 | let mut result = 0; [INFO] [stderr] 201 | $( [INFO] [stderr] 202 | for i in ($first..$last+1).rev() { [INFO] [stderr] 203 | result <<= 1; [INFO] [stderr] 204 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=6)` [INFO] [stderr] ... [INFO] [stderr] 199 | [0,0,0,0,0,_,_] => e(Some(-4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:201:51 [INFO] [stderr] | [INFO] [stderr] 201 | [0,0,0,0,1,_,_] => e(Some(4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 201 | [0,0,0,0,1,_,_] => e(Some(4 * i64::from({ [INFO] [stderr] 202 | let mut result = 0; [INFO] [stderr] 203 | $( [INFO] [stderr] 204 | for i in ($first..$last+1).rev() { [INFO] [stderr] 205 | result <<= 1; [INFO] [stderr] 206 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=6)` [INFO] [stderr] ... [INFO] [stderr] 201 | [0,0,0,0,1,_,_] => e(Some(4 * extract!((6:0) op0) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:209:51 [INFO] [stderr] | [INFO] [stderr] 209 | [0,1,0,_,_,_,_] => e(Some(4 * extract!((8:0) op0).count_ones() as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extract!((8:0) op0).count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=8)` [INFO] [stderr] ... [INFO] [stderr] 209 | [0,1,0,_,_,_,_] => e(Some(4 * extract!((8:0) op0).count_ones() as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:219:41 [INFO] [stderr] | [INFO] [stderr] 219 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Return) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extract!((8:0) op0).count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=8)` [INFO] [stderr] ... [INFO] [stderr] 219 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Return) [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:221:41 [INFO] [stderr] | [INFO] [stderr] 221 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Next) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(extract!((8:0) op0).count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=8)` [INFO] [stderr] ... [INFO] [stderr] 221 | e(Some(-4 * extract!((8:0) op0).count_ones() as i64), Next) [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/insn.rs:228:28 [INFO] [stderr] | [INFO] [stderr] 228 | if op0 & 0xf == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `op0.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `8..=11` [INFO] [stderr] ... [INFO] [stderr] 248 | match bits!((11:8) op0) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `11..=12` [INFO] [stderr] ... [INFO] [stderr] 260 | match (bits!((12:11) op0), bits!((10:4) op0), op1 >> 15) { [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=10` [INFO] [stderr] ... [INFO] [stderr] 260 | match (bits!((12:11) op0), bits!((10:4) op0), op1 >> 15) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `7..=8` [INFO] [stderr] ... [INFO] [stderr] 263 | match (bits!((8:7) op0), (op0 >> 5) & 1, op0 & 0b1111) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:268:56 [INFO] [stderr] | [INFO] [stderr] 268 | e(Some(direction * op1.count_ones() as i64), Return) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(op1.count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:270:56 [INFO] [stderr] | [INFO] [stderr] 270 | e(Some(direction * op1.count_ones() as i64), Next) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(op1.count_ones())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `7..=8` [INFO] [stderr] ... [INFO] [stderr] 278 | match (bits!((8:7) op0), bits!((5:4) op0), bits!((7:4) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=5` [INFO] [stderr] ... [INFO] [stderr] 278 | match (bits!((8:7) op0), bits!((5:4) op0), bits!((7:4) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=7` [INFO] [stderr] ... [INFO] [stderr] 278 | match (bits!((8:7) op0), bits!((5:4) op0), bits!((7:4) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:289:68 [INFO] [stderr] | [INFO] [stderr] 289 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 289 | (1, SP) => e(Some(-4 * i64::from({ [INFO] [stderr] 290 | let mut result = 0; [INFO] [stderr] 291 | $( [INFO] [stderr] 292 | for i in ($first..$last+1).rev() { [INFO] [stderr] 293 | result <<= 1; [INFO] [stderr] 294 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 289 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:291:67 [INFO] [stderr] | [INFO] [stderr] 291 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 291 | (0, SP) => e(Some(4 * i64::from({ [INFO] [stderr] 292 | let mut result = 0; [INFO] [stderr] 293 | $( [INFO] [stderr] 294 | for i in ($first..$last+1).rev() { [INFO] [stderr] 295 | result <<= 1; [INFO] [stderr] 296 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 291 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `5..=8` [INFO] [stderr] ... [INFO] [stderr] 307 | match (bits!((8:5) op0), (op0 >> 4) & 1, op0 & 0b1111, extract!((11:8) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(8..=11)` [INFO] [stderr] ... [INFO] [stderr] 307 | match (bits!((8:5) op0), (op0 >> 4) & 1, op0 & 0b1111, extract!((11:8) op1)) { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=9` [INFO] [stderr] ... [INFO] [stderr] 321 | match (bits!((9:4) op0), (op1 >> 4) & 1) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:331:68 [INFO] [stderr] | [INFO] [stderr] 331 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 331 | (1, SP) => e(Some(-4 * i64::from({ [INFO] [stderr] 332 | let mut result = 0; [INFO] [stderr] 333 | $( [INFO] [stderr] 334 | for i in ($first..$last+1).rev() { [INFO] [stderr] 335 | result <<= 1; [INFO] [stderr] 336 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 331 | (1, SP) => e(Some(-4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:333:67 [INFO] [stderr] | [INFO] [stderr] 333 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 333 | (0, SP) => e(Some(4 * i64::from({ [INFO] [stderr] 334 | let mut result = 0; [INFO] [stderr] 335 | $( [INFO] [stderr] 336 | for i in ($first..$last+1).rev() { [INFO] [stderr] 337 | result <<= 1; [INFO] [stderr] 338 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 333 | (0, SP) => e(Some(4 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=8` [INFO] [stderr] ... [INFO] [stderr] 349 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(8..=11)` [INFO] [stderr] ... [INFO] [stderr] 349 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=8` [INFO] [stderr] ... [INFO] [stderr] 359 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(8..=11)` [INFO] [stderr] ... [INFO] [stderr] 359 | match (bits!((8:4) op0), op0 & 0xf, extract!((11:8) op1)) { [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `12..=14` [INFO] [stderr] ... [INFO] [stderr] 368 | match (bits!((14:12) op1), bits!((10:4) op0)) { [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `4..=10` [INFO] [stderr] ... [INFO] [stderr] 368 | match (bits!((14:12) op1), bits!((10:4) op0)) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `5..=7` [INFO] [stderr] ... [INFO] [stderr] 389 | match (bits!((7:5) op0), bits!((11:6) op1)) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `6..=11` [INFO] [stderr] ... [INFO] [stderr] 389 | match (bits!((7:5) op0), bits!((11:6) op1)) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/insn.rs:398:63 [INFO] [stderr] | [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:398:68 [INFO] [stderr] | [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * i64::from({ [INFO] [stderr] 399 | let mut result = 0; [INFO] [stderr] 400 | $( [INFO] [stderr] 401 | for i in ($first..$last+1).rev() { [INFO] [stderr] 402 | result <<= 1; [INFO] [stderr] 403 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 398 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:400:63 [INFO] [stderr] | [INFO] [stderr] 400 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 400 | (0, SP) => e(Some(i64::from({ [INFO] [stderr] 401 | let mut result = 0; [INFO] [stderr] 402 | $( [INFO] [stderr] 403 | for i in ($first..$last+1).rev() { [INFO] [stderr] 404 | result <<= 1; [INFO] [stderr] 405 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 400 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `7..=8` [INFO] [stderr] ... [INFO] [stderr] 413 | match (bits!((8:7) op0), bits!((11:6) op1), op0 & 0xf, op1 >> 12) { [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | for i in $first..$last+1 { [INFO] [stderr] | ^ help: use: `6..=11` [INFO] [stderr] ... [INFO] [stderr] 413 | match (bits!((8:7) op0), bits!((11:6) op1), op0 & 0xf, op1 >> 12) { [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/insn.rs:420:63 [INFO] [stderr] | [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:420:68 [INFO] [stderr] | [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * i64::from({ [INFO] [stderr] 421 | let mut result = 0; [INFO] [stderr] 422 | $( [INFO] [stderr] 423 | for i in ($first..$last+1).rev() { [INFO] [stderr] 424 | result <<= 1; [INFO] [stderr] 425 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 420 | (1, SP) => e(Some(-1 * extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/insn.rs:422:63 [INFO] [stderr] | [INFO] [stderr] 422 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 422 | (0, SP) => e(Some(i64::from({ [INFO] [stderr] 423 | let mut result = 0; [INFO] [stderr] 424 | $( [INFO] [stderr] 425 | for i in ($first..$last+1).rev() { [INFO] [stderr] 426 | result <<= 1; [INFO] [stderr] 427 | result |= ($from >> i) & 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/insn.rs:94:30 [INFO] [stderr] | [INFO] [stderr] 94 | for i in ($first..$last+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0..=7)` [INFO] [stderr] ... [INFO] [stderr] 422 | (0, SP) => e(Some(extract!((7:0) op1) as i64), Next), [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/insn.rs:449:5 [INFO] [stderr] | [INFO] [stderr] 449 | / fn mod_immed_decode() { [INFO] [stderr] 450 | | fn d(op1: u16, op2: u16) -> i64 { [INFO] [stderr] 451 | | super::AsmInstruction{addr: 0, op: (op1, op2)}.mod_immed_value() [INFO] [stderr] 452 | | } [INFO] [stderr] ... | [INFO] [stderr] 481 | | assert_eq!(0x00000102, d(1<<10, 0b111 << 12 | 0x81)); [INFO] [stderr] 482 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0xaa` [INFO] [stderr] --> src/insn.rs:454:41 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(0x000000aa, d(0<<10, 0b000 << 12 | 0xaa)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x01` [INFO] [stderr] --> src/insn.rs:466:41 [INFO] [stderr] | [INFO] [stderr] 466 | assert_eq!(0x00810000, d(1<<10, 0b000 << 12 | 0x01)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0x81` [INFO] [stderr] --> src/insn.rs:467:41 [INFO] [stderr] | [INFO] [stderr] 467 | assert_eq!(0x00408000, d(1<<10, 0b000 << 12 | 0x81)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 99 [INFO] [stderr] --> src/insn.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | / fn insn_effect() { [INFO] [stderr] 486 | | use super::CfgEffect::*; [INFO] [stderr] 487 | | [INFO] [stderr] 488 | | fn i(addr: u64, op1: u16, op2: u16) -> super::InstructionEffect { [INFO] [stderr] ... | [INFO] [stderr] 642 | | t!(next(Some(0)), 0x1000: 0xfbb0 0xf0f0 | udiv r0, r0, r0); [INFO] [stderr] 643 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match f.read_to_end(&mut buf) { [INFO] [stderr] 48 | | Err(e) => return Err(LoadErr::Read(e)), [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = f.read_to_end(&mut buf) { return Err(LoadErr::Read(e)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:262:23 [INFO] [stderr] | [INFO] [stderr] 262 | for (_, f) in &functions { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 262 | for f in functions.values() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.28s [INFO] running `"docker" "inspect" "e104956cbae0b6ae820f691eb8dfbda2f41cbc96c8edb447b3b6ead6dd3401fd"` [INFO] running `"docker" "rm" "-f" "e104956cbae0b6ae820f691eb8dfbda2f41cbc96c8edb447b3b6ead6dd3401fd"` [INFO] [stdout] e104956cbae0b6ae820f691eb8dfbda2f41cbc96c8edb447b3b6ead6dd3401fd