[INFO] crate testbench 0.5.0 is already in cache [INFO] extracting crate testbench 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/testbench/0.5.0 [INFO] extracting crate testbench 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/testbench/0.5.0 [INFO] validating manifest of testbench-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of testbench-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing testbench-0.5.0 [INFO] finished frobbing testbench-0.5.0 [INFO] frobbed toml for testbench-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/testbench/0.5.0/Cargo.toml [INFO] started frobbing testbench-0.5.0 [INFO] finished frobbing testbench-0.5.0 [INFO] frobbed toml for testbench-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/testbench/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting testbench-0.5.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/testbench/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 654ce7f19e341fe0d901a83321820972673f77cf264ee96a99b6596ee6af4f29 [INFO] running `"docker" "start" "-a" "654ce7f19e341fe0d901a83321820972673f77cf264ee96a99b6596ee6af4f29"` [INFO] [stderr] Checking testbench v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:127:20 [INFO] [stderr] | [INFO] [stderr] 127 | total_duration.subsec_nanos() / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `total_duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/race_cell.rs:306:26 [INFO] [stderr] | [INFO] [stderr] 306 | for i in 1..(WRITES_COUNT+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=WRITES_COUNT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/race_cell.rs:345:26 [INFO] [stderr] | [INFO] [stderr] 345 | for i in 1..(WRITES_COUNT+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=WRITES_COUNT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:127:20 [INFO] [stderr] | [INFO] [stderr] 127 | total_duration.subsec_nanos() / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `total_duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:217:26 [INFO] [stderr] | [INFO] [stderr] 217 | for _ in 1..(ATOMIC_OPS_COUNT + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ATOMIC_OPS_COUNT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:225:26 [INFO] [stderr] | [INFO] [stderr] 225 | for _ in 1..(ATOMIC_OPS_COUNT + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ATOMIC_OPS_COUNT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | for _ in 1..(ATOMIC_OPS_COUNT + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ATOMIC_OPS_COUNT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:268:26 [INFO] [stderr] | [INFO] [stderr] 268 | for _ in 1..(ATOMIC_OPS_COUNT + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ATOMIC_OPS_COUNT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:279:26 [INFO] [stderr] | [INFO] [stderr] 279 | for _ in 1..(ATOMIC_OPS_COUNT + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ATOMIC_OPS_COUNT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "654ce7f19e341fe0d901a83321820972673f77cf264ee96a99b6596ee6af4f29"` [INFO] running `"docker" "rm" "-f" "654ce7f19e341fe0d901a83321820972673f77cf264ee96a99b6596ee6af4f29"` [INFO] [stdout] 654ce7f19e341fe0d901a83321820972673f77cf264ee96a99b6596ee6af4f29