[INFO] crate terminal_graphics 0.1.5 is already in cache [INFO] extracting crate terminal_graphics 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/terminal_graphics/0.1.5 [INFO] extracting crate terminal_graphics 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminal_graphics/0.1.5 [INFO] validating manifest of terminal_graphics-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terminal_graphics-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terminal_graphics-0.1.5 [INFO] finished frobbing terminal_graphics-0.1.5 [INFO] frobbed toml for terminal_graphics-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/terminal_graphics/0.1.5/Cargo.toml [INFO] started frobbing terminal_graphics-0.1.5 [INFO] finished frobbing terminal_graphics-0.1.5 [INFO] frobbed toml for terminal_graphics-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminal_graphics/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terminal_graphics-0.1.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/terminal_graphics/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f106df5ea72536dc0d580960a4fed54cbff452c83a7594b024e39893de33ec75 [INFO] running `"docker" "start" "-a" "f106df5ea72536dc0d580960a4fed54cbff452c83a7594b024e39893de33ec75"` [INFO] [stderr] Checking terminal_graphics v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/display/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub mod display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let red_1 = r as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | let blue_1 = b as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let green_1 = g as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | let red_2 = red as f64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:128:26 [INFO] [stderr] | [INFO] [stderr] 128 | let blue_2 = blue as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:129:27 [INFO] [stderr] | [INFO] [stderr] 129 | let green_2 = green as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display/colour.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn get_codes(&self) -> (u32, u32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display/colour.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn get_rbg(&self) -> (u8, u8, u8) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphics::container::Container<'a>` [INFO] [stderr] --> src/graphics/container.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Container<'static> { [INFO] [stderr] 24 | | Container { [INFO] [stderr] 25 | | pos_x: 0, [INFO] [stderr] 26 | | pos_y: 0, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for graphics::container::Container<'a> { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphics::text::Text` [INFO] [stderr] --> src/graphics/text.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Text { [INFO] [stderr] 14 | | Text { [INFO] [stderr] 15 | | pos_x: 0, [INFO] [stderr] 16 | | pos_y: 0, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for graphics::text::Text { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in text.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/graphics/text.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | for character in text.chars() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `graphics::Graphics` [INFO] [stderr] --> src/graphics/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Graphics { [INFO] [stderr] 52 | | Graphics { [INFO] [stderr] 53 | | graphics: HashMap::new(), [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/graphics/mod.rs:77:59 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn get_mut_named(&mut self, name: &str) -> Option<&mut Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Graphic` [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/display/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub mod display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/graphics/mod.rs:82:51 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn get_named(&self, name: &str) -> Option<&Box> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Graphic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let red_1 = r as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | let blue_1 = b as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | let green_1 = g as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | let red_2 = red as f64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:128:26 [INFO] [stderr] | [INFO] [stderr] 128 | let blue_2 = blue as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/display/colour.rs:129:27 [INFO] [stderr] | [INFO] [stderr] 129 | let green_2 = green as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display/colour.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn get_codes(&self) -> (u32, u32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/display/colour.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn get_rbg(&self) -> (u8, u8, u8) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphics::container::Container<'a>` [INFO] [stderr] --> src/graphics/container.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Container<'static> { [INFO] [stderr] 24 | | Container { [INFO] [stderr] 25 | | pos_x: 0, [INFO] [stderr] 26 | | pos_y: 0, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for graphics::container::Container<'a> { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphics::text::Text` [INFO] [stderr] --> src/graphics/text.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Text { [INFO] [stderr] 14 | | Text { [INFO] [stderr] 15 | | pos_x: 0, [INFO] [stderr] 16 | | pos_y: 0, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for graphics::text::Text { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in text.chars().enumerate()` or similar iterators [INFO] [stderr] --> src/graphics/text.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | for character in text.chars() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `graphics::Graphics` [INFO] [stderr] --> src/graphics/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Graphics { [INFO] [stderr] 52 | | Graphics { [INFO] [stderr] 53 | | graphics: HashMap::new(), [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/graphics/mod.rs:77:59 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn get_mut_named(&mut self, name: &str) -> Option<&mut Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Graphic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/graphics/mod.rs:82:51 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn get_named(&self, name: &str) -> Option<&Box> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Graphic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "f106df5ea72536dc0d580960a4fed54cbff452c83a7594b024e39893de33ec75"` [INFO] running `"docker" "rm" "-f" "f106df5ea72536dc0d580960a4fed54cbff452c83a7594b024e39893de33ec75"` [INFO] [stdout] f106df5ea72536dc0d580960a4fed54cbff452c83a7594b024e39893de33ec75