[INFO] crate termcolor 1.0.4 is already in cache [INFO] extracting crate termcolor 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/termcolor/1.0.4 [INFO] extracting crate termcolor 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termcolor/1.0.4 [INFO] validating manifest of termcolor-1.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of termcolor-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing termcolor-1.0.4 [INFO] finished frobbing termcolor-1.0.4 [INFO] frobbed toml for termcolor-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/termcolor/1.0.4/Cargo.toml [INFO] started frobbing termcolor-1.0.4 [INFO] finished frobbing termcolor-1.0.4 [INFO] frobbed toml for termcolor-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termcolor/1.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting termcolor-1.0.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/termcolor/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e139900c8dd656addc141ac78a0762d3de1661703b268e2517f6dc0da188bdfe [INFO] running `"docker" "start" "-a" "e139900c8dd656addc141ac78a0762d3de1661703b268e2517f6dc0da188bdfe"` [INFO] [stderr] Checking termcolor v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:795:13 [INFO] [stderr] | [INFO] [stderr] 795 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1732:31 [INFO] [stderr] | [INFO] [stderr] 1732 | LossyStandardStream { wtr: wtr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1740:31 [INFO] [stderr] | [INFO] [stderr] 1740 | LossyStandardStream { wtr: wtr, is_console: is_console } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1740:41 [INFO] [stderr] | [INFO] [stderr] 1740 | LossyStandardStream { wtr: wtr, is_console: is_console } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_console` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1750:31 [INFO] [stderr] | [INFO] [stderr] 1750 | LossyStandardStream { wtr: wtr, is_console: self.is_console } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:795:13 [INFO] [stderr] | [INFO] [stderr] 795 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1732:31 [INFO] [stderr] | [INFO] [stderr] 1732 | LossyStandardStream { wtr: wtr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1740:31 [INFO] [stderr] | [INFO] [stderr] 1740 | LossyStandardStream { wtr: wtr, is_console: is_console } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1740:41 [INFO] [stderr] | [INFO] [stderr] 1740 | LossyStandardStream { wtr: wtr, is_console: is_console } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_console` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1750:31 [INFO] [stderr] | [INFO] [stderr] 1750 | LossyStandardStream { wtr: wtr, is_console: self.is_console } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `wtr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1610:20 [INFO] [stderr] | [INFO] [stderr] 1610 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1611 | | if s.chars().all(|c| c.is_digit(16)) { [INFO] [stderr] 1612 | | Err(ParseColorError { [INFO] [stderr] 1613 | | kind: ParseColorErrorKind::InvalidAnsi256, [INFO] [stderr] ... | [INFO] [stderr] 1621 | | } [INFO] [stderr] 1622 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1610 | } else if s.chars().all(|c| c.is_digit(16)) { [INFO] [stderr] 1611 | Err(ParseColorError { [INFO] [stderr] 1612 | kind: ParseColorErrorKind::InvalidAnsi256, [INFO] [stderr] 1613 | given: s.to_string(), [INFO] [stderr] 1614 | }) [INFO] [stderr] 1615 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Invalid` [INFO] [stderr] --> src/lib.rs:1659:1 [INFO] [stderr] | [INFO] [stderr] 1659 | / enum ParseColorErrorKind { [INFO] [stderr] 1660 | | InvalidName, [INFO] [stderr] 1661 | | InvalidAnsi256, [INFO] [stderr] 1662 | | InvalidRgb, [INFO] [stderr] 1663 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1610:20 [INFO] [stderr] | [INFO] [stderr] 1610 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1611 | | if s.chars().all(|c| c.is_digit(16)) { [INFO] [stderr] 1612 | | Err(ParseColorError { [INFO] [stderr] 1613 | | kind: ParseColorErrorKind::InvalidAnsi256, [INFO] [stderr] ... | [INFO] [stderr] 1621 | | } [INFO] [stderr] 1622 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1610 | } else if s.chars().all(|c| c.is_digit(16)) { [INFO] [stderr] 1611 | Err(ParseColorError { [INFO] [stderr] 1612 | kind: ParseColorErrorKind::InvalidAnsi256, [INFO] [stderr] 1613 | given: s.to_string(), [INFO] [stderr] 1614 | }) [INFO] [stderr] 1615 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Invalid` [INFO] [stderr] --> src/lib.rs:1659:1 [INFO] [stderr] | [INFO] [stderr] 1659 | / enum ParseColorErrorKind { [INFO] [stderr] 1660 | | InvalidName, [INFO] [stderr] 1661 | | InvalidAnsi256, [INFO] [stderr] 1662 | | InvalidRgb, [INFO] [stderr] 1663 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | fn should_attempt_color(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/lib.rs:1189:5 [INFO] [stderr] | [INFO] [stderr] 1189 | / fn write_color( [INFO] [stderr] 1190 | | &mut self, [INFO] [stderr] 1191 | | fg: bool, [INFO] [stderr] 1192 | | c: &Color, [INFO] [stderr] ... | [INFO] [stderr] 1295 | | } [INFO] [stderr] 1296 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1192:12 [INFO] [stderr] | [INFO] [stderr] 1192 | c: &Color, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1277 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1277 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1278 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1278 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1291 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1291 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1292 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1292 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:1636:31 [INFO] [stderr] | [INFO] [stderr] 1636 | Err(if s.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | fn should_attempt_color(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/lib.rs:1189:5 [INFO] [stderr] | [INFO] [stderr] 1189 | / fn write_color( [INFO] [stderr] 1190 | | &mut self, [INFO] [stderr] 1191 | | fg: bool, [INFO] [stderr] 1192 | | c: &Color, [INFO] [stderr] ... | [INFO] [stderr] 1295 | | } [INFO] [stderr] 1296 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1192:12 [INFO] [stderr] | [INFO] [stderr] 1192 | c: &Color, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1277 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1277 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1278 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1278 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1291 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1291 | Color::Ansi256(c) => write_custom!(c), [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1292 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:1247:37 [INFO] [stderr] | [INFO] [stderr] 1247 | self.write_all(&fmt[0..i+1]) [INFO] [stderr] | ^^^^^^ help: use: `0..=i` [INFO] [stderr] ... [INFO] [stderr] 1292 | Color::Rgb(r, g, b) => write_custom!(r, g, b), [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:1636:31 [INFO] [stderr] | [INFO] [stderr] 1636 | Err(if s.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "e139900c8dd656addc141ac78a0762d3de1661703b268e2517f6dc0da188bdfe"` [INFO] running `"docker" "rm" "-f" "e139900c8dd656addc141ac78a0762d3de1661703b268e2517f6dc0da188bdfe"` [INFO] [stdout] e139900c8dd656addc141ac78a0762d3de1661703b268e2517f6dc0da188bdfe