[INFO] crate telegram_derive 0.2.0 is already in cache [INFO] extracting crate telegram_derive 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/telegram_derive/0.2.0 [INFO] extracting crate telegram_derive 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telegram_derive/0.2.0 [INFO] validating manifest of telegram_derive-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of telegram_derive-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing telegram_derive-0.2.0 [INFO] finished frobbing telegram_derive-0.2.0 [INFO] frobbed toml for telegram_derive-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/telegram_derive/0.2.0/Cargo.toml [INFO] started frobbing telegram_derive-0.2.0 [INFO] finished frobbing telegram_derive-0.2.0 [INFO] frobbed toml for telegram_derive-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telegram_derive/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting telegram_derive-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/telegram_derive/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 039e7a3473918cb0b43fcbef8ba583571418a43e4fbbfbcc907caae2634a0687 [INFO] running `"docker" "start" "-a" "039e7a3473918cb0b43fcbef8ba583571418a43e4fbbfbcc907caae2634a0687"` [INFO] [stderr] Checking telegram_derive v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | let ref variant_name = variant.ident; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------- help: try: `let variant_name = &variant.ident;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match attr.value { [INFO] [stderr] 115 | | MetaItem::NameValue(ref name, ref value) => { [INFO] [stderr] 116 | | if name.as_ref() == "id" { [INFO] [stderr] 117 | | if let Lit::Str(ref value, StrStyle::Cooked) = *value { [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let MetaItem::NameValue(ref name, ref value) = attr.value { [INFO] [stderr] 115 | if name.as_ref() == "id" { [INFO] [stderr] 116 | if let Lit::Str(ref value, StrStyle::Cooked) = *value { [INFO] [stderr] 117 | // Found an identifier [INFO] [stderr] 118 | let value = u32::from_str_radix(&value[2..], 16).unwrap(); [INFO] [stderr] 119 | id = Some(quote! { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | let ref variant_name = variant.ident; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------- help: try: `let variant_name = &variant.ident;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match attr.value { [INFO] [stderr] 115 | | MetaItem::NameValue(ref name, ref value) => { [INFO] [stderr] 116 | | if name.as_ref() == "id" { [INFO] [stderr] 117 | | if let Lit::Str(ref value, StrStyle::Cooked) = *value { [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let MetaItem::NameValue(ref name, ref value) = attr.value { [INFO] [stderr] 115 | if name.as_ref() == "id" { [INFO] [stderr] 116 | if let Lit::Str(ref value, StrStyle::Cooked) = *value { [INFO] [stderr] 117 | // Found an identifier [INFO] [stderr] 118 | let value = u32::from_str_radix(&value[2..], 16).unwrap(); [INFO] [stderr] 119 | id = Some(quote! { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "039e7a3473918cb0b43fcbef8ba583571418a43e4fbbfbcc907caae2634a0687"` [INFO] running `"docker" "rm" "-f" "039e7a3473918cb0b43fcbef8ba583571418a43e4fbbfbcc907caae2634a0687"` [INFO] [stdout] 039e7a3473918cb0b43fcbef8ba583571418a43e4fbbfbcc907caae2634a0687