[INFO] crate ted 0.7.0 is already in cache [INFO] extracting crate ted 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/ted/0.7.0 [INFO] extracting crate ted 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ted/0.7.0 [INFO] validating manifest of ted-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ted-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ted-0.7.0 [INFO] finished frobbing ted-0.7.0 [INFO] frobbed toml for ted-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/ted/0.7.0/Cargo.toml [INFO] started frobbing ted-0.7.0 [INFO] finished frobbing ted-0.7.0 [INFO] frobbed toml for ted-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ted/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ted-0.7.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ted/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89f8fef4f996ecb38135e5c19c2623d070e5d09abaf457f0e573c2da4b7dc770 [INFO] running `"docker" "start" "-a" "89f8fef4f996ecb38135e5c19c2623d070e5d09abaf457f0e573c2da4b7dc770"` [INFO] [stderr] Checking maybe-owned v0.3.2 [INFO] [stderr] Checking sequence_trie v0.3.6 [INFO] [stderr] Checking ropey v0.6.3 [INFO] [stderr] Checking frappe v0.3.1 [INFO] [stderr] Checking ted v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | text: text [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor/jump.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | trie: trie, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | text: text [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor/jump.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | trie: trie, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/buffer.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | match *&event { [INFO] [stderr] | ^^^^^^^ help: try this: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/buffer.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | match *&event { [INFO] [stderr] | ^^^^^^^ help: try this: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/buffer.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn from_str(text: &str) -> Self { [INFO] [stderr] 12 | | Self { [INFO] [stderr] 13 | | text: Rope::from_str(text), [INFO] [stderr] 14 | | event_sink: Sink::new() [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/buffer.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match &**self { [INFO] [stderr] 77 | | &Event::Insert { char_idx, ref text } if [INFO] [stderr] 78 | | char_idx <= idx [INFO] [stderr] 79 | | => idx + text.chars().count(), [INFO] [stderr] ... | [INFO] [stderr] 89 | | _ => idx [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | match **self { [INFO] [stderr] 77 | Event::Insert { char_idx, ref text } if [INFO] [stderr] 78 | char_idx <= idx [INFO] [stderr] 79 | => idx + text.chars().count(), [INFO] [stderr] 80 | [INFO] [stderr] 81 | Event::Remove { ref char_idx_range } if [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/buffer.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match &**self { [INFO] [stderr] 95 | | &Event::Insert { char_idx, ref text } if [INFO] [stderr] 96 | | char_idx <= self.text.line_to_char(line_idx) [INFO] [stderr] 97 | | => line_idx + text.matches('\n').count(), [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => line_idx [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | match **self { [INFO] [stderr] 95 | Event::Insert { char_idx, ref text } if [INFO] [stderr] 96 | char_idx <= self.text.line_to_char(line_idx) [INFO] [stderr] 97 | => line_idx + text.matches('\n').count(), [INFO] [stderr] 98 | [INFO] [stderr] 99 | Event::Remove { ref char_idx_range } if [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `history::History` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/history.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / impl History { [INFO] [stderr] 15 | | pub fn new() -> Self { [INFO] [stderr] 16 | | Self { [INFO] [stderr] 17 | | events: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `history::History` [INFO] [stderr] --> src/history.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self { [INFO] [stderr] 17 | | events: Vec::new(), [INFO] [stderr] 18 | | len: 0 [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cursor/jump.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match self { [INFO] [stderr] 102 | | &Next::Whitespace => char.is_whitespace(), [INFO] [stderr] 103 | | &Next::Word => char.is_alphanumeric() [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self { [INFO] [stderr] 102 | Next::Whitespace => char.is_whitespace(), [INFO] [stderr] 103 | Next::Word => char.is_alphanumeric() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cursor/jump.rs:212:30 [INFO] [stderr] | [INFO] [stderr] 212 | let found_iter = found_iter.iter().map(|idx| *idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `found_iter.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cursor/mod.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | line..line + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `line..=line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cursor/mod.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | char_idx_range: char_idx..char_idx + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `char_idx..=char_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cursor/mod.rs:112:45 [INFO] [stderr] | [INFO] [stderr] 112 | char_idx_range: char_idx..char_idx + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `char_idx..=char_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/cursor/mod.rs:143:28 [INFO] [stderr] | [INFO] [stderr] 143 | if { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 144 | | let line = buf.text().line(line_idx); [INFO] [stderr] 145 | | line.starts_with(&indent) [INFO] [stderr] 146 | | } { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] let line = buf.text().line(line_idx); [INFO] [stderr] line.starts_with(&indent) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] let line_start_idx = buf.text().line_to_char(line_idx); [INFO] [stderr] buf.handle(buffer::Event::Remove { [INFO] [stderr] char_idx_range: [INFO] [stderr] line_start_idx.. [INFO] [stderr] line_start_idx + indent.chars().count() [INFO] [stderr] }); [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/trie.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | let key = self.path.iter().chain(key.iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `key.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | // Event::Buf [INFO] [stderr] 38 | | &CursorCmd::Enter => Some(Event::Buf(BufferEvent::Insert('\n'.to_string()))), [INFO] [stderr] 39 | | &CursorCmd::Backspace => Some(Event::Buf(BufferEvent::Backspace)), [INFO] [stderr] ... | [INFO] [stderr] 111 | | &CursorCmd::SkipMultiCursor => cursor::jump::skip(cur, buf.text()) .map(CursorEvent::Jump).map(Event::Cur) [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | // Event::Buf [INFO] [stderr] 38 | CursorCmd::Enter => Some(Event::Buf(BufferEvent::Insert('\n'.to_string()))), [INFO] [stderr] 39 | CursorCmd::Backspace => Some(Event::Buf(BufferEvent::Backspace)), [INFO] [stderr] 40 | CursorCmd::Delete => Some(Event::Buf(BufferEvent::Delete)), [INFO] [stderr] 41 | CursorCmd::Indent(ref indent) => Some(Event::Buf(BufferEvent::Indent(indent.clone()))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:52:47 [INFO] [stderr] | [INFO] [stderr] 52 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:63:47 [INFO] [stderr] | [INFO] [stderr] 63 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:80:47 [INFO] [stderr] | [INFO] [stderr] 80 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:96:47 [INFO] [stderr] | [INFO] [stderr] 96 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:104:47 [INFO] [stderr] | [INFO] [stderr] 104 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::LineCache` [INFO] [stderr] --> src/cache.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Self { [INFO] [stderr] 10 | | Self { [INFO] [stderr] 11 | | lines: BTreeMap::new() [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cache.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | for line_idx in line_idc.start..self.lines.keys().max().unwrap_or(&line_idc.start) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line_idc.start..=self.lines.keys().max().unwrap_or(&line_idc.start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/buffer.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn from_str(text: &str) -> Self { [INFO] [stderr] 12 | | Self { [INFO] [stderr] 13 | | text: Rope::from_str(text), [INFO] [stderr] 14 | | event_sink: Sink::new() [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/buffer.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match &**self { [INFO] [stderr] 77 | | &Event::Insert { char_idx, ref text } if [INFO] [stderr] 78 | | char_idx <= idx [INFO] [stderr] 79 | | => idx + text.chars().count(), [INFO] [stderr] ... | [INFO] [stderr] 89 | | _ => idx [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | match **self { [INFO] [stderr] 77 | Event::Insert { char_idx, ref text } if [INFO] [stderr] 78 | char_idx <= idx [INFO] [stderr] 79 | => idx + text.chars().count(), [INFO] [stderr] 80 | [INFO] [stderr] 81 | Event::Remove { ref char_idx_range } if [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/buffer.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / match &**self { [INFO] [stderr] 95 | | &Event::Insert { char_idx, ref text } if [INFO] [stderr] 96 | | char_idx <= self.text.line_to_char(line_idx) [INFO] [stderr] 97 | | => line_idx + text.matches('\n').count(), [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => line_idx [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | match **self { [INFO] [stderr] 95 | Event::Insert { char_idx, ref text } if [INFO] [stderr] 96 | char_idx <= self.text.line_to_char(line_idx) [INFO] [stderr] 97 | => line_idx + text.matches('\n').count(), [INFO] [stderr] 98 | [INFO] [stderr] 99 | Event::Remove { ref char_idx_range } if [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `history::History` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/history.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / impl History { [INFO] [stderr] 15 | | pub fn new() -> Self { [INFO] [stderr] 16 | | Self { [INFO] [stderr] 17 | | events: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `history::History` [INFO] [stderr] --> src/history.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self { [INFO] [stderr] 17 | | events: Vec::new(), [INFO] [stderr] 18 | | len: 0 [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cursor/jump.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match self { [INFO] [stderr] 102 | | &Next::Whitespace => char.is_whitespace(), [INFO] [stderr] 103 | | &Next::Word => char.is_alphanumeric() [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self { [INFO] [stderr] 102 | Next::Whitespace => char.is_whitespace(), [INFO] [stderr] 103 | Next::Word => char.is_alphanumeric() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cursor/jump.rs:212:30 [INFO] [stderr] | [INFO] [stderr] 212 | let found_iter = found_iter.iter().map(|idx| *idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `found_iter.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cursor/mod.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | line..line + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `line..=line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cursor/mod.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | char_idx_range: char_idx..char_idx + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `char_idx..=char_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cursor/mod.rs:112:45 [INFO] [stderr] | [INFO] [stderr] 112 | char_idx_range: char_idx..char_idx + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `char_idx..=char_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/cursor/mod.rs:143:28 [INFO] [stderr] | [INFO] [stderr] 143 | if { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 144 | | let line = buf.text().line(line_idx); [INFO] [stderr] 145 | | line.starts_with(&indent) [INFO] [stderr] 146 | | } { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: try [INFO] [stderr] let res = { [INFO] [stderr] let line = buf.text().line(line_idx); [INFO] [stderr] line.starts_with(&indent) [INFO] [stderr] }; [INFO] [stderr] if res { [INFO] [stderr] let line_start_idx = buf.text().line_to_char(line_idx); [INFO] [stderr] buf.handle(buffer::Event::Remove { [INFO] [stderr] char_idx_range: [INFO] [stderr] line_start_idx.. [INFO] [stderr] line_start_idx + indent.chars().count() [INFO] [stderr] }); [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/cursor/mod.rs:283:31 [INFO] [stderr] | [INFO] [stderr] 283 | let cur = Cursor::new(&mut buf, positions.iter()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/cursor/mod.rs:291:35 [INFO] [stderr] | [INFO] [stderr] 291 | let mut cur = Cursor::new(&mut buf, &[(0, None)]); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `set_positions` doesn't need a mutable reference [INFO] [stderr] --> src/cursor/mod.rs:307:27 [INFO] [stderr] | [INFO] [stderr] 307 | cur.set_positions(&mut buf, &positions); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/cursor/mod.rs:318:35 [INFO] [stderr] | [INFO] [stderr] 318 | let mut cur = Cursor::new(&mut buf, &[(0, None)]); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `set_positions` doesn't need a mutable reference [INFO] [stderr] --> src/cursor/mod.rs:324:27 [INFO] [stderr] | [INFO] [stderr] 324 | cur.set_positions(&mut buf, &positions); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `set_positions` doesn't need a mutable reference [INFO] [stderr] --> src/cursor/mod.rs:339:27 [INFO] [stderr] | [INFO] [stderr] 339 | cur.set_positions(&mut buf, &positions); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/trie.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | let key = self.path.iter().chain(key.iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `key.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/command.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | // Event::Buf [INFO] [stderr] 38 | | &CursorCmd::Enter => Some(Event::Buf(BufferEvent::Insert('\n'.to_string()))), [INFO] [stderr] 39 | | &CursorCmd::Backspace => Some(Event::Buf(BufferEvent::Backspace)), [INFO] [stderr] ... | [INFO] [stderr] 111 | | &CursorCmd::SkipMultiCursor => cursor::jump::skip(cur, buf.text()) .map(CursorEvent::Jump).map(Event::Cur) [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | // Event::Buf [INFO] [stderr] 38 | CursorCmd::Enter => Some(Event::Buf(BufferEvent::Insert('\n'.to_string()))), [INFO] [stderr] 39 | CursorCmd::Backspace => Some(Event::Buf(BufferEvent::Backspace)), [INFO] [stderr] 40 | CursorCmd::Delete => Some(Event::Buf(BufferEvent::Delete)), [INFO] [stderr] 41 | CursorCmd::Indent(ref indent) => Some(Event::Buf(BufferEvent::Indent(indent.clone()))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:52:47 [INFO] [stderr] | [INFO] [stderr] 52 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:63:47 [INFO] [stderr] | [INFO] [stderr] 63 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:80:47 [INFO] [stderr] | [INFO] [stderr] 80 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:88:47 [INFO] [stderr] | [INFO] [stderr] 88 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:96:47 [INFO] [stderr] | [INFO] [stderr] 96 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/command.rs:104:47 [INFO] [stderr] | [INFO] [stderr] 104 | if select { sel_start.or(Some(char_idx)) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(char_idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::LineCache` [INFO] [stderr] --> src/cache.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Self { [INFO] [stderr] 10 | | Self { [INFO] [stderr] 11 | | lines: BTreeMap::new() [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cache.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | for line_idx in line_idc.start..self.lines.keys().max().unwrap_or(&line_idc.start) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line_idc.start..=self.lines.keys().max().unwrap_or(&line_idc.start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.38s [INFO] running `"docker" "inspect" "89f8fef4f996ecb38135e5c19c2623d070e5d09abaf457f0e573c2da4b7dc770"` [INFO] running `"docker" "rm" "-f" "89f8fef4f996ecb38135e5c19c2623d070e5d09abaf457f0e573c2da4b7dc770"` [INFO] [stdout] 89f8fef4f996ecb38135e5c19c2623d070e5d09abaf457f0e573c2da4b7dc770