[INFO] crate tar-parser 0.5.0 is already in cache [INFO] extracting crate tar-parser 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/tar-parser/0.5.0 [INFO] extracting crate tar-parser 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tar-parser/0.5.0 [INFO] validating manifest of tar-parser-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tar-parser-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tar-parser-0.5.0 [INFO] finished frobbing tar-parser-0.5.0 [INFO] frobbed toml for tar-parser-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/tar-parser/0.5.0/Cargo.toml [INFO] started frobbing tar-parser-0.5.0 [INFO] finished frobbing tar-parser-0.5.0 [INFO] frobbed toml for tar-parser-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tar-parser/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tar-parser-0.5.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tar-parser/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c00df8399c4a887b39a18d82118ba019a315f777c69bc22372267b819cc238c [INFO] running `"docker" "start" "-a" "7c00df8399c4a887b39a18d82118ba019a315f777c69bc22372267b819cc238c"` [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking tar-parser v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:408:19 [INFO] [stderr] | [INFO] [stderr] 408 | const EMPTY: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:146:67 [INFO] [stderr] | [INFO] [stderr] 146 | named!(take_oct_digit_value<&[u8], u64>, map!(take_oct_digit, |c| (c as u64) - ('0' as u64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:232:19 [INFO] [stderr] | [INFO] [stderr] 232 | fn add_to_vec<'a, 'b>(sparses: &'a mut Vec, extra: Vec) -> &'a mut Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:331:1 [INFO] [stderr] | [INFO] [stderr] 331 | / fn parse_header<'a>(i: &'a [u8]) -> IResult<&'a [u8], PosixHeader<'a>> { [INFO] [stderr] 332 | | do_parse!(i, [INFO] [stderr] 333 | | name: parse_str100 >> [INFO] [stderr] 334 | | mode: parse_octal8 >> [INFO] [stderr] ... | [INFO] [stderr] 356 | | ) [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/parser.rs:331:1 [INFO] [stderr] | [INFO] [stderr] 331 | / fn parse_header<'a>(i: &'a [u8]) -> IResult<&'a [u8], PosixHeader<'a>> { [INFO] [stderr] 332 | | do_parse!(i, [INFO] [stderr] 333 | | name: parse_str100 >> [INFO] [stderr] 334 | | mode: parse_octal8 >> [INFO] [stderr] ... | [INFO] [stderr] 356 | | ) [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e1` [INFO] [stderr] --> src/parser.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | let e1: &[u8] = b"8"; [INFO] [stderr] | ^^ help: consider using `_e1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:146:67 [INFO] [stderr] | [INFO] [stderr] 146 | named!(take_oct_digit_value<&[u8], u64>, map!(take_oct_digit, |c| (c as u64) - ('0' as u64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:232:19 [INFO] [stderr] | [INFO] [stderr] 232 | fn add_to_vec<'a, 'b>(sparses: &'a mut Vec, extra: Vec) -> &'a mut Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:331:1 [INFO] [stderr] | [INFO] [stderr] 331 | / fn parse_header<'a>(i: &'a [u8]) -> IResult<&'a [u8], PosixHeader<'a>> { [INFO] [stderr] 332 | | do_parse!(i, [INFO] [stderr] 333 | | name: parse_str100 >> [INFO] [stderr] 334 | | mode: parse_octal8 >> [INFO] [stderr] ... | [INFO] [stderr] 356 | | ) [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/parser.rs:331:1 [INFO] [stderr] | [INFO] [stderr] 331 | / fn parse_header<'a>(i: &'a [u8]) -> IResult<&'a [u8], PosixHeader<'a>> { [INFO] [stderr] 332 | | do_parse!(i, [INFO] [stderr] 333 | | name: parse_str100 >> [INFO] [stderr] 334 | | mode: parse_octal8 >> [INFO] [stderr] ... | [INFO] [stderr] 356 | | ) [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> src/parser.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | let baz = b"baz"; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.37s [INFO] running `"docker" "inspect" "7c00df8399c4a887b39a18d82118ba019a315f777c69bc22372267b819cc238c"` [INFO] running `"docker" "rm" "-f" "7c00df8399c4a887b39a18d82118ba019a315f777c69bc22372267b819cc238c"` [INFO] [stdout] 7c00df8399c4a887b39a18d82118ba019a315f777c69bc22372267b819cc238c