[INFO] crate systemd-parser 0.1.3 is already in cache [INFO] extracting crate systemd-parser 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/systemd-parser/0.1.3 [INFO] extracting crate systemd-parser 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemd-parser/0.1.3 [INFO] validating manifest of systemd-parser-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of systemd-parser-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing systemd-parser-0.1.3 [INFO] finished frobbing systemd-parser-0.1.3 [INFO] frobbed toml for systemd-parser-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/systemd-parser/0.1.3/Cargo.toml [INFO] started frobbing systemd-parser-0.1.3 [INFO] finished frobbing systemd-parser-0.1.3 [INFO] frobbed toml for systemd-parser-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemd-parser/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting systemd-parser-0.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/systemd-parser/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2c69efe7fe651d7e327642bb4ce495c589efa643e04d4c1273773a9448ba6d2 [INFO] running `"docker" "start" "-a" "c2c69efe7fe651d7e327642bb4ce495c589efa643e04d4c1273773a9448ba6d2"` [INFO] [stderr] Checking itertools v0.5.10 [INFO] [stderr] Checking systemd-parser v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/parser.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | (SystemdItem::Directive(key, (if value.is_empty() { None } else { Some(value) }))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/parser.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | (SystemdItem::Directive(key, (if value.is_empty() { None } else { Some(value) }))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_comment` [INFO] [stderr] --> src/items.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn is_comment(&self) -> bool { match *self { SystemdItem::Comment(_) => true, _ => false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_category` [INFO] [stderr] --> src/items.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | fn is_category(&self) -> bool { match *self { SystemdItem::Category(_) => true, _ => false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/errors.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | fn helper_format(errors: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParseErrorInternal]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:39:57 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn item_list_to_unit_directive_list(unit_items: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SystemdItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/items.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | return Err(format!("No directives in the file")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No directives in the file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | fn get_first_category<'b>(unit_items: &'b Vec>) -> Result<&'b str, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[SystemdItem<'b>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn new(unit_items: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SystemdItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:146:28 [INFO] [stderr] | [INFO] [stderr] 146 | fn validate_many(dirs: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[UnitDirective]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:87:8 [INFO] [stderr] | [INFO] [stderr] 87 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:103:15 [INFO] [stderr] | [INFO] [stderr] 103 | / if let &Error(Position(Alt, pattern)) = error { [INFO] [stderr] 104 | | let line_number = count_lines_by_pattern(pattern, input); [INFO] [stderr] 105 | | (error.clone(), line_number) [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | (error.clone(), 0) // FIXME: is it possible ? [INFO] [stderr] 108 | | } [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | if let Error(Position(Alt, pattern)) = *error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_comment` [INFO] [stderr] --> src/items.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn is_comment(&self) -> bool { match *self { SystemdItem::Comment(_) => true, _ => false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_category` [INFO] [stderr] --> src/items.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | fn is_category(&self) -> bool { match *self { SystemdItem::Category(_) => true, _ => false } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/errors.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | fn helper_format(errors: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParseErrorInternal]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:39:57 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn item_list_to_unit_directive_list(unit_items: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SystemdItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/items.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | return Err(format!("No directives in the file")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No directives in the file".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | fn get_first_category<'b>(unit_items: &'b Vec>) -> Result<&'b str, String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[SystemdItem<'b>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn new(unit_items: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SystemdItem]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/items.rs:146:28 [INFO] [stderr] | [INFO] [stderr] 146 | fn validate_many(dirs: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[UnitDirective]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:87:8 [INFO] [stderr] | [INFO] [stderr] 87 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:103:15 [INFO] [stderr] | [INFO] [stderr] 103 | / if let &Error(Position(Alt, pattern)) = error { [INFO] [stderr] 104 | | let line_number = count_lines_by_pattern(pattern, input); [INFO] [stderr] 105 | | (error.clone(), line_number) [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | (error.clone(), 0) // FIXME: is it possible ? [INFO] [stderr] 108 | | } [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | if let Error(Position(Alt, pattern)) = *error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser_test.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | res.unwrap().get(0).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.unwrap()[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser_test.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | res.unwrap().get(0).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.unwrap()[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser_test.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | res.unwrap().get(0).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.unwrap()[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser_test.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | res.unwrap_err().get(0).unwrap().1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.unwrap_err()[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser_test.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | res.unwrap_err().get(1).unwrap().1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.unwrap_err()[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | let expected = UnitDirective::new("Unit".into(), "Description".into(), Some("plop".into())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:27:62 [INFO] [stderr] | [INFO] [stderr] 27 | let expected = UnitDirective::new("Unit".into(), "Description".into(), Some("plop".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Description"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:27:89 [INFO] [stderr] | [INFO] [stderr] 27 | let expected = UnitDirective::new("Unit".into(), "Description".into(), Some("plop".into())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"plop"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:41:47 [INFO] [stderr] | [INFO] [stderr] 41 | let expected = UnitDirective::new("Unit".into(), "Wants".into(), Some("boot.target".into())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:41:62 [INFO] [stderr] | [INFO] [stderr] 41 | let expected = UnitDirective::new("Unit".into(), "Wants".into(), Some("boot.target".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Wants"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:41:83 [INFO] [stderr] | [INFO] [stderr] 41 | let expected = UnitDirective::new("Unit".into(), "Wants".into(), Some("boot.target".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"boot.target"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:56:47 [INFO] [stderr] | [INFO] [stderr] 56 | let expected = UnitDirective::new("Service".into(), "ExecStart".into(), Some("/usr/bin/true".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Service"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:56:65 [INFO] [stderr] | [INFO] [stderr] 56 | let expected = UnitDirective::new("Service".into(), "ExecStart".into(), Some("/usr/bin/true".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"ExecStart"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:56:90 [INFO] [stderr] | [INFO] [stderr] 56 | let expected = UnitDirective::new("Service".into(), "ExecStart".into(), Some("/usr/bin/true".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"/usr/bin/true"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | UnitDirective::new("Unit".into(), "Description".into(), Some("Some HTTP server".into())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:94:51 [INFO] [stderr] | [INFO] [stderr] 94 | UnitDirective::new("Unit".into(), "Description".into(), Some("Some HTTP server".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Description"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:94:78 [INFO] [stderr] | [INFO] [stderr] 94 | UnitDirective::new("Unit".into(), "Description".into(), Some("Some HTTP server".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Some HTTP server"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | UnitDirective::new("Unit".into(), "After".into(), Some("remote-fs.target sqldb.service memcached.service".into())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:95:51 [INFO] [stderr] | [INFO] [stderr] 95 | UnitDirective::new("Unit".into(), "After".into(), Some("remote-fs.target sqldb.service memcached.service".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `"After"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:95:72 [INFO] [stderr] | [INFO] [stderr] 95 | UnitDirective::new("Unit".into(), "After".into(), Some("remote-fs.target sqldb.service memcached.service".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"remote-fs.target sqldb.service memcached.service"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | UnitDirective::new("Unit".into(), "Requires".into(), None), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:96:51 [INFO] [stderr] | [INFO] [stderr] 96 | UnitDirective::new("Unit".into(), "Requires".into(), None), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Requires"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | UnitDirective::new("Unit".into(), "Requires".into(),"sqldb.service memcached.service".into()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:97:51 [INFO] [stderr] | [INFO] [stderr] 97 | UnitDirective::new("Unit".into(), "Requires".into(),"sqldb.service memcached.service".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Requires"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:98:36 [INFO] [stderr] | [INFO] [stderr] 98 | UnitDirective::new("Unit".into(), "AssertPathExists".into(),"/srv/www".into()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Unit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | UnitDirective::new("Unit".into(), "AssertPathExists".into(),"/srv/www".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"AssertPathExists"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | UnitDirective::new("Service".into(), "Type".into(), Some("notify".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Service"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:99:54 [INFO] [stderr] | [INFO] [stderr] 99 | UnitDirective::new("Service".into(), "Type".into(), Some("notify".into())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Type"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:99:74 [INFO] [stderr] | [INFO] [stderr] 99 | UnitDirective::new("Service".into(), "Type".into(), Some("notify".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"notify"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:100:36 [INFO] [stderr] | [INFO] [stderr] 100 | UnitDirective::new("Service".into(), "ExecStart".into(), Some("/usr/sbin/some-fancy-httpd-server".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Service"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:100:54 [INFO] [stderr] | [INFO] [stderr] 100 | UnitDirective::new("Service".into(), "ExecStart".into(), Some("/usr/sbin/some-fancy-httpd-server".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"ExecStart"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:100:79 [INFO] [stderr] | [INFO] [stderr] 100 | UnitDirective::new("Service".into(), "ExecStart".into(), Some("/usr/sbin/some-fancy-httpd-server".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"/usr/sbin/some-fancy-httpd-server"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | UnitDirective::new("Service".into(), "Nice".into(), Some("0".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Service"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:101:54 [INFO] [stderr] | [INFO] [stderr] 101 | UnitDirective::new("Service".into(), "Nice".into(), Some("0".into())), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `"Nice"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:101:74 [INFO] [stderr] | [INFO] [stderr] 101 | UnitDirective::new("Service".into(), "Nice".into(), Some("0".into())), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `"0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:102:36 [INFO] [stderr] | [INFO] [stderr] 102 | UnitDirective::new("Service".into(), "PrivateTmp".into(), Some("yes".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Service"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:102:54 [INFO] [stderr] | [INFO] [stderr] 102 | UnitDirective::new("Service".into(), "PrivateTmp".into(), Some("yes".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"PrivateTmp"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:102:80 [INFO] [stderr] | [INFO] [stderr] 102 | UnitDirective::new("Service".into(), "PrivateTmp".into(), Some("yes".into())), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `"yes"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:103:36 [INFO] [stderr] | [INFO] [stderr] 103 | UnitDirective::new("Install".into(), "WantedBy".into(), Some("multi-user.target".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Install"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | UnitDirective::new("Install".into(), "WantedBy".into(), Some("multi-user.target".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"WantedBy"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/items_test.rs:103:78 [INFO] [stderr] | [INFO] [stderr] 103 | UnitDirective::new("Install".into(), "WantedBy".into(), Some("multi-user.target".into())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"multi-user.target"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.23s [INFO] running `"docker" "inspect" "c2c69efe7fe651d7e327642bb4ce495c589efa643e04d4c1273773a9448ba6d2"` [INFO] running `"docker" "rm" "-f" "c2c69efe7fe651d7e327642bb4ce495c589efa643e04d4c1273773a9448ba6d2"` [INFO] [stdout] c2c69efe7fe651d7e327642bb4ce495c589efa643e04d4c1273773a9448ba6d2