[INFO] crate sxd-xpath 0.4.2 is already in cache [INFO] extracting crate sxd-xpath 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/sxd-xpath/0.4.2 [INFO] extracting crate sxd-xpath 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sxd-xpath/0.4.2 [INFO] validating manifest of sxd-xpath-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sxd-xpath-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sxd-xpath-0.4.2 [INFO] finished frobbing sxd-xpath-0.4.2 [INFO] frobbed toml for sxd-xpath-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/sxd-xpath/0.4.2/Cargo.toml [INFO] started frobbing sxd-xpath-0.4.2 [INFO] finished frobbing sxd-xpath-0.4.2 [INFO] frobbed toml for sxd-xpath-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sxd-xpath/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sxd-xpath-0.4.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sxd-xpath/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fabf09239e0612a78b2ffc7cdfe376def16d3926ad5eb6f8da509744eb6fbc3 [INFO] running `"docker" "start" "-a" "6fabf09239e0612a78b2ffc7cdfe376def16d3926ad5eb6f8da509744eb6fbc3"` [INFO] [stderr] Checking peresil v0.3.0 [INFO] [stderr] Checking typed-arena v1.4.1 [INFO] [stderr] Checking sxd-document v0.3.0 [INFO] [stderr] Checking sxd-xpath v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | node_test: node_test, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:177:26 [INFO] [stderr] | [INFO] [stderr] 177 | equal: Equal{left: left, right: right} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:177:38 [INFO] [stderr] | [INFO] [stderr] 177 | equal: Equal{left: left, right: right} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | Box::new(Math{left: left, right: right, operation: add}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:237:35 [INFO] [stderr] | [INFO] [stderr] 237 | Box::new(Math{left: left, right: right, operation: add}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:241:23 [INFO] [stderr] | [INFO] [stderr] 241 | Box::new(Math{left: left, right: right, operation: subtract}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | Box::new(Math{left: left, right: right, operation: subtract}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:245:23 [INFO] [stderr] | [INFO] [stderr] 245 | Box::new(Math{left: left, right: right, operation: multiply}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:245:35 [INFO] [stderr] | [INFO] [stderr] 245 | Box::new(Math{left: left, right: right, operation: multiply}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | Box::new(Math{left: left, right: right, operation: divide}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:249:35 [INFO] [stderr] | [INFO] [stderr] 249 | Box::new(Math{left: left, right: right, operation: divide}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:253:23 [INFO] [stderr] | [INFO] [stderr] 253 | Box::new(Math{left: left, right: right, operation: modulus}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:253:35 [INFO] [stderr] | [INFO] [stderr] 253 | Box::new(Math{left: left, right: right, operation: modulus}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:307:24 [INFO] [stderr] | [INFO] [stderr] 307 | Box::new(Path {start_point: start_point, steps: steps}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:307:50 [INFO] [stderr] | [INFO] [stderr] 307 | Box::new(Path {start_point: start_point, steps: steps}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:333:27 [INFO] [stderr] | [INFO] [stderr] 333 | Box::new(Filter { node_selector: node_selector, predicate: predicate }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_selector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:333:57 [INFO] [stderr] | [INFO] [stderr] 333 | Box::new(Filter { node_selector: node_selector, predicate: predicate }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:360:29 [INFO] [stderr] | [INFO] [stderr] 360 | Box::new(Relational{left: left, right: right, operation: less_than}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:360:41 [INFO] [stderr] | [INFO] [stderr] 360 | Box::new(Relational{left: left, right: right, operation: less_than}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:365:29 [INFO] [stderr] | [INFO] [stderr] 365 | Box::new(Relational{left: left, right: right, operation: less_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:365:41 [INFO] [stderr] | [INFO] [stderr] 365 | Box::new(Relational{left: left, right: right, operation: less_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | Box::new(Relational{left: left, right: right, operation: greater_than}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:370:41 [INFO] [stderr] | [INFO] [stderr] 370 | Box::new(Relational{left: left, right: right, operation: greater_than}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:375:29 [INFO] [stderr] | [INFO] [stderr] 375 | Box::new(Relational{left: left, right: right, operation: greater_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:375:41 [INFO] [stderr] | [INFO] [stderr] 375 | Box::new(Relational{left: left, right: right, operation: greater_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:449:29 [INFO] [stderr] | [INFO] [stderr] 449 | ParameterizedStep { axis: axis, node_test: node_test, predicates: preds } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:449:41 [INFO] [stderr] | [INFO] [stderr] 449 | ParameterizedStep { axis: axis, node_test: node_test, predicates: preds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:583:24 [INFO] [stderr] | [INFO] [stderr] 583 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:583:36 [INFO] [stderr] | [INFO] [stderr] 583 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:599:24 [INFO] [stderr] | [INFO] [stderr] 599 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:599:36 [INFO] [stderr] | [INFO] [stderr] 599 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:621:26 [INFO] [stderr] | [INFO] [stderr] 621 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:621:38 [INFO] [stderr] | [INFO] [stderr] 621 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:640:26 [INFO] [stderr] | [INFO] [stderr] 640 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:640:38 [INFO] [stderr] | [INFO] [stderr] 640 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:660:26 [INFO] [stderr] | [INFO] [stderr] 660 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:660:38 [INFO] [stderr] | [INFO] [stderr] 660 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:930:26 [INFO] [stderr] | [INFO] [stderr] 930 | let expr = Union{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:930:38 [INFO] [stderr] | [INFO] [stderr] 930 | let expr = Union{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:88:64 [INFO] [stderr] | [INFO] [stderr] 88 | Err(Error::NotEnoughArguments { expected: minimum, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:98:62 [INFO] [stderr] | [INFO] [stderr] 98 | Err(Error::TooManyArguments { expected: maximum, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:108:45 [INFO] [stderr] | [INFO] [stderr] 108 | Err(Error::NotEnoughArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:108:65 [INFO] [stderr] | [INFO] [stderr] 108 | Err(Error::NotEnoughArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:110:43 [INFO] [stderr] | [INFO] [stderr] 110 | Err(Error::TooManyArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:110:63 [INFO] [stderr] | [INFO] [stderr] 110 | Err(Error::TooManyArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node_test.rs:159:33 [INFO] [stderr] | [INFO] [stderr] 159 | ProcessingInstruction { target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:272:53 [INFO] [stderr] | [INFO] [stderr] 272 | Ok(Some(Box::new(expression::Variable { name: name }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:340:52 [INFO] [stderr] | [INFO] [stderr] 340 | Ok(Some(Box::new(expression::Function{ name: name, arguments: arguments }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:340:64 [INFO] [stderr] | [INFO] [stderr] 340 | Ok(Some(Box::new(expression::Function{ name: name, arguments: arguments }))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:771:17 [INFO] [stderr] | [INFO] [stderr] 771 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | node_test: node_test, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:177:26 [INFO] [stderr] | [INFO] [stderr] 177 | equal: Equal{left: left, right: right} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:177:38 [INFO] [stderr] | [INFO] [stderr] 177 | equal: Equal{left: left, right: right} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | Box::new(Math{left: left, right: right, operation: add}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:237:35 [INFO] [stderr] | [INFO] [stderr] 237 | Box::new(Math{left: left, right: right, operation: add}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:241:23 [INFO] [stderr] | [INFO] [stderr] 241 | Box::new(Math{left: left, right: right, operation: subtract}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | Box::new(Math{left: left, right: right, operation: subtract}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:245:23 [INFO] [stderr] | [INFO] [stderr] 245 | Box::new(Math{left: left, right: right, operation: multiply}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:245:35 [INFO] [stderr] | [INFO] [stderr] 245 | Box::new(Math{left: left, right: right, operation: multiply}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | Box::new(Math{left: left, right: right, operation: divide}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:249:35 [INFO] [stderr] | [INFO] [stderr] 249 | Box::new(Math{left: left, right: right, operation: divide}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:253:23 [INFO] [stderr] | [INFO] [stderr] 253 | Box::new(Math{left: left, right: right, operation: modulus}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:253:35 [INFO] [stderr] | [INFO] [stderr] 253 | Box::new(Math{left: left, right: right, operation: modulus}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:307:24 [INFO] [stderr] | [INFO] [stderr] 307 | Box::new(Path {start_point: start_point, steps: steps}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:307:50 [INFO] [stderr] | [INFO] [stderr] 307 | Box::new(Path {start_point: start_point, steps: steps}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:333:27 [INFO] [stderr] | [INFO] [stderr] 333 | Box::new(Filter { node_selector: node_selector, predicate: predicate }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_selector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:333:57 [INFO] [stderr] | [INFO] [stderr] 333 | Box::new(Filter { node_selector: node_selector, predicate: predicate }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:360:29 [INFO] [stderr] | [INFO] [stderr] 360 | Box::new(Relational{left: left, right: right, operation: less_than}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:360:41 [INFO] [stderr] | [INFO] [stderr] 360 | Box::new(Relational{left: left, right: right, operation: less_than}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:365:29 [INFO] [stderr] | [INFO] [stderr] 365 | Box::new(Relational{left: left, right: right, operation: less_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:365:41 [INFO] [stderr] | [INFO] [stderr] 365 | Box::new(Relational{left: left, right: right, operation: less_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | Box::new(Relational{left: left, right: right, operation: greater_than}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:370:41 [INFO] [stderr] | [INFO] [stderr] 370 | Box::new(Relational{left: left, right: right, operation: greater_than}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:375:29 [INFO] [stderr] | [INFO] [stderr] 375 | Box::new(Relational{left: left, right: right, operation: greater_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:375:41 [INFO] [stderr] | [INFO] [stderr] 375 | Box::new(Relational{left: left, right: right, operation: greater_than_or_equal}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:449:29 [INFO] [stderr] | [INFO] [stderr] 449 | ParameterizedStep { axis: axis, node_test: node_test, predicates: preds } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:449:41 [INFO] [stderr] | [INFO] [stderr] 449 | ParameterizedStep { axis: axis, node_test: node_test, predicates: preds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node_test` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:583:24 [INFO] [stderr] | [INFO] [stderr] 583 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:583:36 [INFO] [stderr] | [INFO] [stderr] 583 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:599:24 [INFO] [stderr] | [INFO] [stderr] 599 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:599:36 [INFO] [stderr] | [INFO] [stderr] 599 | let expr = And{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:621:26 [INFO] [stderr] | [INFO] [stderr] 621 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:621:38 [INFO] [stderr] | [INFO] [stderr] 621 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:640:26 [INFO] [stderr] | [INFO] [stderr] 640 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:640:38 [INFO] [stderr] | [INFO] [stderr] 640 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:660:26 [INFO] [stderr] | [INFO] [stderr] 660 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:660:38 [INFO] [stderr] | [INFO] [stderr] 660 | let expr = Equal{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:930:26 [INFO] [stderr] | [INFO] [stderr] 930 | let expr = Union{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expression.rs:930:38 [INFO] [stderr] | [INFO] [stderr] 930 | let expr = Union{left: left, right: right}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:88:64 [INFO] [stderr] | [INFO] [stderr] 88 | Err(Error::NotEnoughArguments { expected: minimum, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:98:62 [INFO] [stderr] | [INFO] [stderr] 98 | Err(Error::TooManyArguments { expected: maximum, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:108:45 [INFO] [stderr] | [INFO] [stderr] 108 | Err(Error::NotEnoughArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:108:65 [INFO] [stderr] | [INFO] [stderr] 108 | Err(Error::NotEnoughArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:110:43 [INFO] [stderr] | [INFO] [stderr] 110 | Err(Error::TooManyArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/function.rs:110:63 [INFO] [stderr] | [INFO] [stderr] 110 | Err(Error::TooManyArguments { expected: expected, actual: actual }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node_test.rs:159:33 [INFO] [stderr] | [INFO] [stderr] 159 | ProcessingInstruction { target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:272:53 [INFO] [stderr] | [INFO] [stderr] 272 | Ok(Some(Box::new(expression::Variable { name: name }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:340:52 [INFO] [stderr] | [INFO] [stderr] 340 | Ok(Some(Box::new(expression::Function{ name: name, arguments: arguments }))) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:340:64 [INFO] [stderr] | [INFO] [stderr] 340 | Ok(Some(Box::new(expression::Function{ name: name, arguments: arguments }))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:771:17 [INFO] [stderr] | [INFO] [stderr] 771 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | _temp [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/expression.rs:837:43 [INFO] [stderr] | [INFO] [stderr] 837 | assert_eq!(res, Ok(Value::Nodeset(nodeset![]))); [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:6:25 [INFO] [stderr] | [INFO] [stderr] 6 | let mut _temp = $crate::nodeset::Nodeset::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/expression.rs:837:43 [INFO] [stderr] | [INFO] [stderr] 837 | assert_eq!(res, Ok(Value::Nodeset(nodeset![]))); [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | _temp [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/function.rs:733:43 [INFO] [stderr] | [INFO] [stderr] 733 | evaluate_literal(LocalName, args![nodeset![]], |r| { [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:6:25 [INFO] [stderr] | [INFO] [stderr] 6 | let mut _temp = $crate::nodeset::Nodeset::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/function.rs:733:43 [INFO] [stderr] | [INFO] [stderr] 733 | evaluate_literal(LocalName, args![nodeset![]], |r| { [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | _temp [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/parser.rs:1162:20 [INFO] [stderr] | [INFO] [stderr] 1162 | assert_eq!(nodeset![], ex.evaluate_on(expr, doc.top_node())); [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:6:25 [INFO] [stderr] | [INFO] [stderr] 6 | let mut _temp = $crate::nodeset::Nodeset::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/parser.rs:1162:20 [INFO] [stderr] | [INFO] [stderr] 1162 | assert_eq!(nodeset![], ex.evaluate_on(expr, doc.top_node())); [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | _temp [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/parser.rs:1626:20 [INFO] [stderr] | [INFO] [stderr] 1626 | assert_eq!(nodeset![], ex.evaluate(expr)); [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:6:25 [INFO] [stderr] | [INFO] [stderr] 6 | let mut _temp = $crate::nodeset::Nodeset::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/parser.rs:1626:20 [INFO] [stderr] | [INFO] [stderr] 1626 | assert_eq!(nodeset![], ex.evaluate(expr)); [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/nodeset.rs:324:25 [INFO] [stderr] | [INFO] [stderr] 324 | return Some(node.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/nodeset.rs:447:21 [INFO] [stderr] | [INFO] [stderr] 447 | self.0.push(node.into()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 91 | binary_constructor!(And); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 117 | binary_constructor!(Equal); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/expression.rs:145:40 [INFO] [stderr] | [INFO] [stderr] 145 | numbers.iter().any(|n| *n == val) [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(*n - val).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/expression.rs:145:40 [INFO] [stderr] | [INFO] [stderr] 145 | numbers.iter().any(|n| *n == val) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/expression.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | (_, &Number(_)) => left_val.number() == right_val.number(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(left_val.number() - right_val.number()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/expression.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | (_, &Number(_)) => left_val.number() == right_val.number(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 176 | | Box::new(NotEqual { [INFO] [stderr] 177 | | equal: Equal{left: left, right: right} [INFO] [stderr] 178 | | }) [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 289 | binary_constructor!(Or); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / pub fn new(start_point: SubExpression, steps: Vec) -> SubExpression { [INFO] [stderr] 307 | | Box::new(Path {start_point: start_point, steps: steps}) [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / pub fn new(node_selector: SubExpression, predicate: SubExpression) -> SubExpression { [INFO] [stderr] 332 | | let predicate = Predicate { expression: predicate }; [INFO] [stderr] 333 | | Box::new(Filter { node_selector: node_selector, predicate: predicate }) [INFO] [stderr] 334 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 484 | binary_constructor!(Union); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/function.rs:563:8 [INFO] [stderr] | [INFO] [stderr] 563 | if x == y { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(x - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/function.rs:563:8 [INFO] [stderr] | [INFO] [stderr] 563 | if x == y { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/node_test.rs:167:35 [INFO] [stderr] | [INFO] [stderr] 167 | Some(ref name) if name == &pi.target() => result.add(context.node), [INFO] [stderr] | ^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `pi.target()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sxd-xpath`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/nodeset.rs:324:25 [INFO] [stderr] | [INFO] [stderr] 324 | return Some(node.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/nodeset.rs:447:21 [INFO] [stderr] | [INFO] [stderr] 447 | self.0.push(node.into()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 91 | binary_constructor!(And); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 117 | binary_constructor!(Equal); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/expression.rs:145:40 [INFO] [stderr] | [INFO] [stderr] 145 | numbers.iter().any(|n| *n == val) [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(*n - val).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/expression.rs:145:40 [INFO] [stderr] | [INFO] [stderr] 145 | numbers.iter().any(|n| *n == val) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/expression.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | (_, &Number(_)) => left_val.number() == right_val.number(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(left_val.number() - right_val.number()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/expression.rs:155:32 [INFO] [stderr] | [INFO] [stderr] 155 | (_, &Number(_)) => left_val.number() == right_val.number(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 176 | | Box::new(NotEqual { [INFO] [stderr] 177 | | equal: Equal{left: left, right: right} [INFO] [stderr] 178 | | }) [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 289 | binary_constructor!(Or); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / pub fn new(start_point: SubExpression, steps: Vec) -> SubExpression { [INFO] [stderr] 307 | | Box::new(Path {start_point: start_point, steps: steps}) [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / pub fn new(node_selector: SubExpression, predicate: SubExpression) -> SubExpression { [INFO] [stderr] 332 | | let predicate = Predicate { expression: predicate }; [INFO] [stderr] 333 | | Box::new(Filter { node_selector: node_selector, predicate: predicate }) [INFO] [stderr] 334 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/expression.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(left: SubExpression, right: SubExpression) -> SubExpression { [INFO] [stderr] 79 | | Box::new($t{left: left, right: right}) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 484 | binary_constructor!(Union); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/function.rs:563:8 [INFO] [stderr] | [INFO] [stderr] 563 | if x == y { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(x - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/function.rs:563:8 [INFO] [stderr] | [INFO] [stderr] 563 | if x == y { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/node_test.rs:167:35 [INFO] [stderr] | [INFO] [stderr] 167 | Some(ref name) if name == &pi.target() => result.add(context.node), [INFO] [stderr] | ^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `pi.target()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:514:9 [INFO] [stderr] | [INFO] [stderr] 514 | assert_eq!(1.5, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:514:9 [INFO] [stderr] | [INFO] [stderr] 514 | assert_eq!(1.5, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | assert_eq!(-1.5, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | assert_eq!(-1.5, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:526:9 [INFO] [stderr] | [INFO] [stderr] 526 | assert_eq!(1.5, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:526:9 [INFO] [stderr] | [INFO] [stderr] 526 | assert_eq!(1.5, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:538:9 [INFO] [stderr] | [INFO] [stderr] 538 | assert_eq!(1.0, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:538:9 [INFO] [stderr] | [INFO] [stderr] 538 | assert_eq!(1.0, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:544:9 [INFO] [stderr] | [INFO] [stderr] 544 | assert_eq!(0.0, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:544:9 [INFO] [stderr] | [INFO] [stderr] 544 | assert_eq!(0.0, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:558:9 [INFO] [stderr] | [INFO] [stderr] 558 | assert_eq!(42.42, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:558:9 [INFO] [stderr] | [INFO] [stderr] 558 | assert_eq!(42.42, v.number()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sxd-xpath`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6fabf09239e0612a78b2ffc7cdfe376def16d3926ad5eb6f8da509744eb6fbc3"` [INFO] running `"docker" "rm" "-f" "6fabf09239e0612a78b2ffc7cdfe376def16d3926ad5eb6f8da509744eb6fbc3"` [INFO] [stdout] 6fabf09239e0612a78b2ffc7cdfe376def16d3926ad5eb6f8da509744eb6fbc3