[INFO] crate sublime_fuzzy 0.6.0 is already in cache [INFO] extracting crate sublime_fuzzy 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/sublime_fuzzy/0.6.0 [INFO] extracting crate sublime_fuzzy 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sublime_fuzzy/0.6.0 [INFO] validating manifest of sublime_fuzzy-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sublime_fuzzy-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sublime_fuzzy-0.6.0 [INFO] finished frobbing sublime_fuzzy-0.6.0 [INFO] frobbed toml for sublime_fuzzy-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/sublime_fuzzy/0.6.0/Cargo.toml [INFO] started frobbing sublime_fuzzy-0.6.0 [INFO] finished frobbing sublime_fuzzy-0.6.0 [INFO] frobbed toml for sublime_fuzzy-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sublime_fuzzy/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sublime_fuzzy-0.6.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sublime_fuzzy/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcc57f6b23f6dc8eb448e12a146883514593e62d3f9a1702d61c47c50211c3eb [INFO] running `"docker" "start" "-a" "fcc57f6b23f6dc8eb448e12a146883514593e62d3f9a1702d61c47c50211c3eb"` [INFO] [stderr] Checking sublime_fuzzy v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matching.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matching.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | bonus_consecutive: bonus_consecutive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bonus_consecutive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | bonus_word_start: bonus_word_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bonus_word_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | bonus_coverage: bonus_coverage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bonus_coverage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | penalty_distance: penalty_distance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `penalty_distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | charmap: charmap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | word_starts: word_starts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `word_starts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matching.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matching.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | bonus_consecutive: bonus_consecutive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bonus_consecutive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | bonus_word_start: bonus_word_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bonus_word_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | bonus_coverage: bonus_coverage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bonus_coverage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | penalty_distance: penalty_distance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `penalty_distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scoring.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | charmap: charmap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | word_starts: word_starts, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `word_starts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 61 | | if !prev_is_start && (prev_is_upper != is_upper) { [INFO] [stderr] 62 | | is_start = true; [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if !prev_is_start && (prev_is_upper != is_upper) { [INFO] [stderr] 61 | is_start = true; [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | return pieces.join(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pieces.join("")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 61 | | if !prev_is_start && (prev_is_upper != is_upper) { [INFO] [stderr] 62 | | is_start = true; [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if !prev_is_start && (prev_is_upper != is_upper) { [INFO] [stderr] 61 | is_start = true; [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | return pieces.join(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pieces.join("")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matching::Match` [INFO] [stderr] --> src/matching.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | Match { [INFO] [stderr] 21 | | score: 0, [INFO] [stderr] 22 | | matches: Vec::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/matching.rs:71:33 [INFO] [stderr] | [INFO] [stderr] 71 | current_start = index.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/matching.rs:76:26 [INFO] [stderr] | [INFO] [stderr] 76 | last_index = index.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parse.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | charmap.entry(c).or_insert(Vec::new()).push(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | if self.pattern.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.pattern.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | .map_or(None, |s| Some(s)); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:186:26 [INFO] [stderr] | [INFO] [stderr] 186 | best_score = positions.iter() [INFO] [stderr] | __________________________^ [INFO] [stderr] 187 | | // Get score for every position [INFO] [stderr] 188 | | .filter_map(|pos| self.score_deep(0, *pos, 0)) [INFO] [stderr] 189 | | // Only take the highest score [INFO] [stderr] 190 | | .max() [INFO] [stderr] 191 | | .map_or(None, |s| Some(s)); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `matching::Match` [INFO] [stderr] --> src/matching.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | Match { [INFO] [stderr] | [INFO] [stderr] 21 | | score: 0, [INFO] [stderr] 22 | | matches: Vec::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 186 | best_score = positions.iter() [INFO] [stderr] 187 | // Get score for every position [INFO] [stderr] 188 | .filter_map(|pos| self.score_deep(0, *pos, 0)) [INFO] [stderr] 189 | // Only take the highest score [INFO] [stderr] 190 | .max().and_then(|s| Some(s)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/matching.rs:71:33 [INFO] [stderr] | [INFO] [stderr] 71 | current_start = index.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:258:31 [INFO] [stderr] | [INFO] [stderr] 258 | .map_or(None, |s| Some(s)); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/matching.rs:76:26 [INFO] [stderr] | [INFO] [stderr] 76 | last_index = index.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:247:30 [INFO] [stderr] | [INFO] [stderr] 247 | let best_score = occurences.iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 248 | | .filter_map(|pos| { [INFO] [stderr] 249 | | if (pos - offset) == 1 { [INFO] [stderr] 250 | | self.score_deep(next_index, *pos, consecutive + 1) [INFO] [stderr] ... | [INFO] [stderr] 257 | | // Put `Score` into `Option` [INFO] [stderr] 258 | | .map_or(None, |s| Some(s)); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 247 | let best_score = occurences.iter() [INFO] [stderr] 248 | .filter_map(|pos| { [INFO] [stderr] 249 | if (pos - offset) == 1 { [INFO] [stderr] 250 | self.score_deep(next_index, *pos, consecutive + 1) [INFO] [stderr] 251 | } else { [INFO] [stderr] 252 | self.score_deep(next_index, *pos, 0) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | / occurences [INFO] [stderr] 292 | | .iter() [INFO] [stderr] 293 | | .filter(|&i| i >= &offset) [INFO] [stderr] 294 | | .map(|i| i.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 291 | occurences [INFO] [stderr] 292 | .iter() [INFO] [stderr] 293 | .filter(|&i| i >= &offset).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:293:30 [INFO] [stderr] | [INFO] [stderr] 293 | .filter(|&i| i >= &offset) [INFO] [stderr] | ^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | .map(|i| i.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:320:8 [INFO] [stderr] | [INFO] [stderr] 320 | if parse::condense(pattern, true).len() == 0 || target.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parse::condense(pattern, true).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:320:53 [INFO] [stderr] | [INFO] [stderr] 320 | if parse::condense(pattern, true).len() == 0 || target.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parse.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | charmap.entry(c).or_insert(Vec::new()).push(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | if self.pattern.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.pattern.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | .map_or(None, |s| Some(s)); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:186:26 [INFO] [stderr] | [INFO] [stderr] 186 | best_score = positions.iter() [INFO] [stderr] | __________________________^ [INFO] [stderr] 187 | | // Get score for every position [INFO] [stderr] 188 | | .filter_map(|pos| self.score_deep(0, *pos, 0)) [INFO] [stderr] 189 | | // Only take the highest score [INFO] [stderr] 190 | | .max() [INFO] [stderr] 191 | | .map_or(None, |s| Some(s)); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 186 | best_score = positions.iter() [INFO] [stderr] 187 | // Get score for every position [INFO] [stderr] 188 | .filter_map(|pos| self.score_deep(0, *pos, 0)) [INFO] [stderr] 189 | // Only take the highest score [INFO] [stderr] 190 | .max().and_then(|s| Some(s)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:258:31 [INFO] [stderr] | [INFO] [stderr] 258 | .map_or(None, |s| Some(s)); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:247:30 [INFO] [stderr] | [INFO] [stderr] 247 | let best_score = occurences.iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 248 | | .filter_map(|pos| { [INFO] [stderr] 249 | | if (pos - offset) == 1 { [INFO] [stderr] 250 | | self.score_deep(next_index, *pos, consecutive + 1) [INFO] [stderr] ... | [INFO] [stderr] 257 | | // Put `Score` into `Option` [INFO] [stderr] 258 | | .map_or(None, |s| Some(s)); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 247 | let best_score = occurences.iter() [INFO] [stderr] 248 | .filter_map(|pos| { [INFO] [stderr] 249 | if (pos - offset) == 1 { [INFO] [stderr] 250 | self.score_deep(next_index, *pos, consecutive + 1) [INFO] [stderr] 251 | } else { [INFO] [stderr] 252 | self.score_deep(next_index, *pos, 0) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | / occurences [INFO] [stderr] 292 | | .iter() [INFO] [stderr] 293 | | .filter(|&i| i >= &offset) [INFO] [stderr] 294 | | .map(|i| i.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 291 | occurences [INFO] [stderr] 292 | .iter() [INFO] [stderr] 293 | .filter(|&i| i >= &offset).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:293:30 [INFO] [stderr] | [INFO] [stderr] 293 | .filter(|&i| i >= &offset) [INFO] [stderr] | ^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | .map(|i| i.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:320:8 [INFO] [stderr] | [INFO] [stderr] 320 | if parse::condense(pattern, true).len() == 0 || target.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parse::condense(pattern, true).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:320:53 [INFO] [stderr] | [INFO] [stderr] 320 | if parse::condense(pattern, true).len() == 0 || target.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `sublime_fuzzy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcc57f6b23f6dc8eb448e12a146883514593e62d3f9a1702d61c47c50211c3eb"` [INFO] running `"docker" "rm" "-f" "fcc57f6b23f6dc8eb448e12a146883514593e62d3f9a1702d61c47c50211c3eb"` [INFO] [stdout] fcc57f6b23f6dc8eb448e12a146883514593e62d3f9a1702d61c47c50211c3eb