[INFO] crate subcmd 0.1.0 is already in cache
[INFO] extracting crate subcmd 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/subcmd/0.1.0
[INFO] extracting crate subcmd 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/subcmd/0.1.0
[INFO] validating manifest of subcmd-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of subcmd-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing subcmd-0.1.0
[INFO] finished frobbing subcmd-0.1.0
[INFO] frobbed toml for subcmd-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/subcmd/0.1.0/Cargo.toml
[INFO] started frobbing subcmd-0.1.0
[INFO] finished frobbing subcmd-0.1.0
[INFO] frobbed toml for subcmd-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/subcmd/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting subcmd-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/subcmd/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6bc0e05e2886ca90c68c29fa8355c61187a0dda602236f081482209584caebe6
[INFO] running `"docker" "start" "-a" "6bc0e05e2886ca90c68c29fa8355c61187a0dda602236f081482209584caebe6"`
[INFO] [stderr]     Checking tabwriter v0.1.25
[INFO] [stderr]     Checking subcmd v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handler.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             program_name: program_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handler.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/handler.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             write!(&mut tw, "    {}\t{}\n", cmd.name(), cmd.description()).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wrapper.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             cmd: cmd,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `cmd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wrapper.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handler.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             program_name: program_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `program_name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handler.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/handler.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             write!(&mut tw, "    {}\t{}\n", cmd.name(), cmd.description()).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wrapper.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             cmd: cmd,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `cmd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/wrapper.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `handler::CmdHandler<'a>`
[INFO] [stderr]   --> src/handler.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | /     pub fn new() -> CmdHandler<'a> {
[INFO] [stderr] 45 | |         let args: Vec<String> = env::args().collect();
[INFO] [stderr] 46 | |         let program_name = args[0].clone();
[INFO] [stderr] 47 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |         }
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/handler.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 | /         match self.description {
[INFO] [stderr] 93 | |             Some(descr) => brief.push_str(&format!("{}\n\n", descr)),
[INFO] [stderr] 94 | |             None => {}
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(descr) = self.description { brief.push_str(&format!("{}\n\n", descr)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `argv`
[INFO] [stderr]    --> src/handler.rs:237:23
[INFO] [stderr]     |
[INFO] [stderr] 237 |         fn run(&self, argv: &Vec<String>) {
[INFO] [stderr]     |                       ^^^^ help: consider using `_argv` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `argv`
[INFO] [stderr]    --> src/handler.rs:254:23
[INFO] [stderr]     |
[INFO] [stderr] 254 |         fn run(&self, argv: &Vec<String>) {
[INFO] [stderr]     |                       ^^^^ help: consider using `_argv` instead
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/handler.rs:149:16
[INFO] [stderr]     |
[INFO] [stderr] 149 |             if matches.free.len() != 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matches.free.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/handler.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         match sim_cmd {
[INFO] [stderr] 189 | |             Some(cmd) => {
[INFO] [stderr] 190 | |                 let mut msg = Message::new();
[INFO] [stderr] 191 | |                 msg.set_error(true);
[INFO] [stderr] ...   |
[INFO] [stderr] 196 | |             None => {}
[INFO] [stderr] 197 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 188 |         if let Some(cmd) = sim_cmd {
[INFO] [stderr] 189 |     let mut msg = Message::new();
[INFO] [stderr] 190 |     msg.set_error(true);
[INFO] [stderr] 191 |     msg.add_line("No such subcommand\n");
[INFO] [stderr] 192 |     msg.add_line(&format!("    Did you mean `{}`?", cmd.name()));
[INFO] [stderr] 193 |     return CmdResult::BadUsage(msg);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::Message`
[INFO] [stderr]   --> src/message.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> Message {
[INFO] [stderr] 27 | |         Message {
[INFO] [stderr] 28 | |             text: String::with_capacity(160),
[INFO] [stderr] 29 | |             is_error: false,
[INFO] [stderr] 30 | |             formated: cfg!(target_os = "macos") || cfg!(target_os = "linux"),
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:88:25
[INFO] [stderr]    |
[INFO] [stderr] 88 |     fn run(&self, argv: &Vec<String>);
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `handler::CmdHandler<'a>`
[INFO] [stderr]   --> src/handler.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | /     pub fn new() -> CmdHandler<'a> {
[INFO] [stderr] 45 | |         let args: Vec<String> = env::args().collect();
[INFO] [stderr] 46 | |         let program_name = args[0].clone();
[INFO] [stderr] 47 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |         }
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/handler.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 | /         match self.description {
[INFO] [stderr] 93 | |             Some(descr) => brief.push_str(&format!("{}\n\n", descr)),
[INFO] [stderr] 94 | |             None => {}
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(descr) = self.description { brief.push_str(&format!("{}\n\n", descr)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/handler.rs:149:16
[INFO] [stderr]     |
[INFO] [stderr] 149 |             if matches.free.len() != 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matches.free.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/handler.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         match sim_cmd {
[INFO] [stderr] 189 | |             Some(cmd) => {
[INFO] [stderr] 190 | |                 let mut msg = Message::new();
[INFO] [stderr] 191 | |                 msg.set_error(true);
[INFO] [stderr] ...   |
[INFO] [stderr] 196 | |             None => {}
[INFO] [stderr] 197 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 188 |         if let Some(cmd) = sim_cmd {
[INFO] [stderr] 189 |     let mut msg = Message::new();
[INFO] [stderr] 190 |     msg.set_error(true);
[INFO] [stderr] 191 |     msg.add_line("No such subcommand\n");
[INFO] [stderr] 192 |     msg.add_line(&format!("    Did you mean `{}`?", cmd.name()));
[INFO] [stderr] 193 |     return CmdResult::BadUsage(msg);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::Message`
[INFO] [stderr]   --> src/message.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> Message {
[INFO] [stderr] 27 | |         Message {
[INFO] [stderr] 28 | |             text: String::with_capacity(160),
[INFO] [stderr] 29 | |             is_error: false,
[INFO] [stderr] 30 | |             formated: cfg!(target_os = "macos") || cfg!(target_os = "linux"),
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `FakeCmdRunCalled` should have an upper case name such as `FAKE_CMD_RUN_CALLED`
[INFO] [stderr]   --> src/wrapper.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     static mut FakeCmdRunCalled: bool = false;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:88:25
[INFO] [stderr]    |
[INFO] [stderr] 88 |     fn run(&self, argv: &Vec<String>);
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.44s
[INFO] running `"docker" "inspect" "6bc0e05e2886ca90c68c29fa8355c61187a0dda602236f081482209584caebe6"`
[INFO] running `"docker" "rm" "-f" "6bc0e05e2886ca90c68c29fa8355c61187a0dda602236f081482209584caebe6"`
[INFO] [stdout] 6bc0e05e2886ca90c68c29fa8355c61187a0dda602236f081482209584caebe6